Re: jmx-dev Codereview request: 8023954 MBean*Info.equals: throw NPE

2013-09-16 Thread David Holmes
On 17/09/2013 2:17 AM, shanliang wrote: Hi, Still need OK from a code reviewer, thanks Daniel for the review. Reviewed. (I'd seen this one earlier by mistake :) ) David Web: http://cr.openjdk.java.net/~sjiang/jdk-8023954/01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8023954 Thanks, Sh

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-09-16 Thread yumin . qi
Changeset: 621eda7235d2 Author:minqi Date: 2013-09-16 15:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/621eda7235d2 7164841: Improvements to the GC log file rotation Summary: made changes to easily identify current log file in rotation. Parameterize the input

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-09-16 Thread karen . kinnear
Changeset: 42863137168c Author:acorn Date: 2013-09-16 17:57 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/42863137168c 8024647: Default method resolution with private superclass method Reviewed-by: kamg, minqi ! src/share/vm/classfile/defaultMethods.cpp Changese

hg: hsx/hotspot-rt/hotspot: 6986195: correctly identify Ubuntu as the operating system in crash report instead of "Debian"

2013-09-16 Thread daniel . daugherty
Changeset: 4472884d8b37 Author:dcubed Date: 2013-09-16 12:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4472884d8b37 6986195: correctly identify Ubuntu as the operating system in crash report instead of "Debian" Summary: Cleanup and document how various Linux

Re: code review request for more StringTable verification code (8019835)

2013-09-16 Thread Daniel D. Daugherty
Thanks for re-review! Dan On 9/16/13 4:17 PM, Ron Durbin wrote: Dan it looks good, Thx Ron -Original Message- From: Daniel D. Daugherty Sent: Monday, September 16, 2013 11:48 AM To: Serguei Spitsyn Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject

RE: code review request for more StringTable verification code (8019835)

2013-09-16 Thread Ron Durbin
Dan it looks good, Thx Ron > -Original Message- > From: Daniel D. Daugherty > Sent: Monday, September 16, 2013 11:48 AM > To: Serguei Spitsyn > Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: Re: code review request for more StringTable verificati

RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-16 Thread Volker Simonis
Resending this to more lists as requested by Alan Bateman with the kind request to anybody to review the parts for which he feels responsible:) For those not up to date, this change is part of the ongoing PowerPC/AIX Porting Project: http://openjdk.java.net/projects/ppc-aix-port https://wiki.openj

hg: jdk8/tl/jdk: 8024874: Copy-paste typo in the spec for j.u.Comparator.thenComparing(Function, Comparator)

2013-09-16 Thread henry . jen
Changeset: 86aa8e7503e9 Author:henryjen Date: 2013-09-16 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86aa8e7503e9 8024874: Copy-paste typo in the spec for j.u.Comparator.thenComparing(Function, Comparator) Reviewed-by: mduigou ! src/share/classes/java/util/Comparat

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Omair Majid
On 09/16/2013 01:31 PM, Gerald Thornbrugh wrote: > OK, one more time: > > 2181 // Searching system-release (Red Hat) and os-release (other > Linuxes) are a > 2182 // next to last resort. The os-release file is a new standard that > contains > 2183 // distribution information and the system-releas

Re: code review request for more StringTable verification code (8019835)

2013-09-16 Thread serguei.spit...@oracle.com
Looks nice. Thanks, Serguei On 9/16/13 10:08 AM, Daniel D. Daugherty wrote: Greetings, I have some new diagnostic code that I would like to add to the system that was developed during my hunt for this bug: 8019835 Strings interned in different threads equal but does not == http://bugs

Re: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

2013-09-16 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 9/16/13 8:44 AM, Peter Allwin wrote: Hello! Please review this simple fix for a potential socket handle leak in the hprof agent's windows implementation, as discovered by parfait. bug: https://bugs.openjdk.java.net/browse/JDK-8012923 cr: http://cr.openjdk.java.

Re: code review request for more StringTable verification code (8019835)

2013-09-16 Thread Daniel D. Daugherty
Thanks for quick re-review! Dan On 9/16/13 11:43 AM, serguei.spit...@oracle.com wrote: Looks nice. Thanks, Serguei On 9/16/13 10:08 AM, Daniel D. Daugherty wrote: Greetings, I have some new diagnostic code that I would like to add to the system that was developed during my hunt for this bu

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Daniel D. Daugherty
On 9/16/13 11:10 AM, Gerald Thornbrugh wrote: Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was more cle

Re: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

2013-09-16 Thread Staffan Larsen
Looks good. /Staffan On 16 sep 2013, at 17:44, Peter Allwin wrote: > Hello! > > Please review this simple fix for a potential socket handle leak in the hprof > agent's windows implementation, as discovered by parfait. > > bug: https://bugs.openjdk.java.net/browse/JDK-8012923 > cr: http://cr.

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Omair Majid
Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: > Sorry about the delay of my response. No problem :) > I chose to place the /etc/SuSE-release file in front of the > /etc/os-release file because the > SuSE-release file was more clear and concise than the os-release file. I see. Yes,

code review request for more StringTable verification code (8019835)

2013-09-16 Thread Daniel D. Daugherty
Greetings, I have some new diagnostic code that I would like to add to the system that was developed during my hunt for this bug: 8019835 Strings interned in different threads equal but does not == http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019835 https://bugs.openjdk.java.n

hg: jdk8/tl/jdk: 6458027: Disabling IPv6 on a specific network interface causes problems

2013-09-16 Thread chris . hegarty
Changeset: db0fc2b71298 Author:msheppar Date: 2013-09-16 14:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db0fc2b71298 6458027: Disabling IPv6 on a specific network interface causes problems Summary: added a check to test if an interface is configured for IPv6 to native

RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

2013-09-16 Thread Peter Allwin
Hello! Please review this simple fix for a potential socket handle leak in the hprof agent's windows implementation, as discovered by parfait. bug: https://bugs.openjdk.java.net/browse/JDK-8012923 cr: http://cr.openjdk.java.net/~allwin/8012923/webrev.00/ Thanks! /peter

Re: jmx-dev Codereview request: 8023954 MBean*Info.equals: throw NPE

2013-09-16 Thread shanliang
Hi, Still need OK from a code reviewer, thanks Daniel for the review. Web: http://cr.openjdk.java.net/~sjiang/jdk-8023954/01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8023954 Thanks, Shanliang P.S. The bug id is 8023954, not 8023529, I put the wrong bug ID in the previous mails. Shanli

hg: jdk8/tl/nashorn: 2 new changesets

2013-09-16 Thread sundararajan . athijegannathan
Changeset: 38378024a332 Author:sundar Date: 2013-09-16 15:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/38378024a332 8024847: Java.to should accept mirror and external JSObjects as array-like objects as well Reviewed-by: hannesw, attila, lagergren ! src/jdk/nashorn/

hg: hsx/hotspot-rt/hotspot: 6900441: PlatformEvent.park(millis) on Linux could still be affected by changes to the time-of-day clock

2013-09-16 Thread david . holmes
Changeset: 2e6938dd68f2 Author:dholmes Date: 2013-09-16 07:38 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2e6938dd68f2 6900441: PlatformEvent.park(millis) on Linux could still be affected by changes to the time-of-day clock Summary: Associate CLOCK_MONOTONIC wi

hg: jdk8/tl/langtools: 8021112: Spurious unchecked warning reported by javac; ...

2013-09-16 Thread vicente . romero
Changeset: 4ce8148ffc4f Author:jlahoda Date: 2013-09-16 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4ce8148ffc4f 8021112: Spurious unchecked warning reported by javac 6480588: No way to suppress deprecation warnings when implementing deprecated interface Summa

Re: RR(S): JDK-7133122 SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not

2013-09-16 Thread Staffan Larsen
Good! /Staffan On 16 sep 2013, at 10:58, Dmitry Samersoff wrote: > Staffan, > > Thank you! Fixed (in-place). > > http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/ > > -Dmitry > > On 2013-09-16 10:04, Staffan Larsen wrote: >> A couple of small nits: >> >> line 721: there is a su

Re: RR(S): JDK-7133122 SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not

2013-09-16 Thread Dmitry Samersoff
Staffan, Thank you! Fixed (in-place). http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/ -Dmitry On 2013-09-16 10:04, Staffan Larsen wrote: > A couple of small nits: > > line 721: there is a superfluous + sign at the beginning of the line. > > line 729: confliction -> conflict > >