Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

> On 20 sep 2013, at 16:49, Yasumasa Suenaga wrote: > >> On 2013/09/20 23:34, Staffan Larsen wrote: >> >>> On 20 sep 2013, at 16:24, Yasumasa Suenaga wrote: >>> >>> I thought your code too. However... >>> >>> - These code is different from other code (rule?). >> >> Well, you are introducin

hg: hsx/hotspot-rt/hotspot: 60 new changesets

Changeset: 9cd0183fe325 Author:cl Date: 2013-09-12 11:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9cd0183fe325 Added tag jdk8-b107 for changeset 5b7f90aab3ad ! .hgtags Changeset: a09fe9d1e016 Author:amurillo Date: 2013-09-13 00:25 -0700 URL:

code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Greetings, I have the initial support for Full Debug Symbols (FDS) on MacOS X done and ready for review: 7165611 implement Full Debug Symbols on MacOS X hotspot https://bugs.openjdk.java.net/browse/JDK-7165611 Here is the JDK8/HSX-25 webrev URL: OpenJDK: http://cr.openjdk.java.net/~dc

Re: Code review request for Linux version id fix (6986195)

Hi Omair, Thanks for the review! Jerry On 09/16/2013 01:31 PM, Gerald Thornbrugh wrote: OK, one more time: 2181 // Searching system-release (Red Hat) and os-release (other Linuxes) are a 2182 // next to last resort. The os-release file is a new standard that contains 2183 // distribution inf

hg: jdk8/tl/jdk: 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

Changeset: 2552cd270350 Author:bpb Date: 2013-09-20 15:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2552cd270350 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent Summary: Explic

hg: jdk8/tl/langtools: 8023835: TreeMaker.QualIdent() too leafy

Changeset: 41599b57d262 Author:jlahoda Date: 2013-09-20 16:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/41599b57d262 8023835: TreeMaker.QualIdent() too leafy Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/tree/MakeQ

hg: jdk8/tl/langtools: 8022567: Javac Should Generate Warnings For Raw Array Type

Changeset: 8d1c48de706d Author:jlahoda Date: 2013-09-19 17:05 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8d1c48de706d 8022567: Javac Should Generate Warnings For Raw Array Type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/ja

hg: jdk8/tl/jdk: 8010430: Math.round has surprising behavior for odd values of ulp 1

Changeset: 917fffe971c8 Author:bpb Date: 2013-09-11 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/917fffe971c8 8010430: Math.round has surprising behavior for odd values of ulp 1 Summary: If the effective floating point exponent is zero return the significand includin

Re: Code review request for Linux version id fix (6986195)

Hi Omair, I am the originator for the fix, Dan posted my review for me. Sorry about the delay of my response. In the openSuSE case the /etc/SuSE-release file seemed to have a more clear and concise distribution information than the /etc/os-release file. The /etc/SuSE-release file contains three

Re: Code review request for Linux version id fix (6986195)

Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was more clear and concise than the os-release file. I see

Re: Code review request for Linux version id fix (6986195)

Hi Dan, On 9/16/13 11:10 AM, Gerald Thornbrugh wrote: Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was

Re: RFR: Changes to disable and/or remove Solaris 32-bit from JDK8

On 2013-09-11 00:00, Kumar Srinivasan wrote: Here are the updated changes: The build changes are here: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/ the delta changes since last reviewed: http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.1/webrev.delta/index.html The jdk c

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 7c29904fdfa2 Author:coleenp Date: 2013-09-20 18:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7c29904fdfa2 8014956: nashorn/api/javaaccess/MethodAccessTest.java test fails on sparc-solaris 64 Summary: reference_map[] array had uninitialized junk tha

hg: jdk8/tl/jdk: 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec

Changeset: c30dc8e7744e Author:psandoz Date: 2013-09-20 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c30dc8e7744e 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec Reviewed-by: alanb ! src/share/classes

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 1b03bed31241 Author:allwin Date: 2013-09-17 17:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b03bed31241 7196151: ParserTest SEGv on solaris Reviewed-by: sla, coleenp, ctornqvi, dsamersoff ! src/share/vm/services/diagnosticArgument.cpp Changeset:

Re: RFR: 6696975: JTop plugin fails if connected readonly to target JVM

Can we get someone to review Erik's latest changes below ? We need to close this issue. Thanks, Michel On Aug 19, 2013, at 11:25 AM, Erik Gahlin wrote: Still need a (r)eviewer ok to proceed - can I ask for this please? Here is the latest change: http://cr.openjdk.java.net/~egahlin/6696975_2

hg: jdk8/tl/jdk: 8024253: ThreadLocal random can use SecureRandom for the initial seed

Changeset: 7913855ff66c Author:psandoz Date: 2013-09-20 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7913855ff66c 8024253: ThreadLocal random can use SecureRandom for the initial seed Reviewed-by: psandoz, chegar, alanb Contributed-by: Doug Lea , Peter Levart , Guy S

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 4f9a42c33738 Author:coleenp Date: 2013-09-20 09:30 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4f9a42c33738 8022887: Assertion hit while using class and redefining it with RedefineClasses simultaneously Summary: Need to refetch each method from Insta

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

A few comments: 1) Seems to be two macros _AIX and AIX. Is this intended? NetworkInterface.c 2) line 1098: new style of variable declaration. First time we would have that in this code. I think it should be okay though 3) Can't comment on the AIX functionality, except I notic

hg: jdk8/tl/jdk: 7200277: [parfait] potential buffer overflow in npt/utf.c

Changeset: 94cc251d0c45 Author:sla Date: 2013-09-20 16:40 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94cc251d0c45 7200277: [parfait] potential buffer overflow in npt/utf.c Reviewed-by: dsamersoff, dcubed ! src/share/npt/utf.c

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

On 20 sep 2013, at 16:24, Yasumasa Suenaga wrote: > I thought your code too. However... > > - These code is different from other code (rule?). Well, you are introducing a new macro that is also different from other code, so I'm not sure how valid that argument is. > - Similar crash cases exi

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

On 2013/09/20 23:34, Staffan Larsen wrote: On 20 sep 2013, at 16:24, Yasumasa Suenaga wrote: I thought your code too. However... - These code is different from other code (rule?). Well, you are introducing a new macro that is also different from other code, so I'm not sure how valid that

Re: RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

Perfect! On 20 sep 2013, at 16:38, Fredrik Arvidsson wrote: > Hi > > > I assume that you have tested that the resulting dump is readable by > tools such as visualvm or eclipse MAT? > > > I used MAT to test the result of large and small heap dumps after my change. > I could successfull

RFR (S): 8016845: SA is unable to use hsdis on windows

Please help me review this: Bug: https://bugs.openjdk.java.net/browse/JDK-8016845 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8016845/webrev.00/ Small change was made in the sa.make file for windows to compile and link

Re: RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

Fredrik, This looks good! I assume that you have tested that the resulting dump is readable by tools such as visualvm or eclipse MAT? I very much dislike silent exit of the tests in general. In this case that will happen if it can't find a signed jmap binary on OS X. Unfortunately, I don't ha

Re: RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

Hi I assume that you have tested that the resulting dump is readable by tools such as visualvm or eclipse MAT? I used MAT to test the result of large and small heap dumps after my change. I could successfully parse and read heap files larger than 2Gb which is the current threshold for

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

I thought your code too. However... - These code is different from other code (rule?). - Similar crash cases exist. e.g. 6425580 and 7142442. These crashes are different from 6989981. However, I guess that crashed thread had pending exception and we need to fix with similar patch. So I t

Re: RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

On 9/20/13 3:49 AM, Staffan Larsen wrote: Please review this change to avoid a buffer overflow in npt/utf.c. webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ Thumbs up. src/share/npt/utf.c No comments Dan bug: https://bugs.openjdk.java.net/browse/JDK-7200277 Thanks, /Staffan

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

I see. CHECK_AND_CLEAR_AND_PRINT? Just kidding... :-) Maybe in this case we should not have this as a macro, but actually add the code after the two calls to call_special? Something like the code below. I personally think this is more readable than obscure macros that I have to go look up to un

hg: jdk8/tl/jdk: 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

Changeset: afe857b13b62 Author:kizune Date: 2013-09-20 17:56 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afe857b13b62 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales Reviewed-by: naoto, ksrini - test/tools/launcher/8017248/ClassÁ.java - test/

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

Hi Staffan, Thank you for your sponsoring! "CHECK_AND_CLEAR" is already defined in exceptions.hpp: ** #define CHECK_AND_CLEAR THREAD); if (HAS_PENDING_EXCEPTION) { CLEAR_PENDING_EXCEPTION; return;} (void)(0 ** I think that user wa

Re: RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

Staffan, Looks good for me. PS: > is redundant. -Dmitry On 2013-09-20 13:49, Staffan Larsen wrote: > Please review this change to avoid a buffer overflow in npt/utf.c. > > webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-7200277 > > T

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

Volker, I skimmed over the networking part of the changes, and nothing jumps out at me. I'd like to spend a little more time doing a more detailed review, but I will not have time to do this until after JavaOne. -Chris. On 09/16/2013 08:30 PM, Volker Simonis wrote: Resending this to more li

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 195be8ca5c97 Author:sundar Date: 2013-09-20 12:56 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/195be8ca5c97 8025111: undefined or null 'with' expression in empty with block should throw TypeError Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/co

Re: jmx-dev RFR: 8024613 javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

Jaroslav, It is a good idea to use the RMI Testlibrary. Better to call: agent.close(); at Line 55, close the RMIRegistry (rmid.shutdown(rmidPort) Line 55) does not ensure the JMX connector doing full clean, it is always better to do clean within a test. Shanliang Jaroslav Bachorik

RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

Hi Please help me and review the changes below: Webrev:http://cr.openjdk.java.net/~allwin/farvidss/6313383/webrev.00/ Bug:https://bugs.openjdk.java.net/browse/JDK-6313383 Thi

RFR: 8024613 javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

Please, review the following change for JDK-8024613 Issue: https://bugs.openjdk.java.net/browse/JDK-8024613 Webrev: http://cr.openjdk.java.net/~jbachorik/8024613/webrev.00/ The patch takes care of intermittent test failures caused by

Re: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

Yasuma, Thanks for finding and fixing this! I have re-opened the bug. Your patch looks good to me, but perhaps CATCH_AND_RETURN should be renamed CHECK_AND_CLEAR? I can sponsor the fix. Thanks, /Staffan On 20 sep 2013, at 12:41, Yasumasa Suenaga wrote: > Hi, > > I encountered this bug: >

JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions"

Hi, I encountered this bug: JDK-6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions" I read hs_err and attachListener.cpp, Java heap usage is very high and it could be OutOfMemoryError in AttachListener::init() . If JavaCalls::call_special() in AttachL

RFR(S): 7200277 [parfait] potential buffer overflow in npt/utf.c

Please review this change to avoid a buffer overflow in npt/utf.c. webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-7200277 Thanks, /Staffan

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 58fd427b454d Author:sla Date: 2013-09-20 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/58fd427b454d 8024985: com/sun/jdi/StepTest.java failed since jdk8b107 Reviewed-by: dcubed ! test/com/sun/jdi/ExceptionEvents.java ! test/com/sun/jdi/FilterNoMatch.java !

Re: RFR(L): 8024854: Basic changes and files to build the class library on AIX

Volker, The serviceability-related changes look ok to me (not a Reviewer). /Staffan On 16 sep 2013, at 21:30, Volker Simonis wrote: > Resending this to more lists as requested by Alan Bateman with the kind > request to anybody to review the parts for which he feels responsible:) > > For thos