Re: RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

Hi I made a small change and added a new review: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.01/ About this change: Space added after if statement. Regarding the comment about indentation. It seems like webrev

Re: RR(S): JDK-8004213 jdp packet need pid, broadcast interval and rmi server hostname fields.

Hi Dmitry, Looks good, thanks for fixing this! Regards, /peter On Oct 10, 2013, at 8:33 PM, Dmitry Samersoff wrote: > Hi Everyone, > > This fix covers > > JDK JDK-8004213 JDP packets should contain PID > JDK-8004215 JDP packets should contain the configured broadcast interval > JDK-8007071

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: 34f7a699cdef Author:sundar Date: 2013-10-10 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/34f7a699cdef 8026162: "this" in SAM adapter functions is wrong Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nasho

Re: RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

On 11/10/2013 5:45 PM, Fredrik Arvidsson wrote: Hi I made a small change and added a new review: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.01/ About this change: Space added after if statement. Thanks. Regar

RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

Hello! Looking for reviews of this fix where a jmxremote test left a worker thread running after completion. Fix is to flag the thread to finish and join before test method exit. bug: https://bugs.openjdk.java.net/browse/JDK-8004183 cr: http://cr.openjdk.java.net/~allwin/8004183/webrev.00 Than

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

Looks good to me. Shanliang Peter Allwin wrote: Hello! Looking for reviews of this fix where a jmxremote test left a worker thread running after completion. Fix is to flag the thread to finish and join before test method exit. bug: https://bugs.openjdk.java.net/browse/JDK-8004183 cr: http:

Re: RFR (XS) 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump

Frederik, It looks good. Thanks, Serguei On 10/11/13 12:45 AM, Fredrik Arvidsson wrote: Hi I made a small change and added a new review: http://cr.openjdk.java.net/~allwin/farvidss/8024425/webrev.01/ About this change: Spa

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

Hi Peter, Looks good to me - but you might want to use 'boolean' for isRunning rather than 'Boolean'. Joining on the daemon thread is probably not necessary, but there's no harm in it (the important part being isRunning=false + s.close()). best regards, -- daniel (not a reviewer) On 10/11/13 1

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

On 11/10/2013 8:18 PM, Daniel Fuchs wrote: Hi Peter, Looks good to me - but you might want to use 'boolean' for isRunning rather than 'Boolean'. Definitely! Joining on the daemon thread is probably not necessary, but there's no harm in it (the important part being isRunning=false + s.close()

RR(S): JDK-8024071 In ManagementAgent.start it should be possible to set the jdp.name parameter.

Please review the fix. Hotspot part http://cr.openjdk.java.net/~dsamersoff/JDK-8024071/webrev.01/hotspot Jdk http://cr.openjdk.java.net/~dsamersoff/JDK-8024071/webrev.01/hotspot Testing: Test for this fix is part of changes for JDK-8004213, http://cr.openjdk.java.net/~dsamersoff/JDK-8004213/

RR(S): JDK-8024071 In ManagementAgent.start it should be possible to set the jdp.name parameter.

Fixed typeo, please disregard previous letter. Please review the fix. Hotspot part http://cr.openjdk.java.net/~dsamersoff/JDK-8024071/webrev.01/hotspot Jdk http://cr.openjdk.java.net/~dsamersoff/JDK-8024071/webrev.01/jdk Testing: Test for this fix is part of changes for JDK-8004213, http:/

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 1c154cee43d9 Author:hannesw Date: 2013-10-11 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1c154cee43d9 8026292: Megamorphic setter fails with boolean value Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/MethodEmitter.java + test/script

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

Thanks for the feedback, good points! I've put an updated webrev here: http://cr.openjdk.java.net/~allwin/8004183/webrev.01/ Changes: boolean instead of Boolean no longer sets worker as daemon Regards, /peter On Oct 11, 2013, at 1:13 PM, David Holmes wrote: > On 11/10/2013 8:18 PM, D

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

Looks good! -- daniel On 10/11/13 2:32 PM, Peter Allwin wrote: Thanks for the feedback, good points! I've put an updated webrev here: http://cr.openjdk.java.net/~allwin/8004183/webrev.01/ Changes: boolean instead of Boolean no longer sets worker as daemon Regards, /peter On Oct 1

Re: RR(S): JDK-8024071 In ManagementAgent.start it should be possible to set the jdp.name parameter.

Dmitry, what is the purpose of the change in JMXStartStopTest.sh? The rest looks fine. -JB- On 11.10.2013 14:12, Dmitry Samersoff wrote: Fixed typeo, please disregard previous letter. Please review the fix. Hotspot part http://cr.openjdk.java.net/~dsamersoff/JDK-8024071/webrev.01/hotspot

Re: RR(S): JDK-8024071 In ManagementAgent.start it should be possible to set the jdp.name parameter.

On 2013-10-11 16:35, Jaroslav Bachorik wrote: > Dmitry, > > what is the purpose of the change in JMXStartStopTest.sh? To be able to run it without jtreg - i.e. if only TESTJAVA is set. -Dmitry > > The rest looks fine. > > -JB- > > On 11.10.2013 14:12, Dmitry Samersoff wrote: >> Fixed typeo,

Re: RFR: 8004183: test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java doesn't clean-up

+1! Olivier. Daniel Fuchs said on date 10/11/2013 2:34 PM: Looks good! -- daniel On 10/11/13 2:32 PM, Peter Allwin wrote: Thanks for the feedback, good points! I've put an updated webrev here: http://cr.openjdk.java.net/~allwin/8004183/webrev.01/ Changes: boolean instead of Boolean

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 4ad76262bac8 Author:mullan Date: 2013-10-11 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad76262bac8 8007292: Add JavaFX internal packages to package.access Summary: build hooks to allow closed restricted packages to be added to java.security file Reviewe

hg: jdk8/tl/langtools: 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type

Changeset: 872c4a898b38 Author:jlahoda Date: 2013-10-11 15:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/872c4a898b38 6278240: Exception from AnnotationValue.getValue() should list the found type not the required type Reviewed-by: darcy, jfranck, jjg ! src/share/c

hg: hsx/hotspot-rt/hotspot: 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed

Changeset: cd7ea1d79dac Author:sla Date: 2013-10-11 13:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd7ea1d79dac 8026199: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Compilation failed Summary: Fixed a compilation failure due to changed method na

hg: jdk8/tl/jdk: 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale

Changeset: cb373cf43294 Author:dxu Date: 2013-10-11 09:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb373cf43294 8025712: (props) Possible memory leak in java_props_md.c / ParseLocale Reviewed-by: naoto, chegar ! src/solaris/native/java/lang/java_props_md.c

Review request: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

Please, review this test fix. http://cr.openjdk.java.net/~stefank/7196801/webrev.00/ Most of the fix was implemented by Coleen, I've only done some small tweaks and updated some comments. The fix depends on these changes: JDK-8025996 Track metaspace usage when metaspace is expanded JDK-80

Re: Review request: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

Stefan, I added a check about the count exceeding 1 000 000 because it causes the test to create an invalid class file. With the shell script changes, it won't happen but I would be happy if that check were there so no one ever has to debug this thinking it has a corrupted constant pool ag

Re: Review request: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

On 10/11/13 7:44 PM, Coleen Phillimore wrote: Stefan, I added a check about the count exceeding 1 000 000 because it causes the test to create an invalid class file. With the shell script changes, it won't happen but I would be happy if that check were there so no one ever has to debug thi

Re: Review request: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

Looks good. Thanks! Coleen On 10/11/2013 2:02 PM, Stefan Karlsson wrote: On 10/11/13 7:44 PM, Coleen Phillimore wrote: Stefan, I added a check about the count exceeding 1 000 000 because it causes the test to create an invalid class file. With the shell script changes, it won't happen bu

Re: Review request: 7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2

On 10/11/13 8:04 PM, Coleen Phillimore wrote: Looks good. Thanks, Coleen. StefanK Thanks! Coleen On 10/11/2013 2:02 PM, Stefan Karlsson wrote: On 10/11/13 7:44 PM, Coleen Phillimore wrote: Stefan, I added a check about the count exceeding 1 000 000 because it causes the test to create

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 539144972c1e Author:sla Date: 2013-10-11 14:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/539144972c1e 8024425: VM_HeapDumper doesn't put anonymous classes in the heap dump Summary: Switched from using SystemDictionary to using ClassLoaderDataGraph t

hg: jdk8/tl/jdk: 8019526: (fs) Files.lines, etc without Charset parameter

Changeset: 9632de07d963 Author:alanb Date: 2013-10-11 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9632de07d963 8019526: (fs) Files.lines, etc without Charset parameter Reviewed-by: psandoz, henryjen ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/F

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Staffan, Closing the loop on this comment from code review round 0. I did this: $ sh ./configure --with-debug-level=slowdebug --disable-zip-debug-info $ make with the latest version that I'm about to send out for code review round 1. And I see this: $ find build -name '*.dSYM' -print

code review round 1 for Full Debug Symbols on MacOS X hotspot (7165611)

Greetings, I'm ready for code review round 1 of the FDS on MacOS X hotspot changes. Below is the original code review round 0 invite (slightly edited for clarity). Working on FDS is like pulling a thread on a sweater... so there are four additional changed files along with more changes to many of

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 28ca974cc21a Author:coleenp Date: 2013-10-11 11:23 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/28ca974cc21a 8022592: assert at constantTag.cpp:57: ShouldNotReachHere() Summary: more missing cases for JVM_CONSTANT_Method{Handle,Type}InError Reviewed-by

hg: jdk8/tl/jdk: 2 new changesets

Changeset: d23247aa7462 Author:vinnie Date: 2013-10-11 20:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d23247aa7462 8026301: DomainKeyStore doesn't cleanup correctly when storing to keystore Reviewed-by: mullan ! src/share/classes/sun/security/provider/DomainKeyStore.ja

hg: jdk8/tl/jdk: 8026213: Reflection support for private interface methods

Changeset: 4561460bf570 Author:rfield Date: 2013-10-11 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4561460bf570 8026213: Reflection support for private interface methods Reviewed-by: forax, psandoz, dholmes, jfranck Contributed-by: karen.kinn...@oracle.com ! src/sha

hg: jdk8/tl: 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations

Changeset: 3f9873789d44 Author:mduigou Date: 2013-10-11 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/3f9873789d44 8025796: hgforest.sh could trigger unbuffered output from hg without complicated machinations Reviewed-by: mduigou Contributed-by: Dmitry Samersoff ! commo

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 0db3ba3f6870 Author:hseigel Date: 2013-10-11 15:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0db3ba3f6870 8026041: JVM crashes with assert "assert(is_updated()) failed: must not be clear" with -XX:+PrintGCApplicationConcurrentTime in -Xcomp mode Su

hg: hsx/hotspot-rt/hotspot: 18 new changesets

Changeset: ebfa5793d349 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ebfa5793d349 Added tag jdk8-b110 for changeset 6209b0ed51c0 ! .hgtags Changeset: 562a3d356de6 Author:amurillo Date: 2013-10-04 14:10 -0700 URL: