Changeset: a45acc8de0f3
Author:wetmore
Date: 2013-10-16 23:32 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a45acc8de0f3
8026762: jdk8-tl builds windows builds failing in corba - javac: no source files
Reviewed-by: katleman, dholmes
! makefiles/GenerateClasses.gmk
Changeset: ce266885222d
Author:peytoia
Date: 2013-10-17 13:57 +0900
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce266885222d
8025703: Update LSR datafile for BCP 47
Reviewed-by: okutsu
! src/share/classes/sun/util/locale/LocaleEquivalentMaps.java
+ test/java/util/Locale/Bug8025
Changeset: e2e3c2c249e2
Author:henryjen
Date: 2013-10-16 21:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2e3c2c249e2
8026768: java.util.Map.Entry comparingBy methods missing @since 1.8
Reviewed-by: dholmes
! src/share/classes/java/util/Map.java
Hi Dmitry,
In
716 static inline size_t round_page(int x){
717 static int page_size;
718
719 page_size = sysconf(_SC_PAGE_SIZE);
720 return ROUNDUP(x,page_size);
721 }
Does page_size being static mean that line 719 will only be executed
once? Otherwise it serves no purpose.
Typo:
Hi Jaroslav,
Minor nit: os::elapsed_time should really be defined in terms of the
other functions ie:
return ((double) os::elapsed_counter()) / os::elapsed_frequency();
I also prefer the cast above as it is very clear that we will be doing a
floating-point division.
Aside: AFAICS os::elaps
Changeset: d248425bcfe8
Author:hseigel
Date: 2013-10-16 14:32 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d248425bcfe8
8024804: Crash when InterfaceMethodref resolves to Object.registerNatives
Summary: Added check for NULL prior to continuation of method look up
On 2013-10-14 11:49, Staffan Larsen wrote:
> The fix looks good, but I have a problem with the ROUNDUP_PAGE macro. First,
> I don't like having macros defined in the middle of a method. Second, the
> definition of the macro includes the value of a local variable which is a bit
> hairy. Can't you
Staffan,
Just realized that my letter remain unsent.
Fixed in-place, press shift-reload.
http://cr.openjdk.java.net/~dsamersoff/JDK-8025812/webrev.01/
-Dmitry
On 2013-10-14 11:49, Staffan Larsen wrote:
> The fix looks good, but I have a problem with the ROUNDUP_PAGE macro. First,
> I don't l
Changeset: 60e3cdbe8cdf
Author:aefimov
Date: 2013-10-13 14:19 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60e3cdbe8cdf
8025255: (tz) Support tzdata2013g
Reviewed-by: okutsu, mfang
! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/africa
! make/sun/javazic/tzdata
Changeset: 7f6481e5fe3a
Author:emc
Date: 2013-10-16 16:33 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7f6481e5fe3a
8026286: Improper locking of annotation queues causes assertion failures.
8026063: Calls to annotate.flush() cause incorrect type annotations to be
gen
Changeset: cf9cb3d241a3
Author:mduigou
Date: 2013-10-16 13:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf9cb3d241a3
8025910: rename substream(long) -> skip and remove substream(long,long)
Reviewed-by: psandoz, henryjen
! src/share/classes/java/util/stream/DoublePipelin
Changeset: 042cf42c72bd
Author:simonis
Date: 2013-10-16 15:06 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/042cf42c72bd
8026703: Wrongly placed element in Event-Based JVM Tracing .xsl
files
Reviewed-by: sla, kamg
! src/share/vm/trace/traceEventClasses.xsl
! sr
Changeset: 2ef43f3a901c
Author:dfuchs
Date: 2013-10-16 20:47 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ef43f3a901c
8013839: Enhance Logger API for handling of resource bundles
4814565: (rb) add method to get basename from a ResourceBundle
Summary: adds Logger.setResourc
Changeset: d7e155f874a7
Author:jjg
Date: 2013-10-16 10:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d7e155f874a7
8026704: Build failure with --enable-debug
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/com/sun/tool
Erik,
(it's not necessary to cross-post between hotspot-dev and
hotspot-gc-dev, so I removed hotspot-gc from the CC list)
On 2013-10-16 18:09, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop d
Erik,
Thank you for doing the extra cleanup for this. Did you run the
nsk.jvmti.testlist tests too though? These things have a nasty way of
interacting. The code looks good though.
thanks,
Coleen
On 10/16/2013 12:09 PM, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop
On 15.10.2013 08:49, David Holmes wrote:
Hi Jaroslav,
os_bsd.cpp / os_linux.cpp:
If you don't have a monotonic clock you leave timer_frequency set to 0!
(So you need to test on a system without a monotonic clock, or else
force it to act as-if not present.)
That aside I don't trust clock_getres
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector.
Instead of registering the oop as an unhandled oop, which would have
worked, I decided to wrap the oop in a handle as long as it is on the
stack.
A JvmtiBre
Changeset: 445667b19e32
Author:dfuchs
Date: 2013-10-16 17:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445667b19e32
8011638: Remove deprecated methods in sun.util.logging.PlatformLogger
Reviewed-by: psandoz, mchung, alanb, chegar
! src/share/classes/sun/font/FontUtiliti
Looks fine to me.
Shanliang
Jaroslav Bachorik wrote:
On 2.10.2013 12:55, Jaroslav Bachorik wrote:
On 20.9.2013 14:54, shanliang wrote:
Jaroslav,
It is a good idea to use the RMI Testlibrary.
Better to call:
agent.close();
at Line 55, close the RMIRegistry (rmid.shutdown(rmidPort)
Hi Jaroslav,
Looks fine to me (not a reviewer).
-- daniel
On 10/16/13 4:44 PM, Jaroslav Bachorik wrote:
On 2.10.2013 12:55, Jaroslav Bachorik wrote:
On 20.9.2013 14:54, shanliang wrote:
Jaroslav,
It is a good idea to use the RMI Testlibrary.
Better to call:
agent.close();
at Line
On 2.10.2013 12:55, Jaroslav Bachorik wrote:
On 20.9.2013 14:54, shanliang wrote:
Jaroslav,
It is a good idea to use the RMI Testlibrary.
Better to call:
agent.close();
at Line 55, close the RMIRegistry (rmid.shutdown(rmidPort) Line 55)
does not ensure the JMX connector doing full cl
Please, review this simple test change.
The test tries to get the number of times a certain thread was blocked
during the test run and intermittently fails with the difference of 1 -
the expected number is 4 but the reported number is 3.
When updating the thread statistics (the blocked count
Changeset: d8eec0e3a023
Author:robm
Date: 2013-10-16 15:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8eec0e3a023
8026245: InetAddress.getLocalHost crash if IPv6 disabled (macosx)
Reviewed-by: chegar, alanb
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/
Hi,
Please review the following fix, main issue here is that we should clone
an internal variable before returning.
webrev:
http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/
bug
https://bugs.openjdk.java.net/browse/JDK-8026028
Thanks,
Shanliang
Changeset: 76a7c0bc74fd
Author:erikj
Date: 2013-10-16 13:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76a7c0bc74fd
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! makefiles/GendataBreakIterator.gmk
! makefiles/Generat
Changeset: 438c54c148a6
Author:erikj
Date: 2013-10-16 13:49 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/438c54c148a6
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! makefiles/BuildCorba.gmk
Changeset: af81988013b5
Author:erikj
Date: 2013-10-16 13:50 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/af81988013b5
6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar
Reviewed-by: dholmes, chegar
! common/makefiles/JavaCompilation.gmk
! common/makefiles/RM
This bug got a bit lost from my radar after vacation, but I've picked it
again now. I've moved Arrays.asList() as suggested. In further testing
of the fix though, I found that the include list is not enough, as one
of the expected method exit events is from String.intern(), which might
also be
Changeset: 9ea6a464c147
Author:igerasim
Date: 2013-10-15 21:15 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ea6a464c147
8023431: Test java/util/zip/GZIP/GZIPInZip.java failed
Summary: Properly close PipedStreams. Additional testing for malformed input
Reviewed-by: darcy, s
Changeset: 7fe6ef09d242
Author:farvidsson
Date: 2013-10-16 09:20 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7fe6ef09d242
8025638: jmap returns 0 instead of 1 when it fails.
Summary: Re-factored some code handling return values and fails/errors during
tool exec
Hi,
On Wed, 2013-10-16 at 10:48 +0200, Staffan Larsen wrote:
> Looks good!
>
Thanks Staffan and Mikael for the reviews!
Thomas
Thanks a lot for comments! Will check and change.
// Katja
On 10/16/2013 10:50 AM, Jaroslav Bachorik wrote:
On 15.10.2013 15:35, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
The purpose of this fix is to get rid of intermittent failures in
sun/tools/jstatd tests
On 15.10.2013 15:35, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
The purpose of this fix is to get rid of intermittent failures in
sun/tools/jstatd tests and make the tests more stable, legible and
maintainable.
Thanks,
Katja
Webrev:
http://cr.openjdk.java.net/~
Looks good!
Thanks,
/Staffan
On 15 okt 2013, at 12:53, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for the following change? It updates the SA agent
> that got out of date after the changes for JDK-7163191 where the
> HeapRegionSeq class has been refactored.
>
> The changes mirror
On 16.10.2013 10:06, Yekaterina Kantserova wrote:
Hi David,
Thank you for your comments!
You have right, it's worth to check testlibrary changes twice. For
example Erik Helin has pointed out to me there already is Asserts.java
in hotspot/testlibrary. I don't mind to merge hotspot testlibrary in
Hi David,
Thank you for your comments!
You have right, it's worth to check testlibrary changes twice. For
example Erik Helin has pointed out to me there already is Asserts.java
in hotspot/testlibrary. I don't mind to merge hotspot testlibrary into jdk.
Thanks,
Katja
On 10/16/2013 06:06 AM
Changeset: 6cb4f20d971f
Author:jlaskey
Date: 2013-10-11 14:54 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6cb4f20d971f
8026309: latest runsunspider.js tests contains several bugs
Reviewed-by: sundar, lagergren
Contributed-by: james.las...@oracle.com
! test/script/basi
38 matches
Mail list logo
