hg: jdk8/tl/langtools: 8026567: Use meaningful style names for strong and italic styles.

Changeset: 130b8c0e570e Author:bpatel Date: 2013-10-18 16:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/130b8c0e570e 8026567: Use meaningful style names for strong and italic styles. Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractE

hg: jdk8/tl/langtools: 8026749: Missing LV table in lambda bodies

Changeset: 7de97abc4a5c Author:jjg Date: 2013-10-18 15:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de97abc4a5c 8026749: Missing LV table in lambda bodies Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/co

hg: jdk8/tl/jdk: 8025828: Late binding of Chronology to appendValueReduced

Changeset: 7a947daa8f51 Author:rriggs Date: 2013-10-18 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a947daa8f51 8025828: Late binding of Chronology to appendValueReduced Summary: Add a listener to the parseContext called when the Chronology changes Reviewed-by: sherm

hg: jdk8/tl/jdk: 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields

Changeset: 88436832cfd0 Author:dsamersoff Date: 2013-10-19 00:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88436832cfd0 8004213: JDP packet needs pid, broadcast interval and rmi server hostname fields Summary: Add some extra fileds to jdp packet Reviewed-by: allwin, sla,

Re: jmx-dev RFR 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues

On 10/16/2013 7:18 AM, Jaroslav Bachorik wrote: Please, review this simple test change. The test tries to get the number of times a certain thread was blocked during the test run and intermittently fails with the difference of 1 - the expected number is 4 but the reported number is 3. When u

Re: RFR: 8026789 Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection

> webrev: http://cr.openjdk.java.net/~sla/8026789/webrev.00/ test/ProblemList.txt Interesting. The tests are on the list via 8023201, but you're tweaking the tests via 8026789. I'm guessing you don't want to say (yet) that this fix resolved the 'leak' in 8023201. test/java/lang/instr

hg: jdk8/tl/jdk: 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds

Changeset: 8d1d5a5aeb41 Author:robm Date: 2013-10-18 16:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d1d5a5aeb41 8024660: TEST_BUG: java/lang/ProcessBuilder/*IOHandle.java leaving hotspot.log open in fastdebug builds Reviewed-by: alanb Contributed-by: pavel.pune...@ora

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 602aa6fa46c6 Author:alanb Date: 2013-10-18 15:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/602aa6fa46c6 8026876: (fs) Build issue with src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java Reviewed-by: psandoz ! src/solaris/classes/sun/nio/

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: d2db09f281ca Author:dsamersoff Date: 2013-10-17 16:45 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d2db09f281ca 8005810: Update Hotspot Serviceability Agent for Method Parameter Reflection and Generic Type Signature Data Summary: Hotspot was updated t

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: b01a10c7c7c2 Author:attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashor

Re: jmx-dev Codereview request: 8026028 [findbugs] findbugs report some issue in com.sun.jmx.snmp package

Thanks Paul and Daniel for the review. Shanliang Daniel Fuchs wrote: Hi Shanliang, Looks good! -- daniel On 10/16/13 3:58 PM, shanliang wrote: Hi, Please review the following fix, main issue here is that we should clone an internal variable before returning. webrev: http://cr.openjdk.jav

hg: jdk8/tl/jdk: 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package

Changeset: 4161f17dfe2b Author:sjiang Date: 2013-10-18 16:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4161f17dfe2b 8026028: [findbugs] findbugs report some issue in com.sun.jmx.snmp package Reviewed-by: psandoz, dfuchs ! src/share/classes/com/sun/jmx/snmp/SnmpString.ja

hg: jdk8/tl/jdk: 3 new changesets

Changeset: da695008417f Author:alanb Date: 2013-10-18 13:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da695008417f 8026859: (fs) test/java/nio/file/Files/StreamTest.java fails to compile intermittently Reviewed-by: psandoz ! test/java/nio/file/Files/StreamTest.java Ch

RFR (XXS) 8026808: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failed with unexpected exit value

Hi Please help me with this tiny review: Webrev: http://cr.openjdk.java.net/~farvidsson/8026808/webrev.00/index.html Bug: https://bugs.openjdk.java.net/browse/JDK-8026808 About this bug: This bug was revealed by another

Re: RFR: 8026789 Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection

Not all platforms support the 'detail' level of Native Memory Tracking. That level isn't strictly necessary for the test in my fix below, but provides more data when an error happens. I have change the test to only use 'detail' when it is supported by the JVM, otherwise I fall back to 'summary'.

Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

+1 Thanks, /peter On Oct 18, 2013, at 12:56 PM, Staffan Larsen wrote: > Looks good! > > Thanks, > /Staffan > > On 16 okt 2013, at 14:04, Mikael Auno wrote: > >> This bug got a bit lost from my radar after vacation, but I've picked it >> again now. I've moved Arrays.asList() as suggested. In

Re: RFR 7197919: java/lang/management/ThreadMXBean/ThreadBlockedCount.java has concurency issues

Looks good! Nit: for(int i=0;i<100;i++) should have more spaces: for (int i = 0; i < 100; i++) Thanks, /Staffan On 16 okt 2013, at 16:18, Jaroslav Bachorik wrote: > Please, review this simple test change. > > The test tries to get the number of times a certain thread was blocked during >

hg: jdk8/tl/jdk: 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

Changeset: 8479a48d9fd4 Author:sla Date: 2013-10-18 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8479a48d9fd4 8021897: EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals() Reviewed-by: alanb, sspitsyn ! src/share/back/outStream.c + test/com/sun/jdi/GetUnini

Re: [PING] jmx-dev RFR: 8024613 javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

Looks good! Thanks, /Staffan On 16 okt 2013, at 16:44, Jaroslav Bachorik wrote: > On 2.10.2013 12:55, Jaroslav Bachorik wrote: >> On 20.9.2013 14:54, shanliang wrote: >>> Jaroslav, >>> >>> It is a good idea to use the RMI Testlibrary. >>> >>> Better to call: >>>agent.close(); >>> >>

Re: jmx-dev RFR 6523160: RuntimeMXBean.getUptime() returns negative values

Looks good to me. Thanks, /Staffan On 17 okt 2013, at 14:09, Jaroslav Bachorik wrote: > On 17.10.2013 13:07, David Holmes wrote: >> On 17/10/2013 8:10 PM, Jaroslav Bachorik wrote: >>> Hi David, >>> >>> On 17.10.2013 04:26, David Holmes wrote: Hi Jaroslav, Minor nit: os::elapse

Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads

Looks good! Thanks, /Staffan On 16 okt 2013, at 14:04, Mikael Auno wrote: > This bug got a bit lost from my radar after vacation, but I've picked it > again now. I've moved Arrays.asList() as suggested. In further testing of the > fix though, I found that the include list is not enough, as one

Re: RFR: 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops

Hi David and Serguei, thanks for having a look at this change! On 2013-10-18, David Holmes wrote: > On 18/10/2013 5:58 PM, serguei.spit...@oracle.com wrote: > >On 10/18/13 12:24 AM, serguei.spit...@oracle.com wrote: > >>On 10/17/13 11:03 PM, David Holmes wrote: > >>>On 18/10/2013 3:49 PM, serguei

Re: RFR (S): JDK-8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes

Hi Fredrik, I like this approach in general but am still looking into some details. There is also one concern from Coleen about the anonymous classes: they appear in the CLDG/CLD partially initialized. For details, look at the function SystemDictionary::parse_stream() that is called from the Un

Re: 8008662: Add @jdk.Exported to JDK-specific/exported APIs

On 17/10/2013 20:25, Andrew wrote: : Is the intention for these 'exported' APIs to be eventually replaced by proper parts of the specification (i.e. java.* or javax.*). I'm not keen on the idea of encouraging the use of APIs that are only in this implementation of the JDK. Just to add to Mandy'

Re: RFR: 8021897 EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

Alan, Serguei: Thanks for the reviews! I updated the fix with Serguei's comment and will push this version: http://cr.openjdk.java.net/~sla/8021897/webrev.01/ /Staffan On 18 okt 2013, at 11:23, serguei.spit...@oracle.com wrote: > Staffan, > > It looks good. > A minor suggestion is to initiali

Re: RFR: 8021897 EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

On 18/10/2013 09:37, Staffan Larsen wrote: This is a continuation of a review from the hotspot repo: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-October/009657.html The hotspot fix has now reached JDK8-TL so I can now push the test and JDK fix. The problem has to do with st

Re: RFR: 8021897 EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

Staffan, It looks good. A minor suggestion is to initialize length here: jint length = string != NULL ? (int)strlen(string) : 0; Thanks, Serguei On 10/18/13 1:37 AM, Staffan Larsen wrote: This is a continuation of a review from the hotspot repo: http://mail.openjdk.java.net/piper

RFR: 8021897 EXCEPTION_ACCESS_VIOLATION on debugging String.contentEquals()

This is a continuation of a review from the hotspot repo: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-October/009657.html The hotspot fix has now reached JDK8-TL so I can now push the test and JDK fix. The problem has to do with stepping into the String constructor and asking

Re: RFR: 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops

On 2013-10-16 18:09, Erik Helin wrote: Hi all, this patch fixes an issue where an oop in JvmtiBreakpoint, JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector. Instead of registering the oop as an unhandled oop, which would have worked, I decided to wrap the oop in a handle a

Re: RFR: 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops

On 18/10/2013 5:58 PM, serguei.spit...@oracle.com wrote: On 10/18/13 12:24 AM, serguei.spit...@oracle.com wrote: On 10/17/13 11:03 PM, David Holmes wrote: On 18/10/2013 3:49 PM, serguei.spit...@oracle.com wrote: Hi Erik, The fix looks good in general. But one thing is confusing in the fix. W

Re: RFR: 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops

On 10/18/13 12:24 AM, serguei.spit...@oracle.com wrote: On 10/17/13 11:03 PM, David Holmes wrote: On 18/10/2013 3:49 PM, serguei.spit...@oracle.com wrote: Hi Erik, The fix looks good in general. But one thing is confusing in the fix. Why do you keep both _class_loader and _class_loader_handle

Re: RFR: 8025834: NPE in Parallel Scavenge with -XX:+CheckUnhandledOops

On 10/17/13 11:03 PM, David Holmes wrote: On 18/10/2013 3:49 PM, serguei.spit...@oracle.com wrote: Hi Erik, The fix looks good in general. But one thing is confusing in the fix. Why do you keep both _class_loader and _class_loader_handle in the JvmtiBreakpoint class? Even more confusing to m