Changeset: 85fd2ae0a845
Author:mchung
Date: 2013-11-05 17:33 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85fd2ae0a845
8022208: Intermittent test failures in java/lang/Thread/ThreadStateTest.java
6944188: ThreadMXBean/ThreadStateTest.java fails intermittently
Reviewed-by: d
On 11/5/2013 5:07 PM, David Holmes wrote:
Thanks Mandy.
One minor nit:
Having goSleep be an instance method on ThreadStateController makes
the usage look weird:
thread.goSleep(10); // actually makes current thread go sleep
Good catch. I changed it to a static pause(long ms) method. Ch
Thanks Mandy.
One minor nit:
Having goSleep be an instance method on ThreadStateController makes the
usage look weird:
thread.goSleep(10); // actually makes current thread go sleep
I suggest making it static and use static import to shorten the call site :)
If you do change that, no need
Hi Erik,
From what I can see this test will no longer try to check that the
number of sleepers started and terminated are valid - it will either
pass or hang (because the latches do not release) - relying on the test
harness to time it out (ditto for the removal of the timeout from the
ss.joi
On 11/4/2013 8:42 PM, David Holmes wrote:
This looks good to me. One nit that caused me some confusion - it took
me a while to realize that in transitionTo eg:
221 public void transitionTo(Thread.State tstate) throws
InterruptedException {
222 switch (tstate) {
223
Changeset: a8a044db575c
Author:joehw
Date: 2013-11-05 11:18 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8a044db575c
8027860: [TEST_BUG] File not closed in
javax/xml/jaxp/parsers/8022548/XOMParserTest.java
Reviewed-by: alanb
! test/javax/xml/jaxp/parsers/8022548/XOMParse
Looks good!
Thanks,
/Staffan
On 5 nov 2013, at 11:25, Erik Gahlin wrote:
> Could I please have a review of this intermittently failing test.
>
> Removed Thread.sleep and instead used two count down latches. Also did some
> cleaning up; removed an unused import, added generics etc.
>
> Thanks
Looks good!
Thanks,
/Staffan
On 5 nov 2013, at 10:28, Erik Gahlin wrote:
> Could I please have a review, fix is to run test in separate vm.
>
> I also removed warnings and allowed the exception to propagate.
>
> Thanks
> Erik
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/6959636_1/
>
>
Looks fine (not-a reviewer)
-JB-
On 5.11.2013 16:28, Erik Gahlin wrote:
Could I please have a review, fix is to run test in separate vm.
I also removed warnings and allowed the exception to propagate.
Thanks
Erik
Webrev:
http://cr.openjdk.java.net/~egahlin/6959636_1/
Bug:
https://bugs.openj
Could I please have a review of this intermittently failing test.
Removed Thread.sleep and instead used two count down latches. Also did
some cleaning up; removed an unused import, added generics etc.
Thanks
Erik
Webrev:
http://cr.openjdk.java.net/~egahlin/6543856_1/
Bug:
https://bugs.openjd
Could I have a review of this intermittently failing test.
Instead of doing Thread.sleep(2000) and assume principal is visible/set
the test now spins until principal is available. I also cleaned up code
to avoid warnings.
Thanks
Erik
Webrev:
http://cr.openjdk.java.net/~egahlin/8027209_3/
Bu
Could I please have a review, fix is to run test in separate vm.
I also removed warnings and allowed the exception to propagate.
Thanks
Erik
Webrev:
http://cr.openjdk.java.net/~egahlin/6959636_1/
Bug:
https://bugs.openjdk.java.net/browse/JDK-6959636
Changeset: d5b3f83ffc40
Author:psandoz
Date: 2013-11-05 12:08 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5b3f83ffc40
8027712: DistinctOpTest fails for unordered test
Reviewed-by: henryjen, alanb
!
test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOp
On 05/11/2013 03:20, Mandy Chung wrote:
David,
Rereading your comment and I think you misread the switch statement (see
my comments below). In any case, I revisited ThreadStateController.java
and looked int the potential races and have done further cleanup. Here
is the updated webrev.
http://cr.
Hi John,
Speaking of names, the following test:
package pkg;
public class Test {
public static void main(String[] args)
{
Runnable r = () -> {};
Class c = r.getClass();
Class ac = java.lang.reflect.Array.newInstance(c, 0).getClass();
System.out.println("c
Ineexof(char) sounds like as fast and simpler?
Sent from my iPhone
On Nov 5, 2013, at 8:55 AM, Peter Levart wrote:
> On 11/04/2013 07:12 PM, robert.fi...@oracle.com wrote:
>> Changeset: 51b002381b35
>> Author:rfield
>> Date: 2013-11-04 10:12 -0800
>> URL: http://hg.openjdk.java.n
Changeset: bda654c6d59c
Author:kshefov
Date: 2013-11-05 13:09 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bda654c6d59c
8027708: NASHORN TEST: Create Nashorn test that draws image step-by-step using
JavaFX canvas.
Reviewed-by: jlaskey, lagergren
! make/build.xml
! mak
On 11/04/2013 07:12 PM, robert.fi...@oracle.com wrote:
Changeset: 51b002381b35
Author:rfield
Date: 2013-11-04 10:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/51b002381b35
7194897: JSR 292: Cannot create more than 16 instances of an anonymous class
8027681: Lambda seria
Hi Robert,
I think this fix is not complete. When one sets the system property
sun.reflect.noInflation=true, reflection proxy is still attempted to be
generated for anonymous classes (see
ReflectionFactory.newMethodAccessor/newConstructorAccessor).
I would also restructure the Method/Constru
19 matches
Mail list logo
