hg: jdk8/tl/jdk: 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c

2013-11-07 Thread jaroslav . bachorik
Changeset: b5748857ef42 Author:jbachorik Date: 2013-11-08 08:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5748857ef42 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c Reviewed-by: dholmes ! src/share/demo/jvmt

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Jaroslav Bachorik
On 8.11.2013 01:55, David Holmes wrote: On 8/11/2013 12:01 AM, Jaroslav Bachorik wrote: Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 The failure was caused by the IOHandler not waiting for

hg: jdk8/tl/jdk: 8027695: There should be a space before % sign in Swedish locale

2013-11-07 Thread yong . huang
Changeset: e10a182c973a Author:yhuang Date: 2013-11-07 22:30 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e10a182c973a 8027695: There should be a space before % sign in Swedish locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/sv/FormatData_sv_SE.java ! test

hg: jdk8/tl/corba: 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45

2013-11-07 Thread mandy . chung
Changeset: b99535e22efe Author:mchung Date: 2013-11-07 20:48 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b99535e22efe 8027943: serial version of com.sun.corba.se.spi.orbutil.proxy.CompositeInvocationHandlerImpl changed in 7u45 Reviewed-by: msheppar, alanb, lancea ! s

hg: jdk8/tl/langtools: 8027730: Fix release-8 type visitors to support intersection types

2013-11-07 Thread joe . darcy
Changeset: e39bd9401ea5 Author:darcy Date: 2013-11-07 20:11 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e39bd9401ea5 8027730: Fix release-8 type visitors to support intersection types Reviewed-by: jjg, jlahoda, sogoel ! src/share/classes/javax/lang/model/util/Simple

hg: jdk8/tl/jdk: 8024458: DataInput.readDouble refers to "readlong" instead of "readLong"

2013-11-07 Thread roger . riggs
Changeset: 04f071a95c29 Author:rriggs Date: 2013-11-07 20:56 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04f071a95c29 8024458: DataInput.readDouble refers to "readlong" instead of "readLong" Summary: fix the typo Reviewed-by: lancea, chegar, dxu ! src/share/classes/java/i

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread David Holmes
On 8/11/2013 12:01 AM, Jaroslav Bachorik wrote: Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 The failure was caused by the IOHandler not waiting for the actual message stating the the debug

Re: RFR 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c

2013-11-07 Thread David Holmes
Seems reasonable to me. David On 8/11/2013 12:40 AM, Jaroslav Bachorik wrote: Please, review this simple fix in the demo code. Issue : https://bugs.openjdk.java.net/browse/JDK-8007984 Webrev: http://cr.openjdk.java.net/~jbachorik/8007984/webrev.00 In an unlikely case of providing fatal_error_

hg: hsx/hotspot-rt/langtools: 32 new changesets

2013-11-07 Thread john . coomes
Changeset: 7af634b1fc5b Author:darcy Date: 2013-10-17 19:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/7af634b1fc5b 8026838: Fix new doclint issues in javax.annotation.processing Reviewed-by: jjg ! src/share/classes/javax/annotation/processing/Processor.java

hg: hsx/hotspot-rt/nashorn: 29 new changesets

2013-11-07 Thread john . coomes
Changeset: b01a10c7c7c2 Author:attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk

Review request for 8025985: com.sun.management.OSMBeanFactory should not be public

2013-11-07 Thread Mandy Chung
com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false). This is simply refactoring of the existi

hg: hsx/hotspot-rt/jaxp: 6 new changesets

2013-11-07 Thread john . coomes
Changeset: 390e94b9a852 Author:joehw Date: 2013-10-24 13:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/390e94b9a852 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b115 for changeset e126d8eca69b

2013-11-07 Thread john . coomes
Changeset: 587560c222a2 Author:cl Date: 2013-11-07 08:16 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/587560c222a2 Added tag jdk8-b115 for changeset e126d8eca69b ! .hgtags

hg: hsx/hotspot-rt: 30 new changesets

2013-11-07 Thread john . coomes
Changeset: 3dc55f0c1b6f Author:jlaskey Date: 2013-01-28 16:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/3dc55f0c1b6f 8006676: Integrate Nashorn into new build system Reviewed-by: jlaskey Contributed-by: james.las...@oracle.com ! common/autoconf/generated-configure.sh

hg: hsx/hotspot-rt/corba: 5 new changesets

2013-11-07 Thread john . coomes
Changeset: 52ad44f9a3ec Author:alanb Date: 2013-10-22 11:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/52ad44f9a3ec 8021257: com.sun.corba.se.** should be on restricted package list Reviewed-by: chegar, coffeys, smarks Contributed-by: alan.bate...@oralce.com, mar

hg: jdk8/tl/jdk: 8027930: ResourceBundle test failures in fr locale

2013-11-07 Thread naoto . sato
Changeset: fb7abd509bd2 Author:naoto Date: 2013-11-07 10:03 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fb7abd509bd2 8027930: ResourceBundle test failures in fr locale Reviewed-by: smarks ! test/java/util/ResourceBundle/ResourceBundleTest.java ! test/java/util/ResourceBun

Fwd: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary

2013-11-07 Thread Yekaterina Kantserova
Adding hotspot-dev group. Original Message Subject: RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary Date: Thu, 07 Nov 2013 15:09:44 +0100 From: Yekaterina Kantserova To: Serviceability Dev Hi, Could I please have a revi

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Yekaterina Kantserova
Staffan, thanks for reviewing! On 11/07/2013 04:40 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 07 Nov 2013, at 15:13, Yekaterina Kantserova wrote: Hi, On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: Hi, the patch only detects an incorrect setup, right? That's correct. T

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Jaroslav Bachorik
On 7.11.2013 15:34, Yekaterina Kantserova wrote: On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote: On 7.11.2013 15:24, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/t

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 07 Nov 2013, at 15:13, Yekaterina Kantserova wrote: > Hi, > > On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: >> Hi, >> >> the patch only detects an incorrect setup, right? > > That's correct. The plan is to run test with this fix and see if we keep > gett

Re: RFR for JDK-7195249 Some jtreg tests use hard coded ports

2013-11-07 Thread Yekaterina Kantserova
Hi Taras, see my comments in-lined. On 11/06/2013 03:04 PM, taras ledkov wrote: Hi Everyone I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. Based on my colleagues' research, Root cause: hotspot/test/runtime/6294277/SourceDebugExtension.java jdk/test/sun/management/jmxrem

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Yekaterina Kantserova
Thanks! On 11/07/2013 03:45 PM, Jaroslav Bachorik wrote: On 7.11.2013 15:13, Yekaterina Kantserova wrote: Hi, On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: Hi, the patch only detects an incorrect setup, right? That's correct. The plan is to run test with this fix and see if we keep gett

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Yekaterina Kantserova
Hi, On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: Hi, the patch only detects an incorrect setup, right? That's correct. The plan is to run test with this fix and see if we keep getting SecurityException or if something is wrong with the policy file. In the first case a new bug will be op

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Jaroslav Bachorik
On 7.11.2013 15:13, Yekaterina Kantserova wrote: Hi, On 11/07/2013 03:04 PM, Jaroslav Bachorik wrote: Hi, the patch only detects an incorrect setup, right? That's correct. The plan is to run test with this fix and see if we keep getting SecurityException or if something is wrong with the pol

RFR 8007984: Null pointer dereference in jdk/linux-amd64/democlasses/demo/jvmti/heapTracker/src/java_crw_demo.c

2013-11-07 Thread Jaroslav Bachorik
Please, review this simple fix in the demo code. Issue : https://bugs.openjdk.java.net/browse/JDK-8007984 Webrev: http://cr.openjdk.java.net/~jbachorik/8007984/webrev.00 In an unlikely case of providing fatal_error_handler that does not terminate the application when a fatal error is reported.

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Yekaterina Kantserova
On 11/07/2013 03:29 PM, Jaroslav Bachorik wrote: On 7.11.2013 15:24, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Jaroslav Bachorik
On 7.11.2013 15:24, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The example how to use can be found in sun/management

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Yekaterina Kantserova
Sorry, ProcessBuilder's createJavaProcessBuilder() of course, which in turn uses JDKToolLauncher. // Katja On 11/07/2013 03:24 PM, Yekaterina Kantserova wrote: Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixe

Re: RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Yekaterina Kantserova
Hi, would you like to use JDKToolLauncher instead of JdkFinder? The JdkFinder will be removed soon (RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary). The example how to use can be found in sun/management/jmxremote/bootstrap/LocalManagementTest.java.

hg: jdk8/tl/nashorn: 2 new changesets

2013-11-07 Thread sundararajan . athijegannathan
Changeset: 2f07b4234451 Author:sundar Date: 2013-11-07 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f07b4234451 8027828: ClassCastException when converting return value of a Java method to boolean Reviewed-by: jlaskey, attila ! src/jdk/nashorn/api/scripting/Scr

RFR (S): 8015497: Take new fixes from hotspot/test/testlibrary to jdk/test/lib/testlibrary

2013-11-07 Thread Yekaterina Kantserova
Hi, Could I please have a review of this fix. The following has been done: - updated OutputAnalyzer and ProcessTool with changes from hotspot/testlibrary; - added test classes AssertsTest and OutputAnalyzerReportingTest from hotspot/testlibrary; - added InputArguments class from hotspot/testli

Re: RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Jaroslav Bachorik
Hi, the patch only detects an incorrect setup, right? -JB- On 7.11.2013 14:02, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8027752 Webrev: cr.openjdk.java.net/~ykantser/8027752/webrev.00 Thanks, Katja

RFR: 8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently

2013-11-07 Thread Jaroslav Bachorik
Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8004126 Webrev: http://cr.openjdk.java.net/~jbachorik/8004126/webrev.00 The failure was caused by the IOHandler not waiting for the actual message stating the the debugee was ready. The patch uses the library functi

RFR (XSS): 8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java: java.lang.SecurityException: attempt to add a Permission to a readonly Permissions object

2013-11-07 Thread Yekaterina Kantserova
Hi, Could I please have a review of this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8027752 Webrev: cr.openjdk.java.net/~ykantser/8027752/webrev.00 Thanks, Katja

hg: jdk8/tl/jdk: 8027796: Refactor Core Reflection for Type Annotations

2013-11-07 Thread joel . franck
Changeset: 44fa6bf42846 Author:jfranck Date: 2013-11-07 13:33 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44fa6bf42846 8027796: Refactor Core Reflection for Type Annotations Reviewed-by: psandoz ! src/share/classes/sun/reflect/annotation/AnnotatedTypeFactory.java ! src/sh

Re: [8] Review Request: 8027696 Incorrect copyright header in the tests

2013-11-07 Thread Alan Bateman
On 05/11/2013 16:28, Sergey Bylokhov wrote: Hello, Updated version: http://cr.openjdk.java.net/~serb/8027696/webrev.01/ Dates and spaces were fixed. Thanks Sergey, I sampled a few and they look correct. The only thing is that I'm not sure about is test/Makefile, it's just not clear whether whi

hg: jdk8/tl/jdk: 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient

2013-11-07 Thread michael . x . mcmahon
Changeset: 88d1ed05a246 Author:michaelm Date: 2013-11-07 10:22 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88d1ed05a246 8027881: test/java/net/URLPermission/nstest/LookupTest.java failing intermittently, output insufficient Reviewed-by: chegar ! test/java/net/URLPermissi

hg: jdk8/tl/jdk: 8027961: Inet[4|6]Address native initializing code should check field/MethodID values

2013-11-07 Thread chris . hegarty
Changeset: 82b276590b85 Author:chegar Date: 2013-11-07 08:23 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82b276590b85 8027961: Inet[4|6]Address native initializing code should check field/MethodID values Reviewed-by: michaelm, rriggs ! src/share/native/java/net/Inet4Addr

hg: jdk8/tl/jdk: 8027822: ProblemList.txt Updates (11/2013)

2013-11-07 Thread chris . hegarty
Changeset: f37d62e295c0 Author:chegar Date: 2013-11-07 08:04 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f37d62e295c0 8027822: ProblemList.txt Updates (11/2013) Reviewed-by: chegar, alanb Contributed-by: Amy Lu ! test/ProblemList.txt