hg: jdk8/tl/jdk: 8027823: catchException combinator fails with 9 argument target

Changeset: 9fcb07df1c92 Author:vlivanov Date: 2013-11-09 04:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fcb07df1c92 8027823: catchException combinator fails with 9 argument target Reviewed-by: jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java + test/jav

Re: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument

On 11/11/2013 9:11 AM, bill pittore wrote: Modified change based on feedback. New webrev at http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ Thanks for the update. Looks fine to me. Mandy thanks, bill On 11/10/2013 1:57 PM, Bill Pittore wrote: I think that's a good idea since we n

Re: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument

On 12/11/2013 3:11 AM, bill pittore wrote: Modified change based on feedback. New webrev at http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ Looks good to me. Thanks, David thanks, bill On 11/10/2013 1:57 PM, Bill Pittore wrote: I think that's a good idea since we now have the disti

hg: jdk8/tl/jdk: 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails

Changeset: c04e46dbfea8 Author:rfield Date: 2013-11-11 16:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c04e46dbfea8 8027803: test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java fails Summary: fix NPE in test infrastructure Reviewed-by: ksrini, jfranck, al

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

The fix looks good. Thanks, Serguei On 11/11/13 11:49 AM, Staffan Larsen wrote: The contract for the tools should be (similarly from other tools, eg javac): If the arguments are wrong or not specified: exit code != 0, usage output on stderr If -help or -h is specified: exit code == 0, usag

hg: jdk8/tl/jdk: 8026330: java.util.Base64 urlEncoder should omit padding

Changeset: 8e8e423fa3dc Author:sherman Date: 2013-11-11 14:35 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8e423fa3dc 8026330: java.util.Base64 urlEncoder should omit padding Summary: to add Encoder.withoutPadding() Reviewed-by: alanb ! src/share/classes/java/util/Base64

hg: jdk8/tl/jdk: 8014506: Test of Jdp feature

Changeset: 0cacac7f5c37 Author:sla Date: 2013-11-08 18:16 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cacac7f5c37 8014506: Test of Jdp feature Reviewed-by: sla Contributed-by: Alex Schenkman + test/sun/management/jdp/ClientConnection.java + test/sun/management/jdp/Dynam

RE: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Looks good Staffan! Thanks for fixing up this (mess). Thanks Markus From: Staffan Larsen Sent: den 11 november 2013 20:49 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstac

Re: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

Looks good. Thanks, Serguei On 11/11/13 12:25 PM, Staffan Larsen wrote: Ah, good catch. Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ Thanks, /Staffan On 11 Nov 2013, at 21:06, serguei.spit...@oracle.co

Re: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

Ah, good catch. Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/ Thanks, /Staffan On 11 Nov 2013, at 21:06, serguei.spit...@oracle.com wrote: > It looks good. > > The only one nit is about the line: > 160 System.out.println("Command line: "+Arguments.getJV

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

Thanks Dmitry! On 11 Nov 2013, at 20:43, Dmitry Samersoff wrote: > Looks good for me. > > -Dmitry > > On 2013-11-11 22:43, Staffan Larsen wrote: >> (and now with the correct email aliases) >> >> On 11 Nov 2013, at 19:42, Staffan Larsen wrote: >> >>> Please review this small fix to output SA

Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature

Thanks for the explanation. Reviewed! I will sponsor the push. And thanks for hanging in there during the review process. /Staffan On 11 Nov 2013, at 14:57, Mikael Auno wrote: > The reduction in testsuites in JdpTest.sh is due to those "testsuites" > removed being ported to Java with this ch

Re: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

It looks good. The only one nit is about the line: 160 System.out.println("Command line: "+Arguments.getJVMArgs() + Arguments.getJVMFlags()); If one or both ofArguments.getJVMArgs() and Arguments.getJVMFlags() return null (not sure if it is the case) then the output will have "null

RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

The contract for the tools should be (similarly from other tools, eg javac): If the arguments are wrong or not specified: exit code != 0, usage output on stderr If -help or -h is specified: exit code == 0, usage output on stderr webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.00/ bug: htt

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

Looks good for me. -Dmitry On 2013-11-11 22:43, Staffan Larsen wrote: > (and now with the correct email aliases) > > On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > >> Please review this small fix to output SA message to stdout instead of >> stderr. >> >> webrev: http://cr.openjdk.java.net/

RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

The problem here is that ‘jinfo -flags’ only looks at the command line, but if a user has changed a flag after the VM started (for example by using ‘jinfo -flag’) that new value does not show up. I am changing the output so that ‘jinfo -flags’ now prints something like this: Non-default VM flag

hg: jdk8/tl/jdk: 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal

Changeset: 59ff7957c26f Author:lancea Date: 2013-11-11 14:22 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59ff7957c26f 8028149: Clean-up javac -Xlint warnings in com.sun.rowset and com.sun.rowset.internal Reviewed-by: darcy ! src/share/classes/com/sun/rowset/CachedRowSetI

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

Thanks Serguei! On 11 Nov 2013, at 19:55, serguei.spit...@oracle.com wrote: > Looks good. > > Thanks, > Serguei > > On 11/11/13 10:43 AM, Staffan Larsen wrote: >> (and now with the correct email aliases) >> >> On 11 Nov 2013, at 19:42, Staffan Larsen wrote: >> >>> Please review this small fi

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

Looks good. Thanks, Serguei On 11/11/13 10:43 AM, Staffan Larsen wrote: (and now with the correct email aliases) On 11 Nov 2013, at 19:42, Staffan Larsen wrote: Please review this small fix to output SA message to stdout instead of stderr. webrev: http://cr.openjdk.java.net/~sla/6626412/we

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

(and now with the correct email aliases) On 11 Nov 2013, at 19:42, Staffan Larsen wrote: > Please review this small fix to output SA message to stdout instead of stderr. > > webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ > bug: https://bugs.openjdk.java.net/browse/JDK-6626412 > > T

RFR(S): 6626412 jstack using SA prints some info messages into err stream

Please review this small fix to output SA message to stdout instead of stderr. webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-6626412 Thanks, /Staffan

hg: jdk8/tl/jdk: 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win)

Changeset: 0e47462f03a0 Author:michaelm Date: 2013-11-11 16:06 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e47462f03a0 8028060: test/java/net/URLPermission/nstest/lookup.sh failing (win) Reviewed-by: alanb ! test/java/net/URLPermission/nstest/LookupTest.java ! test/java/

Re: RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument

Modified change based on feedback. New webrev at http://cr.openjdk.java.net/~bpittore/8027914/webrev.01/ thanks, bill On 11/10/2013 1:57 PM, Bill Pittore wrote: I think that's a good idea since we now have the distinct possibility of the class not being available in certain profiles. I'll re-d

hg: jdk8/tl/langtools: 8027375: javac asserts on nested erroneous annotations

Changeset: f3ca12d680f3 Author:jfranck Date: 2013-11-11 17:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f3ca12d680f3 8027375: javac asserts on nested erroneous annotations Summary: make sure JCAnnotation trees have type != null before annotation processing Reviewe

hg: jdk8/tl/langtools: 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass(); ...

Changeset: 4788eb38cac5 Author:emc Date: 2013-11-11 09:47 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4788eb38cac5 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass() 8027253: javac illegally accepts array as bound Summar

Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature

The reduction in testsuites in JdpTest.sh is due to those "testsuites" removed being ported to Java with this change. The last "testsuite" in JdpTest.sh however, has not been ported yet, therefore JdpTest.sh can't be removed completely. Mikael On 2013-11-11 14:19, Staffan Larsen wrote: Why a

Re: Removal of sample code from tools.jar

I put a comment in the bug report. In essence this package contains the code for the ‘jdb’ command line debugger which is shipped as a supported tool in the JDK. I don’t think we can simply remove it. /Staffan On 08 Nov 2013, at 14:39, Andreas Lundblad wrote: > Regarding bug JDK-8008602: Samp

Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature

Why are there changes to the existing tests? Most look like whitespace changes, but JdpTest.sh changes the “testsuites” that are being run. /Staffan On 08 Nov 2013, at 18:45, Mikael Auno wrote: > There was some unintended whitespace changes in webrev.05 that Alex had > missed. I removed them

hg: jdk8/tl/jdk: 8028102: All test targets, jdk/test/Makefile, fail on Windows

Changeset: b48eded97dff Author:chegar Date: 2013-11-11 10:33 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b48eded97dff 8028102: All test targets, jdk/test/Makefile, fail on Windows Reviewed-by: mduigou ! test/Makefile

Re: RFR: 4660158: TTY: NumberFormatException while trying to set values by 'set' command

Thanks Serguei! Can I have an official Review as well? /Staffan On 04 Nov 2013, at 21:08, serguei.spit...@oracle.com wrote: > Staffan, > > This one is really old: 11+ years. :) > The fix is good, I do not see any issues. > > Thanks, > Serguei > > > On 11/4/13 6:41 AM, Staffan Larsen wrote:

Re: RFR for JDK-7195249 Some jtreg tests use hard coded ports

Hi Everyone I am working on bug https://bugs.openjdk.java.net/browse/JDK-7195249. After a conversation with Jaroslav Bachorik, the suggested fix for sun/management/jmxremote/bootstrap/RmiBootstrapTest.java consists in replacing errStr = testConfiguration(file,port+testPort++); and errStr = te

hg: jdk8/tl/jdk: 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main

Changeset: 7304b3195212 Author:weijun Date: 2013-11-11 16:54 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7304b3195212 8027991: InputStream should be closed in sun.security.tools.jarsigner.Main Reviewed-by: xuelei ! src/share/classes/sun/security/tools/jarsigner/Main.java

hg: jdk8/tl/jdk: 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win)

Changeset: 2525b91ca5a6 Author:alanb Date: 2013-11-11 08:36 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2525b91ca5a6 8028099: Many com/sun/management/OperatingSystemMXBean tests failing with CCE (win) Reviewed-by: mchung ! src/windows/classes/sun/management/OperatingSyst