Re: Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

Hi Eric, On 11/14/2013 6:16 PM, Eric Wang wrote: Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification

Review quest for JDK-7067973: test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java hanging intermittently

Hi Everyone, I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973. It is a test bug as the test doesn't guarantee memory allocated from the Old Gen, if the used memory is zero and doesn't cross the threshold, no notification is sent, so both the main thread and Checker threa

hg: jdk8/tl/jdk: 8014266: regression test AsyncSSLSocketClose.java time out.

Changeset: 40d0ccd00f87 Author:xuelei Date: 2013-11-14 16:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0ccd00f87 8014266: regression test AsyncSSLSocketClose.java time out. Reviewed-by: xuelei Contributed-by: Rajan Halade ! test/sun/security/ssl/com/sun/net/ssl/int

hg: hsx/hotspot-rt/hotspot: 6626412: jstack using SA prints some info messages into err stream

Changeset: 5280822ddfcd Author:sla Date: 2013-11-14 20:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5280822ddfcd 6626412: jstack using SA prints some info messages into err stream Reviewed-by: coleenp, farvidsson, jbachorik, dsamersoff, sspitsyn ! agent/src/s

hg: hsx/hotspot-rt/hotspot: 6606002: jinfo doesn't detect dynamic vm flags changing

Changeset: b03f33670080 Author:sla Date: 2013-11-14 19:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b03f33670080 6606002: jinfo doesn't detect dynamic vm flags changing Reviewed-by: coleenp, jbachorik, sspitsyn ! agent/src/share/classes/sun/jvm/hotspot/tools/

hg: jdk8/tl/langtools: 8025524: javadoc does not correctly locate constructors for nested classes

Changeset: 5ae66d372d57 Author:bpatel Date: 2013-11-14 13:47 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5ae66d372d57 8025524: javadoc does not correctly locate constructors for nested classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ConstructorDoc

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 59f46f135584 Author:hseigel Date: 2013-11-14 10:44 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59f46f135584 8023041: The CDS classlist needs to be updated for JDK 8 Summary: Generate new classlists from JDK 8 classes Reviewed-by: alanb, coleenp, hseigel Contribu

hg: jdk8/tl/langtools: 8026963: type annotations code crashes for code with erroneous trees

Changeset: e79d6425f1c4 Author:vromero Date: 2013-11-14 19:28 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e79d6425f1c4 8026963: type annotations code crashes for code with erroneous trees Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/comp/Attr.ja

hg: hsx/hotspot-rt/langtools: Added tag jdk8-b116 for changeset 3c040b04af05

Changeset: 64d119680f0a Author:cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/64d119680f0a Added tag jdk8-b116 for changeset 3c040b04af05 ! .hgtags

hg: hsx/hotspot-rt: 3 new changesets

Changeset: c1029b02ca87 Author:ihse Date: 2013-11-08 09:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c1029b02ca87 8027836: Webrev should handle files that has been moved from a directory which now is removed. Reviewed-by: mduigou, tbell ! make/scripts/webrev.ksh Ch

hg: hsx/hotspot-rt/nashorn: Added tag jdk8-b116 for changeset 0fb1a427fbf6

Changeset: 774c63629870 Author:cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/nashorn/rev/774c63629870 Added tag jdk8-b116 for changeset 0fb1a427fbf6 ! .hgtags

hg: hsx/hotspot-rt/jdk: 5 new changesets

Changeset: bdcba4854576 Author:erikj Date: 2013-11-07 10:51 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bdcba4854576 8027698: Platform specific jars are not being signed by the sign-jars target Reviewed-by: ihse, tbell, wetmore ! makefiles/SignJars.gmk Changeset:

hg: hsx/hotspot-rt/corba: Added tag jdk8-b116 for changeset 5fdc44652089

Changeset: 7299367c8aa4 Author:cl Date: 2013-11-14 09:04 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/7299367c8aa4 Added tag jdk8-b116 for changeset 5fdc44652089 ! .hgtags

hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b116 for changeset e757eb9aee3d

Changeset: c1d234d4f164 Author:cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/c1d234d4f164 Added tag jdk8-b116 for changeset e757eb9aee3d ! .hgtags

hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b116 for changeset 587560c222a2

Changeset: fe56ba456fd3 Author:cl Date: 2013-11-14 09:05 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/fe56ba456fd3 Added tag jdk8-b116 for changeset 587560c222a2 ! .hgtags

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

The import cleanup was done automatically by the IDE. Thanks, /Staffan On 14 Nov 2013, at 15:42, Coleen Phillimore wrote: > > Looks good. Nice cleanup for the imports. > Coleen > > On 11/14/2013 02:34 AM, Staffan Larsen wrote: >> Still looking for an official Review of this change. >> >>

hg: jdk8/tl/jdk: 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Changeset: 65f7b83ab477 Author:sla Date: 2013-11-14 19:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65f7b83ab477 8027765: Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent Reviewed-by: alanb, allwin, sspitsyn, mgronlun ! src/share/classes

Re: RFR(S): 6606002 jinfo doesn't detect dynamic vm flags changing

Good one. I’ll fix that before pushing. Thanks for the review! /Staffan On 14 Nov 2013, at 15:46, Coleen Phillimore wrote: > > You could change this line to be the nicer Java way to iterate over arrays: > > +for (int f = 0; f < flags.length; f++) { > > > Otherwise, looks good. > >

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Missed that one. I’ll fix it in the same way before pushing. /Staffan On 14 Nov 2013, at 16:53, Peter Allwin wrote: > Hi Staffan, > 84 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : > 1; > Looks like one more case of this. > > > Thanks! > /peter > > > On 14 Nov

hg: jdk8/tl/langtools: 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java

Changeset: 24eaf41a3974 Author:emc Date: 2013-11-14 12:32 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/24eaf41a3974 8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java Summary: Remove @ignore from test Reviewed-by: jjg ! test/tools/javac/T70426

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Hi Staffan, 84 int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; Looks like one more case of this. Thanks! /peter On 14 Nov 2013, at 13:19, Staffan Larsen wrote: > Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ > > On 14 Nov 2013, at 13:12, St

Re: RFR: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails

Looks good! Thanks, /Staffan On 14 Nov 2013, at 15:53, Erik Gahlin wrote: > Could I have a review of a test that fails intermittently with an OOM. > > The fix is to reduce the amount allocated objects. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-7141544 > > Webrev: > http://cr.openjd

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Thanks! On 14 Nov 2013, at 16:22, Alan Bateman wrote: > On 14/11/2013 12:19, Staffan Larsen wrote: >> >> Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ >> > A good spot by Max. The updated webrev looks okay to me in that it makes > things consistent with the java launcher.

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14/11/2013 12:19, Staffan Larsen wrote: Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ A good spot by Max. The updated webrev looks okay to me in that it makes things consistent with the java launcher. -Alan

RFR: 7141544: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails

Could I have a review of a test that fails intermittently with an OOM. The fix is to reduce the amount allocated objects. Bug: https://bugs.openjdk.java.net/browse/JDK-7141544 Webrev: http://cr.openjdk.java.net/~egahlin/7141544_1/ Erik

Re: RFR(S): 6626412 jstack using SA prints some info messages into err stream

Looks good. Nice cleanup for the imports. Coleen On 11/14/2013 02:34 AM, Staffan Larsen wrote: Still looking for an official Review of this change. Thanks, /Staffan On 11 Nov 2013, at 19:42, Staffan Larsen wrote: Please review this small fix to output SA message to stdout instead of stde

Re: RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently

I have made the changes from the review: http://cr.openjdk.java.net/~ykantser/8023138/webrev.01 Could you please be my sponsor and submit the patch? Mattias - Original Message - From: staffan.lar...@oracle.com To: mattias.tobias...@oracle.com Cc: serviceability-dev@openjdk.java.net Sent:

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 11/14/2013 12:44 PM, Staffan Larsen wrote: > Not in Java, unless you "import static java.lang.System.exit;". Lord above, I am an idiot. My excuse is that I have been deep in HotSpot all morning. Please forget I ever posted that. :-) Andrew.

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14 Nov 2013, at 13:37, Andrew Haley wrote: > On 11/14/2013 12:12 PM, Staffan Larsen wrote: >>> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; > > Please do not call a variable "exit". exit() is a standard function. Not in Java, unless you "import static java.lang.System.exit

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 11/14/2013 12:12 PM, Staffan Larsen wrote: >> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; Please do not call a variable "exit". exit() is a standard function. Andrew.

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

Updated webrev: http://cr.openjdk.java.net/~sla/8027765/webrev.01/ On 14 Nov 2013, at 13:12, Staffan Larsen wrote: > > On 14 Nov 2013, at 10:46, Weijun Wang wrote: > >> Also, I am not sure if >> >> int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; >> >> really does what it inte

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14 Nov 2013, at 10:46, Weijun Wang wrote: > Also, I am not sure if > > int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; > > really does what it intends to. Cannot remember the precedence order of all > these operators. I would add parentheses. Good point. I’ll add parenthese

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

I’ve been trying to copy whatever javac does to be consistent. From the bug report: * If the arguments are wrong or not specified: exit code != 0, usage output on stderr * If -help or -h is specified: exit code == 0, usage output on stderr /Staffan On 14 Nov 2013, at 11:08, Alan Bateman wrote

hg: jdk8/tl/jdk: 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true

Changeset: 83c768d6cb93 Author:jfranck Date: 2013-11-14 12:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83c768d6cb93 8028055: (reflect) invoking Method/Constructor in anonymous classes breaks with -Dsun.reflect.noInflation=true Reviewed-by: briangoetz ! src/share/class

hg: jdk8/tl/jdk: 8028343: More ProblemList.txt updates (11/2013)

Changeset: ecf85f4aecf0 Author:alanb Date: 2013-11-14 10:40 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ecf85f4aecf0 8028343: More ProblemList.txt updates (11/2013) Reviewed-by: chegar ! test/ProblemList.txt

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14/11/2013 10:08, Alan Bateman wrote: On the other hand, -help is supposed to print to stderr and exit with a success. I meant stdout here of course.

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14/11/2013 09:46, Weijun Wang wrote: But it's changing from stdout to stderr in the webrev. At least GNU believes [1] it should go to stdout. It make the output more'able. This is a confusing topic. I think the normal convention is that when there are invalid arguments that usage message is e

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

But it's changing from stdout to stderr in the webrev. At least GNU believes [1] it should go to stdout. It make the output more'able. Also, I am not sure if int exit = arg1.equals("-help") || arg1.equals("-h") ? 0 : 1; really does what it intends to. Cannot remember the precedence order of

Re: RFR: 8027765 Make exit codes and stdout/stderr printing from jmap/jinfo/jstack/jps consistent

On 14/11/2013 07:34, Staffan Larsen wrote: Still looking for an official Review of this change. This looks okay to me (I surprised we hadn't noticed the usage message going to stderr before). Slightly different styles for if-the-else in JStack but not too interesting. I guess we could use strin