hg: jdk8/tl/langtools: 8028504: javac generates LocalVariableTable even with -g:none

2013-11-19 Thread vicente . romero
Changeset: 66bcd5d4b3d1 Author:vromero Date: 2013-11-19 23:35 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/66bcd5d4b3d1 8028504: javac generates LocalVariableTable even with -g:none Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.jav

hg: jdk8/tl/jdk: 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails

2013-11-19 Thread stuart . marks
Changeset: 19d2e9649138 Author:smarks Date: 2013-11-19 15:05 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138 8028638: java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails Reviewed-by: lancea ! test/java/rmi/testlibrary/RMID.java

Review request for 8028647: Add instrumentation in GetSafepointSyncTime.java and remove it from ProblemList.txt

2013-11-19 Thread Mandy Chung
Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028647/webrev.00/ This patch turns the trace on by default and also add the instrumentation to print the safepoint count to help troubleshooting the test failure. test/sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java is n

hg: jdk8/tl/jdk: 8028631: Improve the test coverage to the pathname handling on unix-like platforms

2013-11-19 Thread dan . xu
Changeset: f496565c4eec Author:dxu Date: 2013-11-19 13:22 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f496565c4eec 8028631: Improve the test coverage to the pathname handling on unix-like platforms Summary: Add GeneralSolaris.java testcase and fix the concurrency issue Re

hg: jdk8/tl/jdk: 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10

2013-11-19 Thread daniel . fuchs
Changeset: 059530c5ae9a Author:dfuchs Date: 2013-11-19 22:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/059530c5ae9a 8005202: java/util/logging/CheckLockLocationTest.java fail on solars_10 Summary: this test has been seen failing on Solaris 10, presumably because it was

Re: RFR: JDK-8028430 JDI: ReferenceType.visibleMethods() return wrong visible methods

2013-11-19 Thread Staffan Larsen
On 19 nov 2013, at 20:06, Mandy Chung wrote: > On 11/15/2013 6:18 AM, Staffan Larsen wrote: >> All, >> >> ReferenceType.visibleMethods() has some problems with diamond shaped >> interface hierarchies. There is more information on the problem in the bug >> report. >> >> The solution here is t

hg: jdk8/tl/jdk: 8028185: XMLFormatter.format emits incorrect year

2013-11-19 Thread daniel . fuchs
Changeset: 67d742c75971 Author:dfuchs Date: 2013-11-19 20:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/67d742c75971 8028185: XMLFormatter.format emits incorrect year Summary: Fixes a regression where the year in the date was increased by 1900. Reviewed-by: alanb, mchung

Re: RFR: JDK-8028430 JDI: ReferenceType.visibleMethods() return wrong visible methods

2013-11-19 Thread Mandy Chung
On 11/15/2013 6:18 AM, Staffan Larsen wrote: All, ReferenceType.visibleMethods() has some problems with diamond shaped interface hierarchies. There is more information on the problem in the bug report. The solution here is to maintain a list of interfaces that we have visited so that we do no

Re: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep

2013-11-19 Thread David Holmes
On 20/11/2013 12:43 AM, Jaroslav Bachorik wrote: Hi David, On 18.11.2013 22:03, David Holmes wrote: Hi Jaroslav, I think your phaser usage is incorrect: 88 public void run() { 89 p.arriveAndAwaitAdvance(); // phase[1] 90 synchronized(lock1)

hg: jdk8/tl/langtools: 6726154: javadoc generated with incorrect version in comment

2013-11-19 Thread alexander . zuev
Changeset: f42a22e2b2cd Author:kizune Date: 2013-11-19 22:14 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f42a22e2b2cd 6726154: javadoc generated with incorrect version in comment Reviewed-by: jjg, bpatel, erikj, tbell ! make/BuildLangtools.gmk ! src/share/classes/co

hg: jdk8/tl/jdk: 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again

2013-11-19 Thread roger . riggs
Changeset: 3f47e393e1dd Author:rriggs Date: 2013-11-19 13:20 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f47e393e1dd 8028141: test/sun/management/jmxremote/bootstrap/LocalManagementTest|CustomLauncherTest.java failing again Summary: Correct to use the test.class.path in

hg: jdk8/tl/jdk: 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt

2013-11-19 Thread mandy . chung
Changeset: 48c61808374f Author:mchung Date: 2013-11-19 10:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48c61808374f 8028565: Remove java/lang/management/ThreadMXBean/ThreadStateTest.java from ProblemList.txt Reviewed-by: sla ! test/ProblemList.txt

hg: jdk8/tl/jdk: 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set

2013-11-19 Thread vincent . x . ryan
Changeset: f8b24e1a609e Author:vinnie Date: 2013-11-19 17:55 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b24e1a609e 8015571: OCSP validation fails if ocsp.responderCertSubjectName is set Reviewed-by: mullan, xuelei ! src/share/classes/sun/security/provider/certpath/OCSP

hg: jdk8/tl/jdk: 8027900: pack200 option is broken due to the incorrect makefile definition for its driver

2013-11-19 Thread alexander . zuev
Changeset: 5aa853ca08a8 Author:kizune Date: 2013-11-19 22:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aa853ca08a8 8027900: pack200 option is broken due to the incorrect makefile definition for its driver Reviewed-by: ksrini, ihse ! make/CompileLaunchers.gmk

hg: jdk8/tl/jdk: 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing

2013-11-19 Thread michael . x . mcmahon
Changeset: 79e975dfeb8a Author:michaelm Date: 2013-11-19 17:49 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79e975dfeb8a 8028581: [TESTBUG] java/net/Socket/LingerTest.java failing Reviewed-by: alanb ! test/java/net/Socket/LingerTest.java

hg: jdk8/tl/jdk: 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures

2013-11-19 Thread alan . bateman
Changeset: 36821ee241a2 Author:alanb Date: 2013-11-19 15:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36821ee241a2 8028589: Instrument tools/jar/JarEntryTime.java to make it easier to diagnose failures Reviewed-by: chegar ! test/tools/jar/JarEntryTime.java

Re: RFR 8028141 intermittent test failure of LocalManagementTest

2013-11-19 Thread roger riggs
Hi, The new utilities are useful though not directly for this fix because the code needs to append to the classpath, not just the command arguments. Minor comments on the new utilities, for future consideration. - In the getCommandLine impl; java.util.StringJoiner may be useful though not mu

hg: jdk8/tl/jdk: 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently

2013-11-19 Thread sean . coffey
Changeset: f2ccd3530476 Author:coffeys Date: 2013-11-19 16:22 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f2ccd3530476 8016728: TEST_BUG: test/java/rmi/transport/closeServerSocket/CloseServerSocket.java failing intermittently Reviewed-by: chegar ! test/java/rmi/transpor

hg: jdk8/tl/jdk: 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java

2013-11-19 Thread rob . mckenna
Changeset: 63b696dafc8a Author:robm Date: 2013-11-19 15:36 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/63b696dafc8a 8022206: Intermittent test failures in java/lang/ProcessBuilder/Basic.java Reviewed-by: chegar, alanb ! test/java/lang/ProcessBuilder/Basic.java

hg: jdk8/tl/jdk: 2 new changesets

2013-11-19 Thread vincent . x . ryan
Changeset: e8daf5a83e42 Author:vinnie Date: 2013-11-19 15:39 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8daf5a83e42 8028377: test/sun/security/provider/KeyStore/DKSTest.sh attempts to write to ${test.src} Reviewed-by: alanb, weijun ! test/sun/security/provider/KeyStore

hg: jdk8/tl/jdk: 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep 6666" processes behind

2013-11-19 Thread chris . hegarty
Changeset: cfbee8ee71bf Author:bvaidya Date: 2013-11-19 15:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cfbee8ee71bf 8028094: TEST_BUG: java/lang/ProcessBuilder/Basic.java leaves "sleep " processes behind Reviewed-by: chegar ! test/java/lang/ProcessBuilder/Basic.ja

hg: hsx/hotspot-rt/hotspot: 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL

2013-11-19 Thread kevin . walls
Changeset: 396564992823 Author:sgabdura Date: 2013-11-18 08:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/396564992823 8028341: PSR:FUNC: SCOPE PARAMETER MISSING FROM THE -XX:+PRINTFLAGSFINAL Reviewed-by: dcubed, sla ! src/share/vm/runtime/globals.cpp

hg: jdk8/tl/jdk: 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm

2013-11-19 Thread kumar . x . srinivasan
Changeset: 40462a41b41b Author:ksrini Date: 2013-11-19 07:10 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40462a41b41b 8023978: [TEST_BUG] launcher tests must exclude platforms without server vm Reviewed-by: dholmes, mchung ! test/tools/launcher/ExecutionEnvironment.java !

Re: RFR(XS): 6605915 jinfo -flag functionality doesn't work with core files

2013-11-19 Thread Jaroslav Bachorik
Nice and harmless. +1 -JB- On 19.11.2013 13:11, Staffan Larsen wrote: This is a small change to the usage message of jinfo to clarify that the -flag option is not available for core files. The change is targeted for jdk9 and won’t be pushed until the jdk9 repos open up. webrev: http://cr.op

hg: jdk8/tl/jdk: 8028583: Add helper methods to test libraries

2013-11-19 Thread sean . coffey
Changeset: d1bb85f0a45a Author:coffeys Date: 2013-11-19 14:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1bb85f0a45a 8028583: Add helper methods to test libraries Reviewed-by: chegar ! test/java/rmi/testlibrary/TestLibrary.java ! test/lib/testlibrary/jdk/testlibrary/Fil

Re: RFR 6309226: TEST: java/lang/management/ThreadMXBean/SynchronizationStatistics.java didn't check Thread.sleep

2013-11-19 Thread Jaroslav Bachorik
Hi David, On 18.11.2013 22:03, David Holmes wrote: Hi Jaroslav, I think your phaser usage is incorrect: 88 public void run() { 89 p.arriveAndAwaitAdvance(); // phase[1] 90 synchronized(lock1) { 91 System.out.println("[L

RFR 6987597: ManagementFactory.getGarbageCollectorMXBeans() returns empty list with CMS

2013-11-19 Thread Jaroslav Bachorik
Please, review this test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-6987597 Webrev: http://cr.openjdk.java.net/~jbachorik/6987597/webrev.03 The fix moves the execution of the test routine to the GarbageCollectorMXBean notification handler - at that moment it's certain that GC has al

hg: jdk8/tl: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests

2013-11-19 Thread alan . bateman
Changeset: 9937f406e27e Author:alanb Date: 2013-11-19 14:11 + URL: http://hg.openjdk.java.net/jdk8/tl/rev/9937f406e27e 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! make/jprt.properties ! test/Makefile

hg: jdk8/tl/jdk: 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests

2013-11-19 Thread alan . bateman
Changeset: 2e574350a2b6 Author:alanb Date: 2013-11-19 14:08 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2e574350a2b6 8028478: Re-visit JPRT testsets to make it easier to run subsets of the tests Reviewed-by: dholmes, sla, tbell ! test/Makefile

hg: jdk8/tl/jdk: 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled

2013-11-19 Thread chris . hegarty
Changeset: d5ddde25d107 Author:tyan Date: 2013-11-19 13:46 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5ddde25d107 7086879: java/net/InetAddress/CheckJNI.java hangs on Linux when IPv6 enabled Reviewed-by: chegar ! test/ProblemList.txt

RFR(XS): 6605915 jinfo -flag functionality doesn't work with core files

2013-11-19 Thread Staffan Larsen
This is a small change to the usage message of jinfo to clarify that the -flag option is not available for core files. The change is targeted for jdk9 and won’t be pushed until the jdk9 repos open up. webrev: http://cr.openjdk.java.net/~sla/6605915/webrev.00/ bug: https://bugs.openjdk.java.net/

Re: RFR 8028141 intermittent test failure of LocalManagementTest

2013-11-19 Thread Chris Hegarty
Roger, Thanks for the reply. I agree completely with your explanation. I understand there are multiple efforts running to address this issue, so I'll leave it to yourselves to work out the details, but as far as a point fix, yours is good. -Chris. On 11/19/2013 01:09 AM, roger riggs wrote:

Re: RFR 8028141 intermittent test failure of LocalManagementTest

2013-11-19 Thread Alan Bateman
On 18/11/2013 21:59, roger riggs wrote: Please review this fix to improve the reliability of the jmxRemote/LocalManagementTest and CustomLauncherTest. The solution may apply to other tests that fail with ClassNotFound. The tests did not include the jdk.testlibrary in the classpath when it spa

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Dmitry Samersoff
Alan, It works on linux, solaris and macos. fuser should work on Windows/CYGWIN, No ideas what happens with Windows/MKS For Windows it might be better to use handle.exe from sysinternals - it do exactly the same and very reiliable in my experience. -Dmitry On 2013-11-19 14:58, Alan Bateman w

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Alan Bateman
On 19/11/2013 09:33, Dmitry Samersoff wrote: Jaroslav, Use fuser command to wait until file being closed is better way to do it if fuser -s filename; then Busy; else Ready; fi -Dmitry Do you know if this works on all platforms? -Alan

hg: jdk8/tl/jdk: 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt

2013-11-19 Thread erik . gahlin
Changeset: d6195774dd1f Author:egahlin Date: 2013-11-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6195774dd1f 8028505: Put sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh on ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Jaroslav Bachorik
On 19.11.2013 10:33, Dmitry Samersoff wrote: Jaroslav, Use fuser command to wait until file being closed is better way to do it if fuser -s filename; then Busy; else Ready; fi Thanks. Will try it. Currently I am rewriting such tests to java and using stdout redirection instead. -JB- -Dm

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Dmitry Samersoff
Jaroslav, Use fuser command to wait until file being closed is better way to do it if fuser -s filename; then Busy; else Ready; fi -Dmitry On 2013-11-19 13:00, Jaroslav Bachorik wrote: > On 19.11.2013 09:45, Alan Bateman wrote: >> On 18/11/2013 23:29, Erik Gahlin wrote: >>> Could I have a revi

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Alan Bateman
On 19/11/2013 09:00, Jaroslav Bachorik wrote: I think it is. Writing to a file does not guarantee that it's creation and actual write are atomic :( What I used to do was to write the data to one file and the use a second signaling file to notify the other party that the data has been succes

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Jaroslav Bachorik
On 19.11.2013 09:45, Alan Bateman wrote: On 18/11/2013 23:29, Erik Gahlin wrote: Could I have a review of this test fix. It appears it takes more than 10 s to write to a file on slow machines. Instead of sleeping 10 s the test now polls for the file to appear. There may be other issues with the

Re: RFR: 6402201: ProcessAttachTest.sh needs better synchronization

2013-11-19 Thread Alan Bateman
On 18/11/2013 23:29, Erik Gahlin wrote: Could I have a review of this test fix. It appears it takes more than 10 s to write to a file on slow machines. Instead of sleeping 10 s the test now polls for the file to appear. There may be other issues with the test, but it's hard to know without ru

Re: RFR 8028141 intermittent test failure of LocalManagementTest

2013-11-19 Thread taras ledkov
Dis you see the review: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/test/lib/testlibrary/jdk/testlibrary/Utils.java.sdiff.html (e.g. please take a look at the Utils.addTestJavaOpts) What do you think about common solution for test properties inheritance (for ProcessTools utils) becaus