Kevin,
The fix looks good.
For tests, we are trying to avoid adding new shell-script based tests since
they too often cause problems. Would it be possible to rewrite the test in pure
Java code? There are some helper routines in
test/testlibrary/com/oracle/java/testlibrary/ that could be useful
I need a Hotspot Reviewer to look at the (very small) hotspot-specific parts of
this fix.
Thanks,
/Staffan
On 18 dec 2013, at 22:03, Mandy Chung wrote:
> Looks fine to me. com.sun.management is a supported API and this needs a CCC.
>
> Mandy
>
> On 12/17/2013 6:09 AM, Staffan Larsen wrote:
> http://cr.openjdk.java.net/~kvn/8028468/webrev/
Should the agent/doc/cireplay.html be updated? Is there another doc on how to
use the replay support somewhere (wiki)?
ciReplay.cpp
typos:
// Use pointer because we may need to retirn inline records
// Replay Inlinig
vmError.cpp
typo:
// Do not
On 7/01/2014 8:09 PM, Staffan Larsen wrote:
I need a Hotspot Reviewer to look at the (very small) hotspot-specific parts of
this fix.
This all looks fine to me.
David
Thanks,
/Staffan
On 18 dec 2013, at 22:03, Mandy Chung wrote:
Looks fine to me. com.sun.management is a supported API a
Thanks David.
/Staffan
On 7 jan 2014, at 12:27, David Holmes wrote:
> On 7/01/2014 8:09 PM, Staffan Larsen wrote:
>> I need a Hotspot Reviewer to look at the (very small) hotspot-specific parts
>> of this fix.
>
> This all looks fine to me.
>
> David
>
>> Thanks,
>> /Staffan
>>
>> On 18 de
On 20 dec 2013, at 22:07, serguei.spit...@oracle.com wrote:
> Staffan,
>
> This is nice change and cleanup.
> I do not see any issues.
Thanks.
> The make/bsd/makefiles/dtrace.make shows that the jhelper.d is disabled for
> bsd
> which means that the jstack action is not supported there.
> I'm
One more question:
When can the code below cause an early return from process_compile()? Can that
really happen?
493 if (entry_bci != _entry_bci || comp_level != _comp_level) {
494 return;
495 }
496 const char* iklass_name =
_imethod->method_holder()->name()->as_u
Changeset: 1b503dd54b95
Author:rriggs
Date: 2014-01-07 11:50 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b503dd54b95
8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours()
Summary: Correct specification for Duration.toDays, toHours
Reviewed-by: l
On 1/7/14 3:47 AM, Staffan Larsen wrote:
On 20 dec 2013, at 22:07, serguei.spit...@oracle.com wrote:
Staffan,
This is nice change and cleanup.
I do not see any issues.
Thanks.
The make/bsd/makefiles/dtrace.make shows that the jhelper.d is disabled for bsd
which means that the jstack action
On 07/01/2014 20:30, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
Looks good.
-Alan.
On 1/7/2014 12:30 PM, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
Looks good. cc'ing serviceability-dev as java.lang.management is owned
by the serviceability team.
Mandy
On 1/7/14 4:49 AM, Roland Westrelin wrote:
One more question:
When can the code below cause an early return from process_compile()? Can that
really happen?
When replaying inlining it will skip OSR compilation if you dumped
inlining for normal compilation before (entry_bci != _entry_bci). And
Thank you, Roland
On 1/7/14 2:39 AM, Roland Westrelin wrote:
http://cr.openjdk.java.net/~kvn/8028468/webrev/
New webrev:
http://cr.openjdk.java.net/~kvn/8028468/webrev.01/
Should the agent/doc/cireplay.html be updated? Is there another doc on how to
use the replay support somewhere (wiki)
13 matches
Mail list logo
