On 1/8/2014 1:26 AM, David Holmes wrote:
IMO, it seems that the ThreadInfo was not updated to reflect the
introduction of the park()/unpark() methods. In the current state it
mistakenly reports parking a thread as blocking but if the
implementation is updated to include only blocking on monitor
Thank you, Roland
On 1/8/14 12:41 AM, Roland Westrelin wrote:
Thanks for the new webrev and explanations.
ciReplay.hpp
59 // Replay data file replay_pid%p.log is also created when VM crushes
when VM crashes
Fixed.
Thanks,
Vladimir
That looks good to me.
Roland.
On Jan 8, 2014, at 5:02
Hi Staffan
I wrote the test with a shell script and creating lots of classes because
that's the easiest way to trigger the bug. I will try to rewrite the test in
Pure Java and multiple classloaders and see whether it will trigger the bug - I
will get back to you on this.
In terms of the bug fi
Changeset: 5d05be02629c
Author:mfang
Date: 2014-01-07 21:44 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d05be02629c
8029239: jdk8 l10n resource file translation update - localenames
Reviewed-by: okutsu
! src/share/classes/sun/util/resources/de/LocaleNames_de.properties
!
Hi Staffan -
http://cr.openjdk.java.net/~kevinw/8028623/webrev.01/
Yes it's better now, getting pid and launching a tool etc have been
previous reasons to use a script, but with this new help it's not too
bad!...
Thanks,
Kevin
On 07/01/14 09:43, Staffan Larsen wrote:
Kevin,
The fix look
Francis,
To be honest (and because I’m lazy), it’s a bit more work to push this to jdk7u
than I am willing to spend. There isn’t a lot of activity in jdk7u any more and
you shouldn’t expect much to be changed there. Most of the activity now is in
jdk9.
Thanks,
/Staffan
On 21 dec 2013, at 18:0
Chan,
Thanks for providing a patch and extra points for adding a test case!
We are trying to move away from writing tests in shell-scripts because they
tend to break more often than Java-based tests. Do you think it is possible to
re-write your test case in pure Java? There are some helper clas
Changeset: 2437ccbf3504
Author:erikj
Date: 2014-01-08 14:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2437ccbf3504
8030781: System.setProperties(null) drops all system properties (RELEASE not
set)
Reviewed-by: alanb
+ test/java/lang/System/SetPropertiesNull.java
Changeset: 53d74b77ee53
Author:erikj
Date: 2014-01-08 14:02 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/rev/53d74b77ee53
8030781: System.setProperties(null) drops all system properties (RELEASE not
set)
Reviewed-by: alanb, ihse, tbell
! common/autoconf/generated-configure.sh
! c
Hi Taras,
Thanks for doing this clean up and conversion of tests into Java. Here’s a
couple of comments:
test/runtime/6294277/SourceDebugExtension.java:
This test could be simplified by not specifying an address at all. Since the
test never connects to the JVM started with -Xrunjdwp, there is
On 8/01/2014 9:39 PM, Jaroslav Bachorik wrote:
On 8.1.2014 12:35, David Holmes wrote:
On 8/01/2014 7:51 PM, Jaroslav Bachorik wrote:
On 8.1.2014 10:26, David Holmes wrote:
getBlockedCount(): Returns the total number of times that the thread
associated with this ThreadInfo blocked to enter or r
On 8.1.2014 12:35, David Holmes wrote:
On 8/01/2014 7:51 PM, Jaroslav Bachorik wrote:
On 8.1.2014 10:26, David Holmes wrote:
getBlockedCount(): Returns the total number of times that the thread
associated with this ThreadInfo blocked to enter or reenter a monitor.
None of CyclicBarrier/Phaser
Looks fine. I will take your word for it that these are indeed unused :)
David
On 8/01/2014 8:24 PM, Staffan Larsen wrote:
Can I have a Review of this one, please?
/Staffan
On 16 dec 2013, at 13:38, Staffan Larsen wrote:
tracetypes.xml has declarations of a couple of content_types that are
On 8/01/2014 7:51 PM, Jaroslav Bachorik wrote:
On 8.1.2014 10:26, David Holmes wrote:
getBlockedCount(): Returns the total number of times that the thread
associated with this ThreadInfo blocked to enter or reenter a monitor.
None of CyclicBarrier/Phaser etc are monitors, so the BlockedCount
sh
Looks good!
-JB-
On 8.1.2014 11:24, Staffan Larsen wrote:
Can I have a Review of this one, please?
/Staffan
On 16 dec 2013, at 13:38, Staffan Larsen wrote:
tracetypes.xml has declarations of a couple of content_types that are never
used.
bug: https://bugs.openjdk.java.net/browse/JDK-8030
Can I have a Review of this one, please?
/Staffan
On 16 dec 2013, at 13:38, Staffan Larsen wrote:
> tracetypes.xml has declarations of a couple of content_types that are never
> used.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8030184
> webrev: http://cr.openjdk.java.net/~sla/8030184/w
On 8.1.2014 10:26, David Holmes wrote:
On 8/01/2014 6:40 PM, Jaroslav Bachorik wrote:
Hi David,
On 7.1.2014 03:27, David Holmes wrote:
Hi Jaroslav,
On 23/12/2013 10:42 PM, Jaroslav Bachorik wrote:
Please, review the following test fix:
Issue : https://bugs.openjdk.java.net/browse/JDK-803084
On 8/01/2014 6:40 PM, Jaroslav Bachorik wrote:
Hi David,
On 7.1.2014 03:27, David Holmes wrote:
Hi Jaroslav,
On 23/12/2013 10:42 PM, Jaroslav Bachorik wrote:
Please, review the following test fix:
Issue : https://bugs.openjdk.java.net/browse/JDK-8030847
Webrev: http://cr.openjdk.java.net/~jb
Thanks for the new webrev and explanations.
ciReplay.hpp
59 // Replay data file replay_pid%p.log is also created when VM crushes
when VM crashes
That looks good to me.
Roland.
On Jan 8, 2014, at 5:02 AM, Vladimir Kozlov wrote:
> Thank you, Roland
>
> On 1/7/14 2:39 AM, Roland Westrelin wrot
19 matches
Mail list logo
