Looks good from my point of view.
/Staffan
On 27 jan 2014, at 21:46, Jesper Wilhelmsson
wrote:
> Staffan, Bengt, Mikael,
>
> Thanks for the reviews!
>
> I have made the changes you have suggested and a new webrev is available at:
>
> http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.5/
>
Staffan, Bengt, Mikael,
Thanks for the reviews!
I have made the changes you have suggested and a new webrev is available at:
http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.5/
I agree with your assessment that it would be good to implement a generic way to
verify manageable flags. I think
Kevin,
Thank you! (see also below)
On 2014-01-27 19:45, Kevin Walls wrote:
> Hi,
>
> Yes, change looks good I think.
>
> (I was just pleasantly surprised that SA_ALTROOT is respected by the
> product build where libsaproc_audit does not exist. But libsaproc_open
> is the open routine that resp
Hi Sunny,
This looks good!
- I’d like to avoid bug ids in the names of tests, so can you change the
directory name to say “DaemonThread”?
- The test takes quite a long time to run (~1 minute). I wonder if we should
shorten that by either starting less processes (currently 50) or letting each
Hi,
Yes, change looks good I think.
(I was just pleasantly surprised that SA_ALTROOT is respected by the
product build where libsaproc_audit does not exist. But libsaproc_open
is the open routine that respects the alt_root, and it needs to get
called by libproc in order to fixup paths for a
Looks good!
43 alt_root_initialized = -1;
I would have expect 1 instead of -1. But both work.
/Staffan
On 27 jan 2014, at 15:02, Dmitry Samersoff wrote:
> Staffan,
>
> Thank you for review. Comments addressed.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.02/
>
> -Dmitr
Staffan,
On 2014-01-27 17:53, Staffan Larsen wrote:
> Sounds like we should investigate what it does and potentially remove it
> completely.
Agree. I'll file a bug.
-Dmitry
>
> /Staffan
>
> On 27 jan 2014, at 14:36, Dmitry Samersoff
> wrote:
>
>> Staffan,
>>
>> I had no ideas what libsapr
Staffan,
Thank you for review. Comments addressed.
http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.02/
-Dmitry
On 2014-01-27 17:38, Staffan Larsen wrote:
> Dmitry,
>
> agent/src/os/linux/libproc_impl.c
> line 35: it would be good to initialize alt_root to something for clarity.
> lin
Sounds like we should investigate what it does and potentially remove it
completely.
/Staffan
On 27 jan 2014, at 14:36, Dmitry Samersoff wrote:
> Staffan,
>
> I had no ideas what libsaproc_audit is for, code at
>
> hotspot/agent/src/os/solaris/proc/saproc_audit.cpp
>
> didn't get me a clue.
Dmitry,
agent/src/os/linux/libproc_impl.c
line 35: it would be good to initialize alt_root to something for clarity.
line 41-46: it looks like this will cause getenv() to be called for every call
to pathmap_open if SA_ALTROOT is set. Perhaps better to add an
alt_root_initialized variable instead
Staffan,
I had no ideas what libsaproc_audit is for, code at
hotspot/agent/src/os/solaris/proc/saproc_audit.cpp
didn't get me a clue.
new build system doesn't build it and it seems like everything works fine.
-Dmitry
On 2014-01-27 17:18, Staffan Larsen wrote:
> I wasn’t aware that these makef
I wasn’t aware that these makefiles and utilities were still around, much less
in use. We really should consolidate them into the main hotspot makefiles.
Anyway, changes look fine.
/Staffan
On 19 jan 2014, at 11:03, Dmitry Samersoff wrote:
> Hi Everyone,
>
> Please review small SA fix.
>
>
Hi Staffan,
I have attached the new version of the patch - I have reworked the test case
and now it is mostly based in Java, but I have decided to keep using the shell
script to build the Agent Jar file as it is easier.
Thanks.
From: Staffan Larsen [mailto:staffan.lar...@oracle.com]
Sent: 13 J
Jaroslav,
Looks good for me.
-Dmitry
On 2014-01-21 19:50, Jaroslav Bachorik wrote:
> Please, review the following test fix.
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8031701
> Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00
>
> The ThreadExecutionSynchronizer was re
On 21.1.2014 16:50, Jaroslav Bachorik wrote:
Please, review the following test fix.
Issue : https://bugs.openjdk.java.net/browse/JDK-8031701
Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00
The ThreadExecutionSynchronizer was replaced by Phaser - this should
give more predictable
15 matches
Mail list logo
