Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

2014-01-28 Thread Staffan Larsen
Still looking for reviewers for this change. Thanks, /Staffan On 23 jan 2014, at 08:36, Staffan Larsen wrote: > The only usage today of the DTrace macros under the USDT1 define is the SDT > provider on linux. This can be changed to use the USDT2 style by > preprocessing the .d files into .h f

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

2014-01-28 Thread Bengt Rutisson
Hi Jesper, On 2014-01-27 21:46, Jesper Wilhelmsson wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you have suggested and a new webrev is available at: http://cr.openjdk.java.net/~jwilhelm/8028391/webrev.5/ Can you explain this code in psScavenge.cpp a bit?

hg: jdk8/tl/jdk: 8032585: JSR292: IllegalAccessError when attempting to invoke protected method from different package

2014-01-28 Thread eric . mccorkle
Changeset: 56d05f260123 Author:vlivanov Date: 2014-01-28 13:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d05f260123 8032585: JSR292: IllegalAccessError when attempting to invoke protected method from different package Reviewed-by: twisti, jrose ! src/share/classes/su

RE: [PATCH] 7142035 assert in j.l.instrument agents during shutdown when daemon thread is running

2014-01-28 Thread Chan, Sunny
Hi Staffan, I agreed with your assessment and have incorporated your extra change into my patch. I have a couple of test runs and have determined that we can reduce each process period but we will need to repeat at least 50 times to reliably reproduce the issue in unpatched builds. So the inter

Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

2014-01-28 Thread Keith McGuigan
Hi Staffan, It looks ok to me. LInux has a 'dtrace' command now? -- - Keith On Tue, Jan 28, 2014 at 3:52 AM, Staffan Larsen wrote: > Still looking for reviewers for this change. > > Thanks, > /Staffan > > On 23 jan 2014, at 08:36, Staffan Larsen > wrote: > > > The only usage today of the DTr

Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

2014-01-28 Thread Staffan Larsen
On 28 jan 2014, at 15:51, Keith McGuigan wrote: > Hi Staffan, > > It looks ok to me. Thanks Keith! > LInux has a 'dtrace' command now? Yeah, it’s only there to provide the most basic dtrace compatibility for systemtap. I don’t think it can run dtrace scripts, but it can generate the heade

hg: jdk8/tl/hotspot: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: ce0320cdb075 Author:jeff Date: 2014-01-28 20:09 + URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ce0320cdb075 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/corba: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: 6d40c0d49c7a Author:jeff Date: 2014-01-28 20:09 + URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/6d40c0d49c7a 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/jaxws: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: 2b44c111e153 Author:jeff Date: 2014-01-28 20:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/2b44c111e153 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/jaxp: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: 60c2c003fa11 Author:jeff Date: 2014-01-28 20:09 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/60c2c003fa11 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/jdk: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: 72d0cc723560 Author:jeff Date: 2014-01-28 20:10 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72d0cc723560 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/langtools: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: afa91c54ff00 Author:jeff Date: 2014-01-28 20:10 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/afa91c54ff00 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/nashorn: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: d3b293a4d554 Author:jeff Date: 2014-01-28 20:10 + URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d3b293a4d554 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

hg: jdk8/tl/jdk: 8032711: Issue with Lambda in handling; ...

2014-01-28 Thread robert . field
Changeset: c8d9cdc6445c Author:rfield Date: 2014-01-28 13:02 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8d9cdc6445c 8032711: Issue with Lambda in handling 8032704: Issues with lib perm in Lambda Reviewed-by: jrose, ahgross, briangoetz ! src/share/classes/java/lang/invok

hg: jdk8/tl: 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8

2014-01-28 Thread jeff . dinkins
Changeset: 4f590c2cec75 Author:jeff Date: 2014-01-28 20:09 + URL: http://hg.openjdk.java.net/jdk8/tl/rev/4f590c2cec75 8032816: THIRDPARTYREADME LittleCMS preamble missing JRE 8 & JDK 8 Reviewed-by: lana ! THIRD_PARTY_README

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

2014-01-28 Thread Jesper Wilhelmsson
Bengt, Thanks for looking at the change. Answers inline. Bengt Rutisson skrev 28/1/14 2:02 PM: Hi Jesper, On 2014-01-27 21:46, Jesper Wilhelmsson wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you have suggested and a new webrev is available at: http://cr.o

Re: RFR: 8028391 - Make the Min/MaxHeapFreeRatio flags manageable

2014-01-28 Thread Jesper Wilhelmsson
Thanks for the review! /Jesper Staffan Larsen skrev 28/1/14 8:09 AM: Looks good from my point of view. /Staffan On 27 jan 2014, at 21:46, Jesper Wilhelmsson mailto:jesper.wilhelms...@oracle.com>> wrote: Staffan, Bengt, Mikael, Thanks for the reviews! I have made the changes you have sugges

Re: RFR 8031701: java/lang/management/ThreadMXBean/Locks.java: Thread WaitingThread is expected to wait on Object but got null Thread.State = RUNNABLE

2014-01-28 Thread Mandy Chung
Hi Jaroslav, On 1/21/14 7:50 AM, Jaroslav Bachorik wrote: Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8031701 Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00 The change looks okay. I like the new assertNoLock method and as you ind

Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1

2014-01-28 Thread serguei.spit...@oracle.com
Hi Staffan, Sorry for being late, I thought it was already reviewed. :) It looks good, just a minor question below. make/bsd/makefiles/dtrace.make Can this line be removed as it is not used in this file anymore? 55 DTRACE_SRCDIR = $(GAMMADIR)/src/os/$(Platform_os_family)/dtrace Thanks, Serg

hg: jdk8/tl/jdk: 8032697: Issues with Lambda

2014-01-28 Thread robert . field
Changeset: e385bd6f7338 Author:rfield Date: 2014-01-28 17:23 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e385bd6f7338 8032697: Issues with Lambda Reviewed-by: ahgross, briangoetz, dlsmith, rfield Contributed-by: daniel.sm...@oracle.com ! src/share/classes/java/lang/invoke