Re: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

Thanks, Christian! Serguei On 1/31/14 8:11 PM, Christian Thalinger wrote: I cannot comment on the performance impact but the change looks good. On Jan 31, 2014, at 6:58 PM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open

Re: RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

I cannot comment on the performance impact but the change looks good. On Jan 31, 2014, at 6:58 PM, serguei.spit...@oracle.com wrote: > Please, review the fix for: > https://bugs.openjdk.java.net/browse/JDK-6471769 > > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6

RFR (XS) 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-FRAME/ Summary: There is a general issue in the suspend equivalent condition mechanism: Two subsequent calls to the JvmtiEnv::

RR(S): JDK-8023667 SA: ExceptionBlob and other C2 classes not available in client VM

Hi Everybody, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8023667/webrev.01/ sa.js try to initialize all possible VM structures regardless of type of VM we are running on -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change th

hg: jdk8/tl/jdk: 8033278: Missed access checks for Lookup.unreflect* after 8032585

Changeset: f684c9773858 Author:vlivanov Date: 2014-01-31 21:07 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f684c9773858 8033278: Missed access checks for Lookup.unreflect* after 8032585 Reviewed-by: jrose, twisti ! src/share/classes/sun/invoke/util/VerifyAccess.java ! tes

hg: jdk8/tl/jdk: 4 new changesets

Changeset: 9f098aed44c0 Author:anazarov Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f098aed44c0 8032025: Update repeating annotations demo Reviewed-by: jfranck + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java

Re: Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Dmitry, It looks good. Thank you for answers and code adjustment. Thanks, Serguei On 1/31/14 1:48 AM, Dmitry Samersoff wrote: Serguei, Thank you for review. I'd updated webrev (see also below) http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.03/ On 2014-01-31 04:01, serguei.spit.

Re: Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Serguei, Thank you for review. I'd updated webrev (see also below) http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.03/ On 2014-01-31 04:01, serguei.spit...@oracle.com wrote: > Hi Dmitry, > > > agent/src/os/linux/libproc_impl.c > > Q: To the lines 56-71 (I'm taking a blame for askin