Hi Dmitry,
This looks okay to me.
But can I suggest not starting a new email thread when you need to
prompt for reviews as it makes this review disconnected from the
original RFR email. (I would have replied to the original but I don't
have a local copy to do that.)
Thanks,
David
On 5/02/2
Hi Dan,
Looks good to me. (I never run the install targets :( )
Thanks,
David
On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Gree
Ron,
Thanks for the review.
Dan
On 2/5/14 7:04 PM, Ron Durbin wrote:
Dan
The changes look good
Ron
-Original Message-
From: Daniel D. Daugherty
Sent: Wednesday, February 05, 2014 4:21 PM
To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net;
build-dev;
Doug
Dan
The changes look good
Ron
> -Original Message-
> From: Daniel D. Daugherty
> Sent: Wednesday, February 05, 2014 4:21 PM
> To: hotspot-runtime-...@openjdk.java.net;
> serviceability-dev@openjdk.java.net; build-dev;
> Doug Simon; Tom Rodriguez
> Subject: code review round 0 for minor
This code review request is going to three different aliases.
Don't use Thunderbird's "reply to list" option since it will
pick just _one_ of the _three_ lists.
Greetings,
Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS)
makefile fix our way. Here are the bug and webrev URLs:
On Wed, Feb 5, 2014 at 8:16 AM, David Holmes wrote:
> On 5/02/2014 5:09 PM, Jeremy Manson wrote:
>>
>> Also, don't you statically link libstdc++ into Hotspot?
>
>
> Normally yes.
>
That's bad - security-wise as well as from a usability perspective:
Security-wise because the JDK will need to be r
On 2014-02-04 17:46, Dmitry Samersoff wrote:
> Staffan,
>
> You was right, only two classes is C2 specific.
>
> Here is updated webrev.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8023667/webrev.02/
>
> -Dmitry
>
> On 2014-02-03 16:13, Staffan Larsen wrote:
>>
>> On 3 feb 2014, at 11:59, Dm
Hi Taras,
thanks for taking care of this.
The changes look fine to me.
One minor nit is unused imports of the library classes in
"test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java".
It does not use any of those classes as its base class
"AbstractFilePermissionTest" doe
Hi,
So please take a look at the review against JDK9.
The reviewed patch had not been integrated into JDK8.
Port to JDK9 is identical. The difference: the ProcessTools.java has
been already patched by Jaroslav.
Webrev for jdk part:
http://cr.openjdk.java.net/~anazarov/7195249/jdk/webrev.03/
Sorry, I forgot to paste URL of new webrev :-P
http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.04/
Yasumasa
On 02/05/2014 09:09 PM, Yasumasa Suenaga wrote:
Hi Erik,
Thank you for reviewing again!
I've updated new webrev.
On 02/05/2014 07:40 PM, Erik Helin wrote:
Hi Yasumasa,
I've l
Hi Erik,
Thank you for reviewing again!
I've updated new webrev.
On 02/05/2014 07:40 PM, Erik Helin wrote:
Hi Yasumasa,
I've looked through the latest patch, it is much better! I just have
two comments:
- ostream.hpp:
Why did you add GCLogFileSize != 0 in should_rotate? The old check
ju
Hi Yasumasa,
I've looked through the latest patch, it is much better! I just have two
comments:
- ostream.hpp:
Why did you add GCLogFileSize != 0 in should_rotate? The old check
just checked that _bytes_written > GCLogFileSize.
- TestGCLogRotationViaJcmd.java:
Could you use the helper c
Dmitry, Alan: Thanks!
On 3 feb 2014, at 21:31, Dmitry Samersoff wrote:
> Staffan,
>
> Looks good for me!
>
> -Dmitry
>
> On 2014-02-03 23:18, Staffan Larsen wrote:
>> OK, my last try at this was very broken - I’m glad it didn’t pass the review.
>>
>> Here is a new try: http://cr.openjdk.java
13 matches
Mail list logo
