On 2/4/14 12:45 PM, serguei.spit...@oracle.com wrote:
Thanks, Dan!
Some comments below.
On 2/4/14 7:48 AM, Daniel D. Daugherty wrote:
On 2/4/14 4:13 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8032223
Open webrev:
http://cr.ope
Changeset: 950921234b10
Author:katleman
Date: 2014-01-22 12:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/950921234b10
Added tag jdk8-b125 for changeset 790bbd46b201
! .hgtags
Changeset: 1b5d578f93ef
Author:katleman
Date: 2014-01-22 14:06 -0800
URL: http://hg
On 2/10/14 11:37 PM, David Holmes wrote:
Dan - thanks for an awesome analysis once again!
You're welcome.
Yes mea culpa the code I was looking at was sans Mr Simms most
fortuitous change. (I'm suffering from repo overload these days.)
No apology needed. It's a good thing that you and Karen
Changeset: 75cf17ceb6d1
Author:katleman
Date: 2014-01-22 12:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75cf17ceb6d1
Added tag jdk8-b125 for changeset ae303640bc1c
! .hgtags
Changeset: 95410515ba5f
Author:katleman
Date: 2014-01-22 14:08 -0800
URL: http:
Changeset: 16e0c6c84a91
Author:amurillo
Date: 2014-01-13 16:00 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/16e0c6c84a91
8031553: new hotspot build - hs25-b67
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 12ad8db39f76
Author:roland
Date: 2014-01-14 0
Changeset: c0040f0b75e2
Author:katleman
Date: 2014-01-22 12:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c0040f0b75e2
Added tag jdk8-b125 for changeset ef71ecbcd7bc
! .hgtags
Changeset: 7193a007a159
Author:katleman
Date: 2014-01-22 14:07 -0800
URL: htt
Changeset: d336209a0e45
Author:katleman
Date: 2014-01-22 12:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d336209a0e45
Added tag jdk8-b125 for changeset 7346abe2ea03
! .hgtags
Changeset: 095263db862d
Author:katleman
Date: 2014-01-22 14:00 -0800
URL: h
Changeset: 6a5af8a36aaf
Author:katleman
Date: 2014-01-22 12:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6a5af8a36aaf
Added tag jdk8-b125 for changeset 83bb924238f8
! .hgtags
Changeset: 390cc275c04c
Author:katleman
Date: 2014-01-22 14:07 -0800
URL: http
Changeset: 18c4d03cf516
Author:katleman
Date: 2014-01-22 12:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/18c4d03cf516
Added tag jdk8-b125 for changeset 7b45151c7a05
! .hgtags
Changeset: 8ceb68fd9e10
Author:katleman
Date: 2014-01-22 14:06 -0800
URL: htt
Changeset: 9a4dbfe11ed1
Author:katleman
Date: 2014-01-22 12:54 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9a4dbfe11ed1
Added tag jdk8-b125 for changeset 436176151e85
! .hgtags
Changeset: ba24b6304362
Author:katleman
Date: 2014-01-22 14:09 -0800
URL:
The fix looks good.
But could you change "impossible" at line 45 to something more adequate,
i.e. "caught exception"? :
41 System.out.println("---TestPostFieldModification-run waiting to exit
...");
42 try {
43 System.in.read();
44 } catch (Exception
Staffan,
Nice catch!
Looks good for me.
-Dmitry
On 2014-02-11 18:12, Staffan Larsen wrote:
> Updated the test to use proper synchronization and notification between
> threads. Should be more stable and much faster.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-6952105
> webrev: http://cr.
Staffan,
It is nice fix to have.
I do not see any issues with it.
Thanks,
Serguei
On 2/11/14 6:12 AM, Staffan Larsen wrote:
Updated the test to use proper synchronization and notification between
threads. Should be more stable and much faster.
bug: https://bugs.openjdk.java.net/browse/JDK-69
I think what you need to do is wait for the VMStartEvent before you add
requests to the VM. Note this paragraph from the VirtualMachine doc:
Note that a target VM launched by a launching connector is not
guaranteed to be stable until after the VMStartEvent has been
received.
I think adding co
This changeset was erroneously pushed to jdk8/tl/jdk:
Changeset: da4b0962ad11
Author:robm
Date: 2014-02-10 14:35 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da4b0962ad11
7152892: some jtreg tests fail with permission denied
Reviewed-by: coffeys
! test/java/
Here is the new fix in which FieldMonitor will write to
TestPostFieldModification, to inform the latter to quit, as suggested bu
Jaroslav
http://cr.openjdk.java.net/~sjiang/JDK-8007710/01/
Thanks,
Shanliang
shanliang wrote:
shanliang wrote:
Jaroslav Bachorik wrote:
On 11.2.2014 16:31, sh
On 11.2.2014 17:17, shanliang wrote:
Jaroslav Bachorik wrote:
On 11.2.2014 16:31, shanliang wrote:
Staffan Larsen wrote:
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the
ClassPrepareEvent happens, the debuggee will be suspended. So when
addFieldWatch() is called, th
shanliang wrote:
Jaroslav Bachorik wrote:
On 11.2.2014 16:31, shanliang wrote:
Staffan Larsen wrote:
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the
ClassPrepareEvent happens, the debuggee will be suspended. So when
addFieldWatch() is called, the debuggee should no
Jaroslav Bachorik wrote:
On 11.2.2014 16:31, shanliang wrote:
Staffan Larsen wrote:
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the
ClassPrepareEvent happens, the debuggee will be suspended. So when
addFieldWatch() is called, the debuggee should not have moved.
I a
On 11.2.2014 16:31, shanliang wrote:
Staffan Larsen wrote:
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the
ClassPrepareEvent happens, the debuggee will be suspended. So when
addFieldWatch() is called, the debuggee should not have moved.
I am not expert of jdi so I m
Staffan Larsen wrote:
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the ClassPrepareEvent
happens, the debuggee will be suspended. So when addFieldWatch() is called, the
debuggee should not have moved.
I am not expert of jdi so I may miss something here. I checked
public web:
http://cr.openjdk.java.net/~sjiang/JDK-8007710/00/
Shanliang
shanliang wrote:
Hi ,
The problem could be that FieldMonitor did not have enough time to
"addFieldWatch" but the vm to monitor (TestPostFieldModification) was
already ended.
So we should make sure that TestPostFieldMo
Hi Shanliang,
I can’t quite see how the test can fail in this way. When the ClassPrepareEvent
happens, the debuggee will be suspended. So when addFieldWatch() is called, the
debuggee should not have moved.
One problem I do see with the test is that it does not wait for a VMStartEvent
before se
Hi ,
The problem could be that FieldMonitor did not have enough time to
"addFieldWatch" but the vm to monitor (TestPostFieldModification) was
already ended.
So we should make sure that TestPostFieldModification exits after
FieldMonitor has done necessary. The solution proposed here is that
Updated the test to use proper synchronization and notification between
threads. Should be more stable and much faster.
bug: https://bugs.openjdk.java.net/browse/JDK-6952105
webrev: http://cr.openjdk.java.net/~sla/6952105/webrev.00/
Thanks,
/Staffan
On 09/06/2013 01:32 PM, Mattis Castegren wrote:
Please let me know if you have ideas of what information would make
hs_err files more useful, and I will add them to my list.
Structured logging to the systemd journal would be an interesting
addition. This might be a bit tricky from a signal h
On 11 feb 2014, at 12:14, Erik Joelsson wrote:
> Looks good, but I can't help but wonder why the mapfile for libjfr is in the
> open.
Yes, that is unfortunate. It used to be in closed source in jdk7, but moved
into open with the new build system.
/Staffan
>
> /Erik
>
> On 2014-02-11 12:00
Looks good, but I can't help but wonder why the mapfile for libjfr is in
the open.
/Erik
On 2014-02-11 12:00, Staffan Larsen wrote:
Resending (email to build-dev bounced since I used the wrong sender address).
On 11 feb 2014, at 11:18, staf...@larsen.se wrote:
Please review this small fix f
Resending (email to build-dev bounced since I used the wrong sender address).
On 11 feb 2014, at 11:18, staf...@larsen.se wrote:
> Please review this small fix for libjfr/mapfile-vers.
>
> Thanks,
> /Staffan
>
> diff --git a/make/mapfiles/libjfr/mapfile-vers
> b/make/mapfiles/libjfr/mapfile-ve
Please review this small fix for libjfr/mapfile-vers.
Thanks,
/Staffan
diff --git a/make/mapfiles/libjfr/mapfile-vers
b/make/mapfiles/libjfr/mapfile-vers
--- a/make/mapfiles/libjfr/mapfile-vers
+++ b/make/mapfiles/libjfr/mapfile-vers
@@ -34,6 +34,7 @@
Java_oracle_jrockit_jfr_VMJFR_getPeri
30 matches
Mail list logo
