Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8034249
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/8034249-JVMTI-MON.1
Summary:
This issue was identified in the review of the 8032223 and it is
similar to the 8032223
but impacts different
On 2014-02-13 10:23, Alan Bateman wrote:
On 13/02/2014 17:56, Mikael Vidstedt wrote:
Alan,
I made the change to JarFacade.c myself last week, only to then see
the comment a few lines above where you added the new include. It
seems to indicate that including ctype.h on Solaris/SPARC is a bad
Hi,
Here is Version 4:
http://cr.openjdk.java.net/~sjiang/JDK-8007710/04/
1) remove the line
108 vm.resume()
2) call addClassWatch(vm) only when receiving VMStartEvent
3) make sure that the test receives ModificationWatchpointEvent
4) clean
Thanks,
Shanliang
shanliang wrote:
Staffan,
On 13/02/2014 17:56, Mikael Vidstedt wrote:
Alan,
I made the change to JarFacade.c myself last week, only to then see the comment
a few lines above where you added the new include. It seems to indicate that
including ctype.h on Solaris/SPARC is a bad idea. I have no idea if the comment
is sti
Alan,
I made the change to JarFacade.c myself last week, only to then see the comment
a few lines above where you added the new include. It seems to indicate that
including ctype.h on Solaris/SPARC is a bad idea. I have no idea if the comment
is still relevant, but that may be worth understand
Staffan,
Very nice analysis!
The fix must be very simple, just remove the line
108 vm.resume
it is an error because here the test does not yet treat the events in
eventSet.
the line
136 eventSet.resume();
is the right place to resume the threads after event treatment.
Here is the n
Adding serviceability-dev@openjdk.java.net since JVM/TI belongs to
the Serviceability team.
Please make sure that replies to this review thread include both
aliases for completeness.
Dan
On 2/13/14 9:57 AM, Siebenborn, Axel wrote:
Hi all,
could I have a review for the following change?
It
Looks fine to me.
--Sean
On 02/13/2014 08:18 AM, Alan Bateman wrote:
The number of native code warnings in the build is annoying so this is
another drive-by fix that eliminates a few of them in the serviceability
and security areas. The webrev with the changes is here:
http://cr.openjdk.java.
Changes look good.
/Staffan
On 13 feb 2014, at 14:18, Alan Bateman wrote:
>
> The number of native code warnings in the build is annoying so this is
> another drive-by fix that eliminates a few of them in the serviceability and
> security areas. The webrev with the changes is here:
>
> http
I think I understand what happens now.
The test code, simplified, looks like this (with the Thread.sleep() added that
causes the test to fail):
launchTarget();
addClassWatch();
vm.resume();
Thread.sleep(1000);
while(connected) {
eventSet = eventQueue.remove()
for(event : ev
The number of native code warnings in the build is annoying so this is
another drive-by fix that eliminates a few of them in the serviceability
and security areas. The webrev with the changes is here:
http://cr.openjdk.java.net/~alanb/8034856+8034857/webrev/
In the pkcs11 code the issue is t
Hi,
Could you please sponsor and submit this patch?
Mattias
- Original Message -
From: staffan.lar...@oracle.com
To: mattias.tobias...@oracle.com
Cc: serviceability-dev@openjdk.java.net
Sent: Monday, February 10, 2014 2:38:51 PM GMT +01:00 Amsterdam / Berlin / Bern
/ Rome / Stockholm / V
Staffan Larsen wrote:
On 13 feb 2014, at 10:17, Jaroslav Bachorik
wrote:
Hi Staffan,
On 12.2.2014 18:27, Staffan Larsen wrote:
I’m still not happy with this fix since I think the extra output stream
synchronization logic is not needed - the debuggee should be suspended at all
the
On 13 feb 2014, at 10:17, Jaroslav Bachorik
wrote:
> Hi Staffan,
>
> On 12.2.2014 18:27, Staffan Larsen wrote:
>> I’m still not happy with this fix since I think the extra output stream
>> synchronization logic is not needed - the debuggee should be suspended at
>> all the interesting points
Hi Staffan,
On 12.2.2014 18:27, Staffan Larsen wrote:
I’m still not happy with this fix since I think the extra output stream
synchronization logic is not needed - the debuggee should be suspended at all
the interesting points. The fix I proposed is cleaner and (as far as I can
tell) also fix
15 matches
Mail list logo
