RFR round 0 JDK8u backport of ObjectMonitor-JVM/TI hang fix (8028073)

2014-02-21 Thread Daniel D. Daugherty
Greetings, This is a code review request for the JDK8u-hs-dev backport of the following ObjectMonitor-JVM/TI hang fix: 8028073 race condition in ObjectMonitor implementation causing deadlocks https://bugs.openjdk.java.net/browse/JDK-8028073 Here is the JDK8u-hs-dev webrev URL: http:/

PING Re: RR(S): JDK-7189721 nightly tests failed on JDI attaching

2014-02-21 Thread Dmitry Samersoff
On 2014-02-14 18:52, Dmitry Samersoff wrote: > Hi Everyone, > > Please, review the changes. > > http://cr.openjdk.java.net/~dsamersoff/JDK-7189721/webrev.01/ > > Summary: > > If for some reason elf section with section names is not loaded to cache > it attempts to read data using NULL section p

RFR: 8035150 ShouldNotReachHere() in ConstantPool::copy_entry_to

2014-02-21 Thread Staffan Larsen
This is an attempt to solve a crash while redefining a class that has unresolved class references in its constant pool. I would appreciate some extra scrutiny here since I am unfamiliar with this code path. I have also added a test that causes a JVM crash without the fix. The updates to the te

Re: RFR 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

2014-02-21 Thread shanliang
Jaroslav Bachorik wrote: On 21.2.2014 10:26, shanliang wrote: Jaroslav Bachorik wrote: Hi Shanliang, On 20.2.2014 19:20, shanliang wrote: Jaroslav, The failed tests were: 1, 7, 8, 9 but the tests using this port (port2: 50235) were 1, 3, 4, 6, 7, 8, 9 and tests 2,4,6 were passed.

Re: RFR 8033787: [TESTBUG] Few jdk regression management tests should be improved with -XX:+UsePerfData usage

2014-02-21 Thread David Holmes
Looks okay to me. David On 21/02/2014 8:13 PM, Jaroslav Bachorik wrote: Please, review this very simple test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8033787 Webrev: http://cr.openjdk.java.net/~jbachorik/8033787/webrev.00 The fix just adds -XX:+UsePerfData parameter to the @run s

RFR 8033787: [TESTBUG] Few jdk regression management tests should be improved with -XX:+UsePerfData usage

2014-02-21 Thread Jaroslav Bachorik
Please, review this very simple test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8033787 Webrev: http://cr.openjdk.java.net/~jbachorik/8033787/webrev.00 The fix just adds -XX:+UsePerfData parameter to the @run section of the mentioned test. -JB-

Re: RFR 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

2014-02-21 Thread Jaroslav Bachorik
On 21.2.2014 10:26, shanliang wrote: Jaroslav Bachorik wrote: Hi Shanliang, On 20.2.2014 19:20, shanliang wrote: Jaroslav, The failed tests were: 1, 7, 8, 9 but the tests using this port (port2: 50235) were 1, 3, 4, 6, 7, 8, 9 and tests 2,4,6 were passed. so I think that the proble

Re: RFR 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

2014-02-21 Thread shanliang
Jaroslav Bachorik wrote: Hi Shanliang, On 20.2.2014 19:20, shanliang wrote: Jaroslav, The failed tests were: 1, 7, 8, 9 but the tests using this port (port2: 50235) were 1, 3, 4, 6, 7, 8, 9 and tests 2,4,6 were passed. so I think that the problem might be that the port was not fully