Hi Yasu,
I think this looks good except for the comment in globals.hpp for
GCLogFileSize which needs to be updated.
What do you think about the following?
product(uintx, GCLogFileSize, 8*K, \
"GC log file size, requires UseGCLogFileRotation. " \
"Set t
Hi Yumin,
Thank you for comments.
I've updated webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.06/
Could you review this?
Thanks,
Yasumasa
On 03/04/2014 03:29 PM, Yumin Qi wrote:
Yasumasa,
Seems no comments for this email so far. I have some comments of
the changes:
The jinfo utility has three flags:
-flag: set/get value of a JVM flag
-flags: print all JVM flags
-sysprops: print all System.properties
Currently -flags and -sysprops invokes the Serviceability Agent to get the
information. Given how intrusive the SA is this is not ideal. I have changed
the de
Looks good to me!
Thanks,
/Staffan
On 4 mar 2014, at 12:47, Frederic Parain wrote:
> Here's an updated webrev:
> http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
>
> Same testing as for the initial version.
>
> Thank you,
>
> Fred
>
> On 03/03/2014 10:32 PM, Alan Bateman wrote:
>> On
On 04/03/2014 11:47, Frederic Parain wrote:
Here's an updated webrev:
http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
Same testing as for the initial version.
This looks good to me (and RESTARTABLE not needed because it loops until
all bytes are ready anyway).
-Alan.
On 2014-02-14 18:52, Dmitry Samersoff wrote:
> Hi Everyone,
>
> Please, review the changes.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-7189721/webrev.01/
>
> Summary:
>
> If for some reason elf section with section names is not loaded to cache
> it attempts to read data using NULL section p
Here's an updated webrev:
http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
Same testing as for the initial version.
Thank you,
Fred
On 03/03/2014 10:32 PM, Alan Bateman wrote:
On 03/03/2014 10:30, Frederic Parain wrote:
:
I'd prefer to keep open() and read() as they are,
for the sake
On 03/03/2014 21:59, Martin Buchholz wrote:
C infrastructure for OpenJDK has always been unsatisfactory.
JVM_Read was never documented, but did do EINTR system call restarting
via macros such as RESTARTABLE. Now that you've stopped using
JVM_Read, doesn't mean that the need to restart system
