Re: RFR: 8036599 Use Diagnostic Commands instead of SA by default in jinfo

On 6/03/2014 2:51 AM, Staffan Larsen wrote: On 5 mar 2014, at 14:17, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: On 04/03/2014 14:43, Staffan Larsen wrote: The jinfo utility has three flags: -flag: set/get value of a JVM flag -flags: print all JVM flags -sysprops: print all System.pr

Re: JDK-7090324: gclog rotation via external tool

Hi, Thank you so much! I'm glad to contribute this new feature. BTW, could you backport this feature to JDK7 and 8? I usually use JDK7 for my work. I want to this feature on JDK7. Thanks, Yasumasa On 03/06/2014 01:14 AM, Yumin Qi wrote: Yasumasa, This looks good. I will sponsor the inte

Re: NEED REVIEWERS !!! Re: RR(S): JDK-7189721 nightly tests failed on JDI attaching

Serguei, Thank you for the review. You are the first reviewer. -Dmitry On 2014-03-06 00:25, serguei.spit...@oracle.com wrote: > Not sure, you still need reviews, but ... > > The fix looks Ok to me. > I do not see any issues. > > Thanks, > Serguei > > On 3/4/14 5:05 AM, Dmitry Samersoff wrote

Re: NEED REVIEWERS !!! Re: RR(S): JDK-7189721 nightly tests failed on JDI attaching

Not sure, you still need reviews, but ... The fix looks Ok to me. I do not see any issues. Thanks, Serguei On 3/4/14 5:05 AM, Dmitry Samersoff wrote: On 2014-02-14 18:52, Dmitry Samersoff wrote: Hi Everyone, Please, review the changes. http://cr.openjdk.java.net/~dsamersoff/JDK-7189721/webr

Re: RFR: 8036599 Use Diagnostic Commands instead of SA by default in jinfo

On 05/03/2014 16:51, Staffan Larsen wrote: : There are other tests that exercise SA (not enough, though). I added back the SA tests with a -F option. new webrev: http://cr.openjdk.java.net/~sla/8036599/webrev.01/ This addresses the po

Re: RFR: 8036599 Use Diagnostic Commands instead of SA by default in jinfo

On 5 mar 2014, at 14:17, Alan Bateman wrote: > On 04/03/2014 14:43, Staffan Larsen wrote: >> The jinfo utility has three flags: >> -flag: set/get value of a JVM flag >> -flags: print all JVM flags >> -sysprops: print all System.properties >> >> Currently -flags and -sysprops invokes the Service

Re: JDK-7090324: gclog rotation via external tool

Yasumasa, This looks good. I will sponsor the integration --- since it adds new feature to jcmd, need internal process approval so after it is approved, I will do the push. Thanks Yumin On 3/5/2014 12:32 AM, Yasumasa Suenaga wrote: Hi Erik, Yumin, Thank you for comments. I've updated br

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

On 5 mar 2014, at 14:04, Alan Bateman wrote: > On 04/03/2014 07:09, Staffan Larsen wrote: >> >> Thanks for noticing! The same mistake was in all the inlined Java code. >> >> new webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.01/ >> >> /Staffan >> > Looks okay to me. In passing I see

RE: RFR: 8036675 Compiler warnings in serviceability code

Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 5 mars 2014 13:15 To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: RFR: 8036675 Compiler warnings in serviceability code This change addresses two compiler warnings in serviceabilit

Re: RFR: 8036599 Use Diagnostic Commands instead of SA by default in jinfo

On 04/03/2014 14:43, Staffan Larsen wrote: The jinfo utility has three flags: -flag: set/get value of a JVM flag -flags: print all JVM flags -sysprops: print all System.properties Currently -flags and -sysprops invokes the Serviceability Agent to get the information. Given how intrusive the SA

Re: RFR: 8036675 Compiler warnings in serviceability code

On 05/03/2014 12:14, Staffan Larsen wrote: This change addresses two compiler warnings in serviceability code. /home/staffan/mercurial/jdk9-dev/jdk/src/share/native/sun/tracing/dtrace/JVM.c:292:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Re: RFR: 8036132 Tab characters in test/com/sun/jdi files

On 04/03/2014 07:09, Staffan Larsen wrote: Thanks for noticing! The same mistake was in all the inlined Java code. new webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.01/ /Staffan Looks okay to me. In passing I see remnants of SCCS in the @test tag of StringConvertTest.sh, I assume the

Re: JDK-7090324: gclog rotation via external tool

Looks good. Thanks, /Staffan On 5 mar 2014, at 09:32, Yasumasa Suenaga wrote: > Hi Erik, Yumin, > > Thank you for comments. > > I've updated brief of GCLogFileSize. > New webrev is here: > http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.07/ > > Could you review again? > > > Thanks,

Re: JDK-7090324: gclog rotation via external tool

Hi Yasu, the change looks good now. I'm only a committer, so you need a Reviewer to look at your change as well. Thanks, Erik On 2014-03-05 09:32, Yasumasa Suenaga wrote: Hi Erik, Yumin, Thank you for comments. I've updated brief of GCLogFileSize. New webrev is here: http://cr.openjdk.java

RFR: 8036675 Compiler warnings in serviceability code

This change addresses two compiler warnings in serviceability code. /home/staffan/mercurial/jdk9-dev/jdk/src/share/native/sun/tracing/dtrace/JVM.c:292:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (len >= sizeof(buf)) { In this case I ad

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Thank you for the review Chris. Fred On 02/28/2014 11:27 PM, Chris Hegarty wrote: Looks good to me Frederic. JVM_Read is restartable, but that may not be an issue here. -Chris. On 28 Feb 2014, at 21:19, frederic parain wrote: Greetings, Please review this small changeset for CR JDK-80359

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Thank you for the review. Fred On 03/04/2014 03:46 PM, Staffan Larsen wrote: Looks good to me! Thanks, /Staffan On 4 mar 2014, at 12:47, Frederic Parain wrote: Here's an updated webrev: http://cr.openjdk.java.net/~fparain/8035952/webrev.01/ Same testing as for the initial version. Thank

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Oops, I replied to the wrong e-mail. Your latest comments have been taken into account in the final changeset. Thank you, Fred On 03/05/2014 11:31 AM, Frederic Parain wrote: Thank you for the review Alan. Fred On 03/03/2014 10:32 PM, Alan Bateman wrote: On 03/03/2014 10:30, Frederic Parain

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Mandy, Thank you for the review. Fred On 03/01/2014 12:10 AM, Mandy Chung wrote: On 2/28/14 1:19 PM, frederic parain wrote: Greetings, Please review this small changeset for CR JDK-8035952 "Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code" Bug: https://bugs.

Re: RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

Thank you for the review Alan. Fred On 03/03/2014 10:32 PM, Alan Bateman wrote: On 03/03/2014 10:30, Frederic Parain wrote: : I'd prefer to keep open() and read() as they are, for the sake of simplicity. In the unlikely case where one of these calls gets interrupted, it would simply generate

Re: JDK-7090324: gclog rotation via external tool

Hi Erik, Yumin, Thank you for comments. I've updated brief of GCLogFileSize. New webrev is here: http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.07/ Could you review again? Thanks, Yasumasa On 03/05/2014 03:47 PM, Erik Helin wrote: Hi Yasu, I think this looks good except for the c