Kelly,
Thank you for the background.
-Dmitry
On 2014-04-04 20:52, Kelly O'Hair wrote:
> Just as background information...
>
> The serviceability team should do what they think is right here, I'll just
> provide some history... ;)
>
> The original purpose of this library was to provide some
Just as background information...
The serviceability team should do what they think is right here, I'll just
provide some history... ;)
The original purpose of this library was to provide some generic native
platform tools for dealing with things that will happen BEFORE the JVM is
started an
Hi Everybody,
We have an libnpt.so[1] in JDK. This library contains bunch of UTF
related functions. On a brief investigation it looks like most of these
functions are not used. Six functions below called one time each from
share/back/* and hprof_init.c [2]
Should I file a CR to have it cleane
On 04/04/2014 12:33, Staffan Larsen wrote:
Please review the change below to add a test to ProblemList.txt. For details,
see https://bugs.openjdk.java.net/browse/JDK-8033104
Thanks,
/Staffan
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/Proble
Thanks Ivan.
I’ve been thinking a bit more about this and discussing with people here. I’m
not sure anymore that it is a good idea to cap the error message. My original
thought was that it made sense to not overflow the client with tons of output
if something went wrong in the target. On the ot
On 4/4/14 2:20 PM, Mattias Tobiasson wrote:
Hi Daniel,
Could you please sponsor the attached patch?
Webrev: http://cr.openjdk.java.net/~ykantser/8038822/webrev.01
The only change is that I have made BoundlessLoaderThread.pool final.
No Problem Mattias, I'll do it!
-- daniel
Mattias
-
Looks good!
Thanks,
/Staffan
On 4 apr 2014, at 16:02, Yekaterina Kantserova
wrote:
> Thanks, Jaroslav!
> Please find the new webrev here:
> http://cr.openjdk.java.net/~ykantser/8031766/webrev.01/
>
> // Katja
>
>
>
> On 04/04/2014 03:32 PM, Jaroslav Bachorik wrote:
>> Looks fine.
>> You m
No more comments.
-JB-
On 4.4.2014 16:02, Yekaterina Kantserova wrote:
Thanks, Jaroslav!
Please find the new webrev here:
http://cr.openjdk.java.net/~ykantser/8031766/webrev.01/
// Katja
On 04/04/2014 03:32 PM, Jaroslav Bachorik wrote:
Looks fine.
You might add a small performance improvem
Thanks, Jaroslav!
Please find the new webrev here:
http://cr.openjdk.java.net/~ykantser/8031766/webrev.01/
// Katja
On 04/04/2014 03:32 PM, Jaroslav Bachorik wrote:
Looks fine.
You might add a small performance improvement by taking out the regex
out of the loop at line 99 (compile the pat
Looks fine.
You might add a small performance improvement by taking out the regex
out of the loop at line 99 (compile the pattern before starting the loop).
-JB-
On 4.4.2014 15:25, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/
On 04/04/2014 13:29, David Holmes wrote:
On 4/04/2014 10:00 PM, Staffan Larsen wrote:
Please review the following small change to provide more information
from jstat when it fails.
bug: https://bugs.openjdk.java.net/browse/JDK-8028354
webrev: http://cr.openjdk.java.net/~sla/8028354/webrev.00/
Hi,
Could I please have a review of this fix.
webrev: http://cr.openjdk.java.net/~ykantser/8031766/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8031766
The bug is not visible. But short summary is as follows.
sun/tools/jstatd/TestJstatdPort.java, TestJstatdPortAndServer.java,
Test
Looks good.
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 4 april 2014 14:01
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net
Subject: RFR: 8028354 jstat does not provide enough information when fail to
read data from remote JVM
Please review the
An alternative, more compact variant might be
String getErrorMessage(InputStream sis, int maxlen) throws
IOException {
int n, off = 0, len = maxlen + 1;
byte b[] = new byte[len];
while ((n = sis.read(b, off, len - off)) > 0)
off +
Looks good.
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 4 april 2014 13:33
To: serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net;
core-libs-dev Libs
Subject: RFR: 8039256 Add sun/jvmstat/monitor/MonitoredVm/CR6672135.java to
ProblemList.txt
Please r
On 4 apr 2014, at 14:29, David Holmes wrote:
> On 4/04/2014 10:00 PM, Staffan Larsen wrote:
>> Please review the following small change to provide more information from
>> jstat when it fails.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8028354
>> webrev: http://cr.openjdk.java.net/~sl
On 4/04/2014 10:00 PM, Staffan Larsen wrote:
Please review the following small change to provide more information from jstat
when it fails.
bug: https://bugs.openjdk.java.net/browse/JDK-8028354
webrev: http://cr.openjdk.java.net/~sla/8028354/webrev.00/
Seems reasonable. But I bet there is a t
Now you reintroduced the smallish issue, when the message is exactly 200
characters (or whatever maxlen is).
The dots will be appended to the message, even though it's not necessary.
I think the only reliable way to deal with it is to try to read one
extra character from sis.
Something like t
Hi Daniel,
Could you please sponsor the attached patch?
Webrev: http://cr.openjdk.java.net/~ykantser/8038822/webrev.01
The only change is that I have made BoundlessLoaderThread.pool final.
Mattias
- Original Message -
From: mattias.tobias...@oracle.com
To: daniel.fu...@oracle.com
Cc: ser
Hi,
I have updated the patch with the following changes:
Util.java line 130 - Moved Pattern from function to "private static final"
RunUtil.java line 64 - Use diamond operator.
webrev: http://cr.openjdk.java.net/~ykantser/8030628/webrev.04
I have created an enhancement for porting the other
shel
I’m afraid you are right! Doh. Need to add more testing...
How about this change:
--- a/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
+++ b/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
@@ -267,9 +267,11 @@
String getErrorMessage(InputStream sis, int maxlen) t
Please review the following small change to provide more information from jstat
when it fails.
bug: https://bugs.openjdk.java.net/browse/JDK-8028354
webrev: http://cr.openjdk.java.net/~sla/8028354/webrev.00/
Thanks,
/Staffan
Thank you Staffan for fixing them!
But I'm afraid that now the function will never add ellipsis to the
message, even if it gets truncated.
Sincerely yours,
Ivan
On 04.04.2014 15:47, Staffan Larsen wrote:
Thanks for finding these bugs, Ivan!
I have updated the webrev at:
http://cr.openjdk.j
Thanks for finding these bugs, Ivan!
I have updated the webrev at:
http://cr.openjdk.java.net/~sla/8039173/webrev.01/, and I have also included
the diff below.
The updated webrev also has some changes in the javadoc for VirtualMachine to
clarify that some methods can now throw AttachOperationF
Please review the change below to add a test to ProblemList.txt. For details,
see https://bugs.openjdk.java.net/browse/JDK-8033104
Thanks,
/Staffan
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -273,4 +273,7 @@
# 8031482
sun
Hi Staffan!
I think there is a couple of minor bugs in getErrorMessage(InputStream
sis, int maxlen).
1) If maxlen is exactly the size of the message to read, the function
will add an ellipsis, even though the message isn't truncated,
2) If maxlen is greater than needed, then sis.read(b, off,
26 matches
Mail list logo
