Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On 05/12/2014 12:42 PM, Alan Bateman wrote: On 12/05/2014 11:03, Paul Sandoz wrote: It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. The groupings are a bit odd but I looked through the -core, -io, -management a

RFR: 8039995: Test serviceability/sa/jmap-hashcode/Test8028623.java fails on some Linux/Mac machines.

Hi, I'd like to get a review of this test change. It assumed that jmap would have permission to run on a process that the test itself created, but this is not necessarily the case. Here I'm considering it OK to skip (pass) the test where jmap fails to attach. The test itself was not platf

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

Hi Paul, I looked at -management and the changes there look good. There is just some two spaces vs four space formatting in line 99

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

> - security > http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-security/webrev/ Looks fine to me. Thanks for making this update. Xuelei On 5/12/2014 6:03 PM, Paul Sandoz wrote: > Hi, > > This is a request for review of Otavio's patch replacing StringBuffer > with Stri

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

src/share/classes/sun/misc/UUDecoder.java 126 StringBuilder x = new StringBuilder(); Is only filled, but doesn't seem to be used anyhow. Maybe just delete it? Sincerely yours, Ivan On 12.05.2014 14:03, Paul Sandoz wrote: Hi, This is a request for review of Otavio's patch replacing

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On May 12, 2014, at 12:42 PM, Alan Bateman wrote: > On 12/05/2014 11:03, Paul Sandoz wrote: >> >> It covers many areas and i have grouped the patches into such areas to aid >> reviewing. When commenting please including core-libs. > The groupings are a bit odd Yeah, definitely idiosyncratic,

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On 12/05/2014 11:03, Paul Sandoz wrote: It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. The groupings are a bit odd but I looked through the -core, -io, -management and -rmi patches and don't see any issues. Noth

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

Wouldn't it be a little bit more efficient to replace a string concatenation with yet another StringBuilder operation? src/share/classes/com/sun/java/util/jar/pack/BandStructure.java 631 StringBuilder sb = new StringBuilder(); ... 636 Utils.log.fine(" meta-c

JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

Hi, This is a request for review of Otavio's patch replacing StringBuffer with StringBuilder within OpenJDK. (I also need to review it.) It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. Jtreg tests showed no regre

Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

Pushed: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/05e9c9216e26 Thanks, /Staffan On 12 maj 2014, at 10:28, Yekaterina Kantserova wrote: > Staffan, > > could you please be my sponsor and push this fix? > > I have discovered three more tests that should be changed: > sun/management/jmxremote/

Fwd: Re: RFR(S): 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

Staffan, could you please be my sponsor and push this fix? I have discovered three more tests that should bechanged: sun/management/jmxremote/bootstrap/CustomLauncherTest.java java/lang/management/MemoryMXBean/CollectionUsageThreshold.java java/lang/management/MemoryMXBean/LowMemoryTest.java Th