Kris,
I've submitted the jprt job:
2014-05-17-060826.sspitsyn.hotspot
Thanks,
Serguei
On 5/16/14 3:38 PM, Krystal Mok wrote:
Thank you, Serguei!
BTW, Could you or Staffan sponsor this change and help me push it?
Best regards,
Kris
On Fri, May 16, 2014 at 3:20 PM, serguei.spit...@oracle.c
Thank you, Serguei!
BTW, Could you or Staffan sponsor this change and help me push it?
Best regards,
Kris
On Fri, May 16, 2014 at 3:20 PM, serguei.spit...@oracle.com <
serguei.spit...@oracle.com> wrote:
> On 5/15/14 1:19 PM, Krystal Mok wrote:
>
> Hi everyone,
>
> May I have a couple of revi
On 5/15/14 1:19 PM, Krystal Mok wrote:
Hi everyone,
May I have a couple of review for this small patch, please?
*Bug*: https://bugs.openjdk.java.net/browse/JDK-8043264
*Patch*: (against jdk9/hs)
diff -r 466b58fa837b src/share/vm/compiler/disassembler.cpp
--- a/src/share/vm/compiler/disassembl
Thumbs up. AFAIK, as the patch is imported without change, the
backport doesn't need to be re-reviewed.
Mandy
On 5/16/2014 2:59 AM, Mattias Tobiasson wrote:
Hi,
This is just a backport from jdk9 to jdk8u.
Could someone please review and push them?
The bug that needs to be fixed is:
https://
Serguei,
Thanks. will fix indend before push.
-Dmitry
On 2014-05-16 22:24, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> The lines 197-241 still have wrong indent - must be 4.
> Otherwise, it is good - reviewed.
>
> Thanks,
> Serguei
>
> On 5/16/14 8:19 AM, Dmitry Samersoff wrote:
>> Sergue
Dmitry,
The lines 197-241 still have wrong indent - must be 4.
Otherwise, it is good - reviewed.
Thanks,
Serguei
On 5/16/14 8:19 AM, Dmitry Samersoff wrote:
Serguei,
Fixed in place, please press shift-reload.
http://cr.openjdk.java.net/~dsamersoff/JDK-8041435/webrev.02/
-Dmitry
On 2014-05-
Serguei,
Fixed in place, please press shift-reload.
http://cr.openjdk.java.net/~dsamersoff/JDK-8041435/webrev.02/
-Dmitry
On 2014-05-16 03:19, serguei.spit...@oracle.com wrote:
> On 5/15/14 3:20 PM, serguei.spit...@oracle.com wrote:
>> Dmitry,
>>
>> I've reviewed the .01 webrev.
>
> Sorry, wan
Fredrik,
1. I'm not sure we have to provide user-configurable decoration.
It add complication to logger because not all decorations
available for all components and it creates a burden
for customer support because all tools would have
to support different log formats.
2. Backend might be
On Fri, 2014-05-16 at 11:45 +0100, Richard Warburton wrote:
> Hi,
Hi all,
I share this same doubts, and I'm also a bit confused.
> I'm not saying that an abstract framework should depend upon the details of
> the different components but if you had component definable markers for the
> type of i
Hi Richard, thanks for the feedback.
In the JEP I tried to explain the concept of 'sub' loggers but I did not
put in anything about the intent of having them. I think that your
requirement easily could be solved using sub loggers, or sub components
if you like that wording better.
Loggers ar
Hi,
Please help me review this updated version of the JEP-158 Unified JVM
> Logging that was pushed today to the JEP repository.
>
> Since the service posting the JEPs to http://openjdk.java.net/jeps/ site
> seems to be non working at the moment I am linking directly to the HG
> repository instead
On 16 maj 2014, at 10:59, Mario Torre wrote:
> On Fri, 2014-05-16 at 09:12 +0200, Staffan Larsen wrote:
>
> Hello Staffan,
>
> Thanks for the quick reply.
>
>> JEP 167 is done and should be in the completed state. I’ll see if I
>> can get that updated. The relevant bug (with change set inform
Hi,
This is just a backport from jdk9 to jdk8u.
Could someone please review and push them?
The bug that needs to be fixed is:
https://bugs.openjdk.java.net/browse/JDK-8030628
That patch depends on another patch that also has to be backported.
I have added both patches in this review.
Both patches
On Fri, 2014-05-16 at 09:12 +0200, Staffan Larsen wrote:
Hello Staffan,
Thanks for the quick reply.
> JEP 167 is done and should be in the completed state. I’ll see if I
> can get that updated. The relevant bug (with change set information)
> is: https://bugs.openjdk.java.net/browse/JDK-8005849.
Hi all
Please help me review this updated version of the JEP-158 Unified JVM
Logging that was pushed today to the JEP repository.
Since the service posting the JEPs to http://openjdk.java.net/jeps/ site
seems to be non working at the moment I am linking directly to the HG
repository instead.
Serguei,
Thank you for the review!
see below.
On 2014-05-16 02:20, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> I've reviewed the .01 webrev.
>
> src/share/transport/socket/socketTransport.c
>
> Lines 197-240: to be consistent with the rest of the file the indent must be
> 4, not 2.
>
>
JEP 167 is done and should be in the completed state. I’ll see if I can get
that updated. The relevant bug (with change set information) is:
https://bugs.openjdk.java.net/browse/JDK-8005849.
For seeing what instrumentation has been added, take a look at
src/share/vm/trace/trace.xml which lists
Thank you, Staffan!
Best regards,
Kris
On Thu, May 15, 2014 at 11:46 PM, Staffan Larsen
wrote:
>
> On 15 maj 2014, at 22:19, Krystal Mok wrote:
>
> Hi everyone,
>
> May I have a couple of review for this small patch, please?
>
> *Bug*: https://bugs.openjdk.java.net/browse/JDK-8043264
>
> *Patc
18 matches
Mail list logo
