Re: RFR: 8044135 Add API to start JMX agent from attach framework

Hi Staffan, A few general comments: VirtualMachine.java: - Can/should these references be links to external docs? _See the online documentation for "Monitoring and Management Using JMX Technology" for further details._ startManagementAgent(Properties agentProperties) should specify what ha

RFR (8u40) 8044473 : Allow for extended set of platform MXBeans

Please review my change for: 8044473 - Allow for extended set of platform MXBeans which adds an internal ExtendedPlatformComponent mechanism. There are no new public APIs or MXBeans. JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8044473 Webrev: http://cr.openjdk.java.net/~bchristi/804

Re: RFR: 8044135 Add API to start JMX agent from attach framework

On 09/06/2014 20:03, Staffan Larsen wrote: This is the first part in a two-part series of removing the management-agent.jar and replacing its functionality with APIs in the attach framework. In this change I have added the new APIs, a later change will remove management-api.jar. management-ag

RFR: 8044135 Add API to start JMX agent from attach framework

This is the first part in a two-part series of removing the management-agent.jar and replacing its functionality with APIs in the attach framework. In this change I have added the new APIs, a later change will remove management-api.jar. management-agent.jar is the java agent that is used with t

Re: RFR(XS): 8046348, 8046351, 8046352, 8046355: Adding tests to ProblemList.txt

Looks good. In the future I would prefer one changeset with all the changes since that would be easier to review. /Staffan On 9 jun 2014, at 17:27, Alex Schenkman wrote: > Please review these four additions to ProblemList.txt > > https://bugs.openjdk.java.net/browse/JDK-8046348 > http://cr.o

RFR(XS): 8046348, 8046351, 8046352, 8046355: Adding tests to ProblemList.txt

Please review these four additions to ProblemList.txt https://bugs.openjdk.java.net/browse/JDK-8046348 http://cr.openjdk.java.net/~miauno/8046348/ https://bugs.openjdk.java.net/browse/JDK-8046351 http://cr.openjdk.java.net/~miauno/8046351/ https://bugs.openjdk.java.net/browse/JDK-8046352 http:/

Re: RFR: 8046269: Build broken : THIS_FILE : undeclared identifier

Looks good! Thanks, /Staffan On 7 jun 2014, at 12:35, Seán Coffey wrote: > jdk7u-dev has windows build issues since JDK-8032901 fix was pushed. > bug report : https://bugs.openjdk.java.net/browse/JDK-8046269 > > Fix is simple and involves defining THIS_FILE if not defined. Not an issue > for

Re: RFR JDK-8046282: SA update

Thanks Markus! regards, Poonam On 6/9/2014 1:40 PM, Markus Grönlund wrote: Hi Poonam, I think this looks good (not a Reviewer). Thanks for giving SA some much needed attention. /Markus -Original Message- From: Poonam Bajaj Sent: den 7 juni 2014 11:18 To: serviceability-dev Subject:

Re: RFR JDK-8046282: SA update

Since SA is java code, we could have it cleaner.. my 2 cents, -Sundar On Monday 09 June 2014 02:40 PM, Poonam Bajaj wrote: Hi Sundar, Yes, it is possible to do that. e.g. G1YCType can be defined like this. public enum G1YCType { Normal ("Normal"), InitialMark ("Initial Mark"), DuringMa

Re: RFR JDK-8046282: SA update

Hi Sundar, Yes, it is possible to do that. e.g. G1YCType can be defined like this. public enum G1YCType { Normal ("Normal"), InitialMark ("Initial Mark"), DuringMark ("During Mark"), Mixed ("Mixed"), G1YCTypeEndSentinel ("Unknown") private final String value; G1YCType(String val

RE: RFR JDK-8046282: SA update

Hi Poonam, I think this looks good (not a Reviewer). Thanks for giving SA some much needed attention. /Markus -Original Message- From: Poonam Bajaj Sent: den 7 juni 2014 11:18 To: serviceability-dev Subject: RFR JDK-8046282: SA update Hi, Please review these changes for the bug 8046