Re: NEED REVIEWER RFR(S): JDK-8038392 Generating prelink cache breaks JAVA 'jinfo' utility normal behavior

Serguei, Thank you for the review, please see below. On 2014-06-12 14:49, serguei.spit...@oracle.com wrote: > Dmitry, > > Thank you for the details! > > I have a couple of comments so far. > > +if (word[5][0] == '[') { > +// not a shared library entry. ignore. > + if (strncmp(

Re: NEED REVIEWER RFR(S): JDK-8038392 Generating prelink cache breaks JAVA 'jinfo' utility normal behavior

Dmitry, Thank you for the details! I have a couple of comments so far. +if (word[5][0] == '[') { +// not a shared library entry. ignore. + if (strncmp(word[5],"[stack",6) == 0) { +continue; + } + if (strncmp(word[5],"[heap]",6) == 0) { +continue; +

Re: NEED REVIEWER RFR(S): JDK-8038392 Generating prelink cache breaks JAVA 'jinfo' utility normal behavior

Serguei, *The problem:* If someone run prelink utility while Java program is running DSO's mappings in it's /proc//maps become messy. After prelink it contains entry like /lib64/libc-2.15.so (deleted) /lib64/libpthread-2.15.so.#prelink#.EECVts instead of normal /lib64/libc-2.15.so Here i

Re: NEED REVIEWER RFR(S): JDK-8038392 Generating prelink cache breaks JAVA 'jinfo' utility normal behavior

Hi Dmitry, There is no description of the fix. Could you, please, provide one? What did you basically wanted to achieve? Also, how did the fix been tested? It seems, a unit test would be nice to have. Thanks, Serguei On 6/5/14 12:08 AM, Dmitry Samersoff wrote: http://cr.openjdk.java.net/~dsame

Re: RFR(XS): 8046348, 8046351, 8046352, 8046355: Adding tests to ProblemList.txt

Thanks for the review, Staffan. Could you please help me commit this? The changesets are attached. On 2014-06-09 19:12, Staffan Larsen wrote: Looks good. In the future I would prefer one changeset with all the changes since that would be easier to review. /Staffan On 9 jun 2014, at 17:27, A

Re: RFR JDK-8046282: SA update

Hi Sundar, Is it okay with you if I keep the enum and class definitions as they are now? And can I add you as the reviewer for these changes? Thanks, Poonam On 6/9/2014 2:56 PM, A. Sundararajan wrote: Since SA is java code, we could have it cleaner.. my 2 cents, -Sundar On Monday 09 June 2

Re: jmx-dev Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code

Looks good Erik shanliang skrev 12/06/14 08:21: Hi, Please review the following fix: webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044865 Thanks, Shanliang

Re: Codereview request: JDK-8044865 Fix raw and unchecked lint warnings in management-related code

Looks good Erik shanliang skrev 12/06/14 08:21: Hi, Please review the following fix: webrev: http://cr.openjdk.java.net/~sjiang/JDK-8044865/00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044865 Thanks, Shanliang