Re: RFR: 8046778 Better error messages when starting JMX agent via attach or jcmd

2014-06-17 Thread David Holmes
On 18/06/2014 4:40 AM, Staffan Larsen wrote: This change is still looking for a reviewer. Looks okay. Though in general the error handling in that code still seems somewhat lacking - there are places where exception chaining should be being used. David Thanks, /Staffan On 13 jun 2014, at

Re: RFR: 8044772 TempDirTest.java still times out with -Xcomp

2014-06-17 Thread David Holmes
Hi Staffan On 18/06/2014 4:30 AM, Staffan Larsen wrote: This test launches four other VMs, thus taking a very long time to run with -Xcomp. The real change here is to increase the timeout of the test, but I have also added some logging so that it is possible to see for how far along the test

Re: RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

2014-06-17 Thread Erik Gahlin
Hi Dmitry, I'm not worried about files being left behind from a previous run , they all have unique names. Erik Dmitry Samersoff skrev 2014-06-16 14:39: Erik, It's better to check lock-file age rather than maintain in-process timeout variable, it guards the test from the situation when l

Re: RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

2014-06-17 Thread Erik Gahlin
Yes, very weird Could have been that I needed the tools.jar in the child processes, or it could have been something else. If I remember correctly, I got a CNF that I didn't get with the shell script, but it was few months back. Anyway, I retried with JPRT and now it works without the shell sc

Re: RFR: 8046778 Better error messages when starting JMX agent via attach or jcmd

2014-06-17 Thread Staffan Larsen
This change is still looking for a reviewer. Thanks, /Staffan On 13 jun 2014, at 13:03, Staffan Larsen wrote: > > When starting the JMX agent via jcmd, the error messages you get are very > cryptic: > > $ build/macosx-x86_64-normal-server-release/jdk/bin/jcmd Sleeper > ManagementAgent.star

RFR: 8044772 TempDirTest.java still times out with -Xcomp

2014-06-17 Thread Staffan Larsen
This test launches four other VMs, thus taking a very long time to run with -Xcomp. The real change here is to increase the timeout of the test, but I have also added some logging so that it is possible to see for how far along the test has come if it times out. bug: https://bugs.openjdk.java.n

Re: RFR(S): JDK-8044762 com/sun/jdi/OptionTest.java test time out

2014-06-17 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 17 jun 2014, at 18:55, Dmitry Samersoff wrote: > Dan, > > Thank you. > > Typeo fixed (in-place). > > -Dmitry > > On 2014-06-17 18:35, Daniel D. Daugherty wrote: >> On 6/17/14 8:11 AM, Dmitry Samersoff wrote: >>> Please, >>> >>> Review a small fix: >>> >>>

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Staffan Larsen
Here is a rewrite of the test in Java instead of a shell script. Should be easier to maintain. webrev: http://cr.openjdk.java.net/~sla/8046883/webrev.00/ Thanks, /Staffan On 17 jun 2014, at 15:12, Staffan Larsen wrote: > > On 17 jun 2014, at 15:03, Alan Bateman wrote: > >> On 17/06/2014 13

Re: RFR(S): JDK-8044762 com/sun/jdi/OptionTest.java test time out

2014-06-17 Thread Dmitry Samersoff
Dan, Thank you. Typeo fixed (in-place). -Dmitry On 2014-06-17 18:35, Daniel D. Daugherty wrote: > On 6/17/14 8:11 AM, Dmitry Samersoff wrote: >> Please, >> >> Review a small fix: >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8044762/webrev.01/ > > src/share/back/debugInit.c > line 1290:

Re: RFR(S): JDK-8044762 com/sun/jdi/OptionTest.java test time out

2014-06-17 Thread Daniel D. Daugherty
On 6/17/14 8:11 AM, Dmitry Samersoff wrote: Please, Review a small fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8044762/webrev.01/ src/share/back/debugInit.c line 1290: LOG_MISC(("Dumping core as requiested by command line")); Typo: 'requiested' -> 'requested' Thumbs up. Dan

RFR(S): JDK-8044762 com/sun/jdi/OptionTest.java test time out

2014-06-17 Thread Dmitry Samersoff
Please, Review a small fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8044762/webrev.01/ under some circumstances debugInit_exit is called before gdata is initialized. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but t

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Staffan Larsen
On 17 jun 2014, at 15:03, Alan Bateman wrote: > On 17/06/2014 13:35, Staffan Larsen wrote: >> : >> >> It could be a timing issue, but in the other direction. If cygwin hasn’t yet >> started the real windows process when I run ps, then maybe ps will not list >> it. But given the “sleep 2” befo

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Alan Bateman
On 17/06/2014 13:35, Staffan Larsen wrote: : It could be a timing issue, but in the other direction. If cygwin hasn’t yet started the real windows process when I run ps, then maybe ps will not list it. But given the “sleep 2” before the ps invocation, the process should have had time to start

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Staffan Larsen
On 17 jun 2014, at 11:45, Alan Bateman wrote: > On 17/06/2014 09:24, Staffan Larsen wrote: >> This is yet another fallout of the bug in the ps command in cygwin that >> causes it to sometimes miss process in the list. >> >> In this case I cannot use jps to list the processes since one of the t

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Staffan Larsen
On 17 jun 2014, at 11:56, Dmitry Samersoff wrote: > Staffan, > > As we need windows pid it might be better to try native windows commands > instead of cygwin ps: > > tasklist I tried this, but since it does not list the command line it’s not possible to identify the process I am looking for.

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Dmitry Samersoff
Staffan, As we need windows pid it might be better to try native windows commands instead of cygwin ps: tasklist wmic process get Processid,Executablepath -Dmitry On 2014-06-17 12:24, Staffan Larsen wrote: > This is yet another fallout of the bug in the ps command in cygwin that > causes it

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Alan Bateman
On 17/06/2014 09:24, Staffan Larsen wrote: This is yet another fallout of the bug in the ps command in cygwin that causes it to sometimes miss process in the list. In this case I cannot use jps to list the processes since one of the test cases launches jdwp with suspend=y which suspends the VM

RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

2014-06-17 Thread Staffan Larsen
This is yet another fallout of the bug in the ps command in cygwin that causes it to sometimes miss process in the list. In this case I cannot use jps to list the processes since one of the test cases launches jdwp with suspend=y which suspends the VM before it is visible to jps. Instead I retr

Re: system profilers and incomplete stacks

2014-06-17 Thread serguei.spit...@oracle.com
Brendan, Thank you for the details, especially, about the perf_events! I was not aware about the issue on Linux. I agree, the Solaris jstack issue was not that bad back in 2005. It needs to be fixed cooperatively with the OS. We have an idea how to fix it, this work is at the prototyping stage n

Re: system profilers and incomplete stacks

2014-06-17 Thread Brendan Gregg
G'Day David, Looks like it's JDK-6276264; I'll answer these questions anyone in case anyone was interested... On Mon, Jun 16, 2014 at 10:48 PM, David Holmes wrote: > Hi Brendan, > > I'm not quite seeing the complete context here so a few queries: > > 1. Which platform are you running Dtrace on?