Re: RFR: 8044772 TempDirTest.java still times out with -Xcomp

2014-06-18 Thread Staffan Larsen
On 18 jun 2014, at 04:05, David Holmes david.hol...@oracle.com wrote: Hi Staffan On 18/06/2014 4:30 AM, Staffan Larsen wrote: This test launches four other VMs, thus taking a very long time to run with -Xcomp. The real change here is to increase the timeout of the test, but I have also

Re: RFR: 8046778 Better error messages when starting JMX agent via attach or jcmd

2014-06-18 Thread Staffan Larsen
On 18 jun 2014, at 04:11, David Holmes david.hol...@oracle.com wrote: On 18/06/2014 4:40 AM, Staffan Larsen wrote: This change is still looking for a reviewer. Looks okay. Though in general the error handling in that code still seems somewhat lacking - there are places where exception

Re: RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

2014-06-18 Thread Staffan Larsen
Erik, How about using Process.destroyForcibly() as a means to terminate the process instead of using files for signaling? /Staffan On 17 jun 2014, at 23:13, Erik Gahlin erik.gah...@oracle.com wrote: Yes, very weird Could have been that I needed the tools.jar in the child processes, or it

Re: RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

2014-06-18 Thread Erik Gahlin
Didn't know about destroyForcibly(). I could try that. Erik Staffan Larsen skrev 18/06/14 09:26: Erik, How about using Process.destroyForcibly() as a means to terminate the process instead of using files for signaling? /Staffan On 17 jun 2014, at 23:13, Erik Gahlin erik.gah...@oracle.com

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets java.io.IOException: Invalid process identifier on windows

2014-06-18 Thread Peter Allwin
This looks a lot better! (Since we’re using fancy new features we could use streams to find the connector instance) AttachingConnector ac = Bootstrap.virtualMachineManager().attachingConnectors() .stream() .filter(c - c.name().equals(com.sun.jdi.ProcessAttach))