Hi Serguei,
Thanks for taking a look and coming up with some suggestions on renaming the
field.
In regards to naming, I have followed the existing pattern for CMS support (see
"_saved_head" field).
As always on naming, I think it depends on which perspective you take: if you
take the view of
Hi Markus,
I'm Ok with the "_saved_unloading" if you prefer it.
Thanks!
Serguei
On 6/24/14 12:49 AM, Markus Grönlund wrote:
Hi Serguei,
Thanks for taking a look and coming up with some suggestions on renaming the
field.
In regards to naming, I have followed the existing pattern for CMS supp
Hi,
The test is to test a NPE during creating a JMX RMI server, but it got
timeout when starting a RMID, the fix is to remove this timeout, it is
not easy to have a reasonable timeout working for different testing
machines, and the test is not implemented to test sun.rmi.server.Activation.
b
Looks good!
Thanks,
/Staffan
On 24 jun 2014, at 10:30, shanliang wrote:
> Hi,
>
> The test is to test a NPE during creating a JMX RMI server, but it got
> timeout when starting a RMID, the fix is to remove this timeout, it is not
> easy to have a reasonable timeout working for different test
Looks fine!
-JB-
On 06/24/2014 10:30 AM, shanliang wrote:
Hi,
The test is to test a NPE during creating a JMX RMI server, but it got
timeout when starting a RMID, the fix is to remove this timeout, it is
not easy to have a reasonable timeout working for different testing
machines, and the test
These tests keep being unstable in nightly testing (see JDK-8032226) so will
have to be quarantined.
Thanks,
/Staffan
diff --git a/test/compiler/ciReplay/TestSA.sh b/test/compiler/ciReplay/TestSA.sh
--- a/test/compiler/ciReplay/TestSA.sh
+++ b/test/compiler/ciReplay/TestSA.sh
@@ -26,6 +26,7 @@
Hi,
Could I have a review of a small metadata fix for event based tracing.
A hidden field is added to the method metadata so it's possible to
filter uninteresting methods by a tracing backend, i.e. methods
annotated with j.l.i.Lambdaform$Hidden that show up in stack traces when
using Nashorn
Looks good!
Erik
shanliang skrev 2014-06-24 10:30:
Hi,
The test is to test a NPE during creating a JMX RMI server, but it got
timeout when starting a RMID, the fix is to remove this timeout, it is
not easy to have a reasonable timeout working for different testing
machines, and the test is
Looks good!
Thanks,
/Staffan
On 24 jun 2014, at 14:19, Erik Gahlin wrote:
> Hi,
>
> Could I have a review of a small metadata fix for event based tracing.
>
> A hidden field is added to the method metadata so it's possible to filter
> uninteresting methods by a tracing backend, i.e. methods
Looks good.
/Markus
-Original Message-
From: Erik Gahlin
Sent: den 24 juni 2014 14:19
To: Serviceability Dev
Subject: RFR(S): 8046783: Add hidden field to methods for event based tracing
Hi,
Could I have a review of a small metadata fix for event based tracing.
A hidden field is added
Staffan,
1. '@ignore' should be followed by CR numbers
2. I doubt that TestVM* failures are related to JDK-8032226. these tests
don't use SA agent, they rather fail due to JDK-8031978
Igor
On 06/24/2014 03:12 PM, Staffan Larsen wrote:
These tests keep being unstable in nightly testing (see J
On 24 jun 2014, at 14:45, Igor Ignatyev wrote:
> Staffan,
>
> 1. '@ignore' should be followed by CR numbers
Good catch - I have fixed that below.
> 2. I doubt that TestVM* failures are related to JDK-8032226. these tests
> don't use SA agent, they rather fail due to JDK-8031978
You are righ
12 matches
Mail list logo
