Looks good!
Thanks,
/Staffan
On 26 jun 2014, at 02:12, Erik Gahlin erik.gah...@oracle.com wrote:
Hi,
Could I have a review of a small fix that removes references to jfr from the
package.access list.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8047368
Webrev:
Indentation around JavaProcess.getId() is weird.
JavaProcess.getPid/setPid/pid do not appear to be used.
JavaProcess.waitForRemoval: How about using timestamps (currentTimeMillis())
before the loop and for each iteration to determine if the timeout has expired
(instead of time+=100”)?
nit:
Hi,
Today ProcessTools.executeProcess has the code:
new OutputAnalyzer(pb.start());
and OutputAnalyzer constructor calls immediately:
exitValue = process.exitValue();
the test got exception because the process did not end.
So a direct solution for the test is not to call:
Hi Shanliang,
On 06/26/2014 03:15 PM, shanliang wrote:
Hi,
Today ProcessTools.executeProcess has the code:
new OutputAnalyzer(pb.start());
and OutputAnalyzer constructor calls immediately:
exitValue = process.exitValue();
the test got exception because the process did not end.
Jaroslav Bachorik wrote:
Hi Shanliang,
On 06/26/2014 03:15 PM, shanliang wrote:
Hi,
Today ProcessTools.executeProcess has the code:
new OutputAnalyzer(pb.start());
and OutputAnalyzer constructor calls immediately:
exitValue = process.exitValue();
the test got exception because the
Looks good.
Best regards,
Vladimir Ivanov
On 6/25/14 5:57 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8013942
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/8013942-JVMTI-lobj.1
Summary:
This is
Thanks, Vladimir!
Serguei
On 6/26/14 3:02 PM, Vladimir Ivanov wrote:
Looks good.
Best regards,
Vladimir Ivanov
On 6/25/14 5:57 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8013942
Open webrev:
