Re: Fwd: PowerPC issue: Some JVMTI dynamic code generated events have code size of zero

2014-07-07 Thread Maynard Johnson
On 07/07/2014 10:51 AM, Volker Simonis wrote: > Hi Maynard, > > I've opened bug "PPC64: Don't use StubCodeMarks for zero-length stubs" > (https://bugs.openjdk.java.net/browse/JDK-8049441) for this issue. > Until it is resolved in the main code line, you can use the attached > patch to work around

Re: Fwd: PowerPC issue: Some JVMTI dynamic code generated events have code size of zero

2014-07-07 Thread Volker Simonis
Hi Maynard, I've opened bug "PPC64: Don't use StubCodeMarks for zero-length stubs" (https://bugs.openjdk.java.net/browse/JDK-8049441) for this issue. Until it is resolved in the main code line, you can use the attached patch to work around the problem. Regards, Volker On Mon, Jul 7, 2014 at 4:1

Re: Fwd: PowerPC issue: Some JVMTI dynamic code generated events have code size of zero

2014-07-07 Thread Maynard Johnson
On 07/02/2014 01:21 PM, Volker Simonis wrote: > After a quick look I can say that at least for the "flush_icache_stub" > and "verify_oop" cases we indeed generate no code. Other platforms > like x86 for example generate code for instruction cache flushing. The > starting address of this code is sav

Re: RFR 8049194: com/sun/tools/attach/StartManagementAgent.java start failing after JDK-8048193

2014-07-07 Thread olivier.lagn...@oracle.com
Hi Jaroslav, Thats looks good to me. Olivier. On 07/07/2014 12:15, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8049194 Webrev: http://cr.openjdk.java.net/~jbachorik/8049194/webrev.00 jdk.testlibrary.ProcessThread was erro

Re: RFR 8049194: com/sun/tools/attach/StartManagementAgent.java start failing after JDK-8048193

2014-07-07 Thread Erik Gahlin
Looks good Erik Jaroslav Bachorik skrev 2014-07-07 12:15: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8049194 Webrev: http://cr.openjdk.java.net/~jbachorik/8049194/webrev.00 jdk.testlibrary.ProcessThread was erroneously starting the external appl

Re: RFR(S): 8049340: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java timed out

2014-07-07 Thread Jaroslav Bachorik
On 07/07/2014 12:28 PM, Erik Gahlin wrote: Hi, I'm generally in favor of looping forever, but for this test it doesn't work since the test spawns child processes. Here is an updated version that forwards the system property. http://cr.openjdk.java.net/~egahlin/8049340_3/ I avoided Utils.TIMEOU

Re: RFR(S): 8049340: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java timed out

2014-07-07 Thread Erik Gahlin
Hi, I'm generally in favor of looping forever, but for this test it doesn't work since the test spawns child processes. Here is an updated version that forwards the system property. http://cr.openjdk.java.net/~egahlin/8049340_3/ I avoided Utils.TIMEOUT_FACTOR, since it would mean passing the

RFR 8049194: com/sun/tools/attach/StartManagementAgent.java start failing after JDK-8048193

2014-07-07 Thread Jaroslav Bachorik
Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8049194 Webrev: http://cr.openjdk.java.net/~jbachorik/8049194/webrev.00 jdk.testlibrary.ProcessThread was erroneously starting the external application with timeout of -1 - meaning no waiting for the targe

Re: RFR(S): 8049340: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java timed out

2014-07-07 Thread Jaroslav Bachorik
Hi Erik, I have a comment regarding the test timeout - you should scale the timeout according to "test.timeout.factor" system property set by JTReg (you can use "jdk.testlibrary.Utils.TIMEOUT_FACTOR" to access it easily) to prevent intermittent timeouts on slow configurations. Or you could co