Re: JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Mandy Chung
Thumbs up. Mandy On 7/9/2014 9:25 PM, Joe Darcy wrote: PS Upon double-checking, I neglected to include the changes to one other file in my earlier review request: --- a/src/share/classes/sun/management/GcInfoBuilder.javaThu Jul 10 03:07:48 2014 + +++ b/src/share/classes/sun/management

Re: JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Joe Darcy
PS Upon double-checking, I neglected to include the changes to one other file in my earlier review request: --- a/src/share/classes/sun/management/GcInfoBuilder.javaThu Jul 10 03:07:48 2014 + +++ b/src/share/classes/sun/management/GcInfoBuilder.javaWed Jul 09 21:24:03 2014 -0700 @

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-09 Thread David Holmes
I'm good with it too - as Erik is happy with it. So Reviewed. David On 10/07/2014 3:56 AM, Erik Gahlin wrote: Looks good! Not a Reviewer, but I can sponsor it. Erik Jeremy Manson skrev 08/05/14 20:56: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did thi

Re: RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

2014-07-09 Thread David Holmes
Hi Volker, Comments below where you might expect them :) On 10/07/2014 3:36 AM, Volker Simonis wrote: Hi, could someone please review and sponsor the following change which does some preliminary work for enabling the SA agent on Linux/PPC64: http://cr.openjdk.java.net/~simonis/webrevs/8049715

Re: JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Mandy Chung
On 7/9/2014 6:35 PM, Joe Darcy wrote: Hi Mandy, On 07/09/2014 06:26 PM, Mandy Chung wrote: On 7/9/2014 6:10 PM, Joe Darcy wrote: Hello, Another batch of lint warnings removal; this time for 8049820: Fix raw and unchecked lint warnings in sun.management http://cr.openjdk.java.net/~d

Re: JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Joe Darcy
Hi Mandy, On 07/09/2014 06:26 PM, Mandy Chung wrote: On 7/9/2014 6:10 PM, Joe Darcy wrote: Hello, Another batch of lint warnings removal; this time for 8049820: Fix raw and unchecked lint warnings in sun.management http://cr.openjdk.java.net/~darcy/8049820.0/ 230 @Suppress

Re: JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Mandy Chung
On 7/9/2014 6:10 PM, Joe Darcy wrote: Hello, Another batch of lint warnings removal; this time for 8049820: Fix raw and unchecked lint warnings in sun.management http://cr.openjdk.java.net/~darcy/8049820.0/ 230 @SuppressWarnings("rawtypes") 231 final Class enumClass

JDK 9 RFR of JDK-8049820: Fix raw and unchecked lint warnings in sun.management

2014-07-09 Thread Joe Darcy
Hello, Another batch of lint warnings removal; this time for 8049820: Fix raw and unchecked lint warnings in sun.management http://cr.openjdk.java.net/~darcy/8049820.0/ Patch below. Thanks, -Joe --- old/src/share/classes/sun/management/DiagnosticCommandImpl.java 2014-07-09 18:07:40.

Re: JDK 9 RFR of JDK-8049794: Fix raw and unchecked warnings in jvmstat

2014-07-09 Thread Joe Darcy
On 07/09/2014 02:48 PM, Mandy Chung wrote: On 7/9/2014 2:36 PM, Joe Darcy wrote: Hello, Please review these changes to address JDK-8049794: Fix raw and unchecked warnings in jvmstat http://cr.openjdk.java.net/~darcy/8049794.0/ I looked through the patch and the generified types loo

Re: JDK 9 RFR of JDK-8049794: Fix raw and unchecked warnings in jvmstat

2014-07-09 Thread Mandy Chung
On 7/9/2014 2:36 PM, Joe Darcy wrote: Hello, Please review these changes to address JDK-8049794: Fix raw and unchecked warnings in jvmstat http://cr.openjdk.java.net/~darcy/8049794.0/ I looked through the patch and the generified types look right except this: --- old/src/share/cla

JDK 9 RFR of JDK-8049794: Fix raw and unchecked warnings in jvmstat

2014-07-09 Thread Joe Darcy
Hello, Please review these changes to address JDK-8049794: Fix raw and unchecked warnings in jvmstat http://cr.openjdk.java.net/~darcy/8049794.0/ Patch below. Thanks, -Joe --- old/src/share/classes/sun/jvmstat/monitor/event/MonitorStatusChangeEvent.java 2014-07-09 14:30:52.

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-09 Thread Erik Gahlin
Looks good! Not a Reviewer, but I can sponsor it. Erik Jeremy Manson skrev 08/05/14 20:56: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did this wrong, I apologize. Basically, the debugger becomes very slow if there are a lot of methods in a class. This

JDK 9 RFR of JDK-8049736: Fix raw and unchecked lint warnings in sun.tracing

2014-07-09 Thread Joe Darcy
Hello, Please review the patch below which addresses JDK-8049736: Fix raw and unchecked lint warnings in sun.tracing Thanks, -Joe diff -r 2b7bf1d63a9c src/share/classes/sun/tracing/ProviderSkeleton.java --- a/src/share/classes/sun/tracing/ProviderSkeleton.javaWed Jul 09 10:02:30 2014

Re: PowerPC: core file option not available with serviceability tools

2014-07-09 Thread Volker Simonis
On Wed, Jul 9, 2014 at 3:45 PM, Maynard Johnson wrote: > On 07/04/2014 10:59 AM, Volker Simonis wrote: >> Hi Maynard, >> >> we (i.e. SAP) do not currently support the SA agent on Linux/PPC64 and >> AIX (we have other proprietary servicibility tools). Because of that >> (and because SA isn't specif

RFR(S): 8049715: PPC64: First steps to enable SA on Linux/PPC64

2014-07-09 Thread Volker Simonis
Hi, could someone please review and sponsor the following change which does some preliminary work for enabling the SA agent on Linux/PPC64: http://cr.openjdk.java.net/~simonis/webrevs/8049715/ https://bugs.openjdk.java.net/browse/JDK-8049715 Details: Currently, we don't support the SA agent on

Re: PowerPC: core file option not available with serviceability tools

2014-07-09 Thread Maynard Johnson
On 07/04/2014 10:59 AM, Volker Simonis wrote: > Hi Maynard, > > we (i.e. SAP) do not currently support the SA agent on Linux/PPC64 and > AIX (we have other proprietary servicibility tools). Because of that > (and because SA isn't specified by the SE specification) porting the > SA agent was no top