Re: Review Request: JDK-8049881: jstack not working on core files

Hi David, On 7/21/2014 5:52 PM, David Holmes wrote: Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on

Re: Review Request: JDK-8049881: jstack not working on core files

On 21/07/2014 10:55 PM, Markus Grönlund wrote: Hi David, I agree with your point about "absence". However, after some attempts by Poonam to do just that - it is apparent that SA does not allow for easy handling of this "absence" :-( This is one lesson learned from these fixes. I think we nee

Re: Review Request: JDK-8049881: jstack not working on core files

Poonam, Looks good for me. I prefer to always put brackets after if (l. 117), but it's not required. -Dmitry On 2014-07-21 13:29, Poonam Bajaj wrote: > The changes for "8046282: SA update" introduced this bug. The following > changes fix the failure. > > Bug: JDK-8049881

RE: Review Request: JDK-8049881: jstack not working on core files

Hi David, I agree with your point about "absence". However, after some attempts by Poonam to do just that - it is apparent that SA does not allow for easy handling of this "absence" :-( This is one lesson learned from these fixes. I think we need to find a way to resolve this moving forward. I

RE: Review Request: JDK-8049881: jstack not working on core files

Hi Poonam,   I think this looks good.   Thanks for fixing it.   Cheers Markus   From: Poonam Bajaj Sent: den 21 juli 2014 11:30 To: serviceability-dev@openjdk.java.net Subject: Review Request: JDK-8049881: jstack not working on core files   The changes for "8046282: SA update" introduc

Re: Review Request: JDK-8049881: jstack not working on core files

Hi Poonam, On 21/07/2014 7:29 PM, Poonam Bajaj wrote: The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on core files Webrev: http://cr.openjdk.java.net/~poonam

Re: RR(S) 8049684: pstack crashes on java core dump

Thanks Serguei, and thanks Sundar, -- Kevin On 18/07/14 23:22, serguei.spit...@oracle.com wrote: Hi Kevin, It looks good. Thank you fixing it! Thanks, Serguei On 7/18/14 5:02 AM, Kevin Walls wrote: Hi, May I get a review of this little change: pstack can crash on a Java core, where the

Review Request: JDK-8049881: jstack not working on core files

The changes for "8046282: SA update" introduced this bug. The following changes fix the failure. Bug: JDK-8049881 : jstack not working on core files Webrev: http://cr.openjdk.java.net/~poonam/8049881/webrev.00/ With these changes jstack works