Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread Daniel D. Daugherty
Here's the commit message: $ cat commit.txt 8055338: (process) Add instrumentation to help diagnose JDK-6573254 Reviewed-by: dcubed, ohair, iklam, dholmes, sspitsyn, sla I will commit the changeset as 'igerasim'. Didn't think a summary line was needed. Dan On 8/21/14 8:21 AM, Daniel D. Daugh

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread Daniel D. Daugherty
The correct repository would be RT_Baseline. What testing has been run on your fix? I know you've done a control build so that covers JPRT testing. I'll prep a repo for sponsoring the push, but I'll hold off pushing until I know what testing has been done. Dan On 8/21/14 4:57 AM, Ivan Gerasimo

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread Daniel D. Daugherty
On 8/20/14 1:36 PM, Ivan Gerasimov wrote: Hello everyone! Here's the third version of the webrev: http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/ src/os/windows/vm/os_windows.cpp line 444: res = java_lang_Thread::is_daemon(java_thread->threadObj()) line 453: thread->run();

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
On 08/21/2014 02:52 PM, Staffan Larsen wrote: Looks good, except I don’t think you wanted to add the test/sources.list file? Fixed the webrev - http://cr.openjdk.java.net/~jbachorik/8040692/webrev.01 - not to include test/sources.list file. Thanks for the review. -JB- /Staffan On 21 au

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
On 08/21/2014 02:52 PM, Staffan Larsen wrote: Looks good, except I don’t think you wanted to add the test/sources.list file? Nope. I've just realized that my review script includes all the applied MQ patches instead of only the last one. -JB- /Staffan On 21 aug 2014, at 14:44, Jaroslav B

RFR(S): JDK-8054194 jstack crash: assert(handle != NULL) failed: JNI handle should not be null

2014-08-21 Thread Dmitry Samersoff
Hi Everyone, Please review small agent changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8054194/webrev.01/ Under windows, If jstack attempts to attach to java process that is being killed by someone else, GetStaticObjectField might return NULL. -Dmitry -- Dmitry Samersoff Oracle Java devel

Re: jmx-dev RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Staffan Larsen
Looks good, except I don’t think you wanted to add the test/sources.list file? /Staffan On 21 aug 2014, at 14:44, Jaroslav Bachorik wrote: > Please, review this simple fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8040692 > Webrev: http://cr.openjdk.java.net/~jbachorik/8040692/web

RFR 8040692: [TESTBUG] sun/management/jmxremote/bootstrap/JvmstatCountersTest.java requires -XX:+UsePerfData option to pass on embedded platforms

2014-08-21 Thread Jaroslav Bachorik
Please, review this simple fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8040692 Webrev: http://cr.openjdk.java.net/~jbachorik/8040692/webrev.00 On embedded platforms it is necessary to provide "-XX:+UsePerfData" flag in order to make the performance counters accessible. This fix does t

Re: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012

2014-08-21 Thread Staffan Larsen
Markus, Christian: Thanks! On 21 aug 2014, at 13:10, Christian Tornqvist wrote: > Hi Staffan, > > This looks good, thanks for fixing this. > > Thanks, > Christian > > -Original Message- > From: serviceability-dev > [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Sta

RE: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012

2014-08-21 Thread Christian Tornqvist
Hi Staffan, This looks good, thanks for fixing this. Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Staffan Larsen Sent: Thursday, August 21, 2014 6:16 AM To: serviceability-dev@openjdk.java.net Subject: RFR

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread Ivan Gerasimov
Thanks for review! Could someone please sponsor it for me? I'm not sure what the correct repository is. Sincerely yours, Ivan On 21.08.2014 11:46, serguei.spit...@oracle.com wrote: +1 On 8/20/14 10:57 PM, Staffan Larsen wrote: Looks good to me. Let’s see what it uncovers. /Staffan On 20 au

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread David Holmes
Third time lucky :) Let's give it a go. David On 21/08/2014 5:36 AM, Ivan Gerasimov wrote: Hello everyone! Here's the third version of the webrev: http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/ The control build of the previous one was causing a lot of test failures. This one seems to

RE: RFR: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012

2014-08-21 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 21 augusti 2014 12:16 To: serviceability-dev@openjdk.java.net Subject: RFR: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012 This failure happens because the tes

RFR: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012

2014-08-21 Thread Staffan Larsen
This failure happens because the test look for the string “Exception” in the output of the program to signal a failure. With the improved version of NMT, the output from NMT sometimes includes this string in a stack trace. The solution I’ve implemented is to redirect the NMT output to a file ins

Re: RFR [8055338]: (process) Add instrumentation to help diagnose JDK-6573254

2014-08-21 Thread serguei.spit...@oracle.com
+1 On 8/20/14 10:57 PM, Staffan Larsen wrote: Looks good to me. Let’s see what it uncovers. /Staffan On 20 aug 2014, at 21:36, Ivan Gerasimov wrote: Hello everyone! Here's the third version of the webrev: http://cr.openjdk.java.net/~igerasim/8055338/2/webrev/ The control build of the prev