On 16/10/2014 12:33 AM, Dmitry Samersoff wrote:
David,
Sorry, copied wrong function!
I mean this call
weakRef = JNI_FUNC_PTR(env,NewWeakGlobalRef)(env, ref);
that can post OutOfMemoryError
Okay, so shouldn't that be where the exception is cleared:
/* Create weak reference to make sure
On 15/10/2014 11:55 PM, Jaroslav Bachorik wrote:
On 10/15/2014 10:11 AM, David Holmes wrote:
On 15/10/2014 5:50 PM, Jaroslav Bachorik wrote:
On 10/15/2014 02:10 AM, David Holmes wrote:
On 14/10/2014 8:46 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bu
David,
I will take another detail trace to see where the exception begins in
main thread, it should not thrown in main thread. I only saw it is
thrown in TestThread, not main, not DestroyJavaVM. If that happens,
maybe something wrong in vm.
The output in all 'failed' case (many failed not
David,
Sorry, copied wrong function!
I mean this call
weakRef = JNI_FUNC_PTR(env,NewWeakGlobalRef)(env, ref);
that can post OutOfMemoryError
commonRef_refToID() ->
createNode(JNIEnv *env, jobject ref) ->
weakRef = JNI_FUNC_PTR(env,NewWeakGlobalRef)(env, ref);
-Dmitry
On 2014-10-15 16:21,
Good.
Thanks,
Serguei
On 10/15/14 2:02 AM, Dmitry Samersoff wrote:
David,
Added extra check to be on safe side.
(in place - press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
-Dmitry
On 2014-10-15 12:17, David Holmes wrote:
On 15/10/2014 5:58 PM, Dmitry Same
On 10/15/2014 10:11 AM, David Holmes wrote:
On 15/10/2014 5:50 PM, Jaroslav Bachorik wrote:
On 10/15/2014 02:10 AM, David Holmes wrote:
On 14/10/2014 8:46 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8056143
Webrev: htt
On 15/10/2014 8:39 PM, Dmitry Samersoff wrote:
On 2014-10-15 14:27, David Holmes wrote:
On 15/10/2014 8:08 PM, Dmitry Samersoff wrote:
Please review the fix:
http://cr.openjdk.java.net/~dsamersoff/JDK-8030708/webrev.01/
Added missed exception checks.
src/jdk.jdwp.agent/share/native/libjdwp/
On 2014-10-15 14:27, David Holmes wrote:
> On 15/10/2014 8:08 PM, Dmitry Samersoff wrote:
>> Please review the fix:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8030708/webrev.01/
>>
>> Added missed exception checks.
>
> src/jdk.jdwp.agent/share/native/libjdwp/outStream.c
>
> What is potentia
On 15/10/2014 8:08 PM, Dmitry Samersoff wrote:
Please review the fix:
http://cr.openjdk.java.net/~dsamersoff/JDK-8030708/webrev.01/
Added missed exception checks.
src/jdk.jdwp.agent/share/native/libjdwp/outStream.c
What is potentially posting the exception?
David
Looks good to me, thank you for fixing this.
Fred
On 15/10/2014 11:02, Dmitry Samersoff wrote:
David,
Added extra check to be on safe side.
(in place - press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
-Dmitry
On 2014-10-15 12:17, David Holmes wrote:
On 15/
Please review the fix:
http://cr.openjdk.java.net/~dsamersoff/JDK-8030708/webrev.01/
Added missed exception checks.
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
Thanks Dmitry! Looks good.
David
On 15/10/2014 7:02 PM, Dmitry Samersoff wrote:
David,
Added extra check to be on safe side.
(in place - press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
-Dmitry
On 2014-10-15 12:17, David Holmes wrote:
On 15/10/2014 5:58 PM
David,
Added extra check to be on safe side.
(in place - press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
-Dmitry
On 2014-10-15 12:17, David Holmes wrote:
> On 15/10/2014 5:58 PM, Dmitry Samersoff wrote:
>> David,
>>
>> After close look I don't think that Array
On 15/10/2014 5:58 PM, Dmitry Samersoff wrote:
David,
After close look I don't think that Arrays.asList() could throw any
exception here. We are checking for possible null pointer at ll. 74
I would think OOME is always possible. But it was just a concern - if
the caller of getDiagnosticComman
On 15/10/2014 5:50 PM, Jaroslav Bachorik wrote:
On 10/15/2014 02:10 AM, David Holmes wrote:
On 14/10/2014 8:46 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8056143
Webrev: http://cr.openjdk.java.net/~jbachorik/8056143/we
David,
After close look I don't think that Arrays.asList() could throw any
exception here. We are checking for possible null pointer at ll. 74
So I would prefer to leave the code as is.
-Dmitry
On 2014-10-15 04:21, David Holmes wrote:
> Hi Dmitry,
>
> On 15/10/2014 3:46 AM, Dmitry Samersoff wr
On 10/15/2014 02:10 AM, David Holmes wrote:
On 14/10/2014 8:46 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8056143
Webrev: http://cr.openjdk.java.net/~jbachorik/8056143/webrev.00
The method jdk.testlibrary.ProcessTools.
17 matches
Mail list logo
