Re: RFR: 8024055: serviceability/attach/AttachWithStalePidFile.java createJavaPidFile() fails

2014-10-26 Thread David Holmes
Hi Peter, On 24/10/2014 11:39 PM, Peter Allwin wrote: Hello! This patch fixes two intermittent issues seen over the past year: a) Possible failure where an existing pid-file is not owned by the test user b) Race during startup where we try to attach to the target before it’s ready (remov

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

2014-10-26 Thread David Holmes
On 27/10/2014 1:15 AM, Ivan Gerasimov wrote: David, would you approve this fix? Sorry Ivan I'm having trouble following the logic this time - could you add some comments about what we are checking at each step. Also we seem to exit while still holding the critical section - how does that work

Re: RFR 8062070: com/sun/jdi/DoubleAgentTest.java.DoubleAgentTest fails intermittently after 8056143

2014-10-26 Thread David Holmes
On 25/10/2014 3:06 AM, Jaroslav Bachorik wrote: Please, review this change to the test library. Issue : https://bugs.openjdk.java.net/browse/JDK-8062070 Webrev: http://cr.openjdk.java.net/~jbachorik/8062070/webrev.00 The test started failing after the process.destroyForcibly() was added to Proc

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

2014-10-26 Thread Ivan Gerasimov
David, would you approve this fix? Sincerely yours, Ivan On 26.10.2014 19:01, Daniel D. Daugherty wrote: On 10/25/14 12:23 PM, Ivan Gerasimov wrote: On 25.10.2014 3:06, Daniel D. Daugherty wrote: On 10/1/14 3:07 AM, Ivan Gerasimov wrote: Hello! The tests that continue to fail with wrong ex

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

2014-10-26 Thread Daniel D. Daugherty
On 10/25/14 12:23 PM, Ivan Gerasimov wrote: On 25.10.2014 3:06, Daniel D. Daugherty wrote: On 10/1/14 3:07 AM, Ivan Gerasimov wrote: Hello! The tests that continue to fail with wrong exit codes suggest that the fix for JDK-8057744 wasn't sufficient. Here's another proposal, which expands the