Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

Thanks for the explanation Ivan, but I don't see any comments added to the code. So this latest fix all hinges on whether the part of the exit logic that corrupts the process exit value, happens before or after the logic that will cause a thread waiting on a terminating thread's handle to unbl

Re: RFR 8062070: com/sun/jdi/DoubleAgentTest.java.DoubleAgentTest fails intermittently after 8056143

On 10/26/2014 11:53 PM, David Holmes wrote: On 25/10/2014 3:06 AM, Jaroslav Bachorik wrote: Please, review this change to the test library. Issue : https://bugs.openjdk.java.net/browse/JDK-8062070 Webrev: http://cr.openjdk.java.net/~jbachorik/8062070/webrev.00 The test started failing after th

Re: RFR: JDK-8062137, JDK-8062136

Looks good! -JB- On 10/27/2014 03:52 PM, Alex Schenkman wrote: Please review two these excluded tests. http://cr.openjdk.java.net/~miauno/8062136_8062137/webrev.00/ Thank you! -- Alex Schenkman Java VM SQE Stockholm

Re: RFR 8061960: TestDaemonThread.java regularly fails due to exceeded timeout

Thumbs up! I wonder whether there are still some other tests with similarly displaced switches... -JB- On 10/27/2014 04:21 PM, Mattias Tobiasson wrote: Hi, Could someone please review this simple fix. The current version times out, because the timeout option is at the wrong position on the co

RFR 8061960: TestDaemonThread.java regularly fails due to exceeded timeout

Hi, Could someone please review this simple fix. The current version times out, because the timeout option is at the wrong position on the command line. Bug: https://bugs.openjdk.java.net/browse/JDK-8061960 Webrev: http://cr.openjdk.java.net/~miauno/8060165/webrev.00/ Thanks, Mattias

RFR: JDK-8062137, JDK-8062136

Please review two these excluded tests. http://cr.openjdk.java.net/~miauno/8062136_8062137/webrev.00/ Thank you! -- Alex Schenkman Java VM SQE Stockholm

Re: RFR: 8024055: serviceability/attach/AttachWithStalePidFile.java createJavaPidFile() fails

Hi Peter, On 10/24/2014 03:39 PM, Peter Allwin wrote: Hello! This patch fixes two intermittent issues seen over the past year: a) Possible failure where an existing pid-file is not owned by the test user b) Race during startup where we try to attach to the target before it’s ready (remov

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

On 27.10.2014 3:36, David Holmes wrote: On 27/10/2014 1:15 AM, Ivan Gerasimov wrote: David, would you approve this fix? Sorry Ivan I'm having trouble following the logic this time - could you add some comments about what we are checking at each step. Yes, sure. The main idea is to make th