2-nd round RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

The updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/jdk/6988950-JDWP-wrong-phase.2/ The changes are: - added a comment recommended by Staffan - removed the ignore_wrong_phase() call from function classSignature() The classSignature() function is called in 16 places. Most of

Re: RFR 8061616: HotspotDiagnosticMXBean.getVMOption() throws IllegalArgumentException for flags of type double

On 10/29/2014 6:50 AM, Jaroslav Bachorik wrote: Please review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8061616 Webrev : (jdk): http://cr.openjdk.java.net/~jbachorik/8061616/jdk/webrev.00/ (hotspot): http://cr.openjdk.java.net/~jbachorik/8061616/hotspot/webrev.

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

On 10/29/14 4:56 AM, Ivan Gerasimov wrote: On 29.10.2014 13:15, David Holmes wrote: Great improvement thanks! One further suggestion - after line 3731 add a short overview eg: // Basic approach: // - Each exiting thread registers its intent to exit and then does so. // - A thread trying t

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Thanks, Dmitry! I'm still in a process of checking the consequences of the ignore_wrong_phase() calls. Thanks, Serguei On 10/29/14 7:50 AM, Dmitry Samersoff wrote: Serguei, Thank you! Fix looks good for me. -Dmitry On 2014-10-29 17:35, serguei.spit...@oracle.com wrote: Dmitry, Yes, it w

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Serguei, Thank you! Fix looks good for me. -Dmitry On 2014-10-29 17:35, serguei.spit...@oracle.com wrote: > Dmitry, > > Yes, it will return NULL if the case of JVMTI_ERROR_WRONG_PHASE error. > It is Ok for the getMethodClass() as the NULL return value listed in the > comment. > It seems to be

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

On 10/29/14 7:35 AM, serguei.spit...@oracle.com wrote: Dmitry, Yes, it will return NULL if the case of JVMTI_ERROR_WRONG_PHASE error. A typo above: "if the case" => "in the case" Thanks, Serguei It is Ok for the getMethodClass() as the NULL return value listed in the comment. It seems to be

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Dmitry, Yes, it will return NULL if the case of JVMTI_ERROR_WRONG_PHASE error. It is Ok for the getMethodClass() as the NULL return value listed in the comment. It seems to be Ok for other two uses of the methodClass(). Thanks! Serguei On 10/29/14 6:59 AM, Dmitry Samersoff wrote: Serguei, W

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Staffan, Thank you for the review! I agree that maybe it'd make sense to ignore in all functions. But I'm trying to be careful - let's see if this approach works first. It is a good idea to add a comment. Thanks, Serguei On 10/29/14 4:52 AM, Staffan Larsen wrote: This looks good - and thanks f

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Dan, I do not have a scenario for non-anonymous class case while they should exist. The anonymous scenario was well reproducible in a range of the jdk8 ea builds. However, it is not as such anymore. I was not able to reproduce it in jdk9, nor 8u40. But I believe the shutdown race issue is stil

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Serguei, What happens in a caller function if we ignore the error? e. g. getMethodClass has the code: ... error = methodClass(method, &clazz); if ( error != JVMTI_ERROR_NONE ) { EXIT_ERROR(error,"Can't get jclass for a methodID, invalid?"); return NULL; } return c

RFR 8061616: HotspotDiagnosticMXBean.getVMOption() throws IllegalArgumentException for flags of type double

Please review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-8061616 Webrev : (jdk): http://cr.openjdk.java.net/~jbachorik/8061616/jdk/webrev.00/ (hotspot): http://cr.openjdk.java.net/~jbachorik/8061616/hotspot/webrev.00/ Currently the double values for VM flags are

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

Serguei, Do you have a scenario for the non-anonymous class case? This bug (6988950) has been around much longer than anonymous classes... Dan On 10/28/14 7:11 PM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6988950 Open webrev: h

Re: RFR: JDK-8062135; serviceability/threads/TestFalseDeadLock.java should be quarantined

Could you push it for me, please? Thanks! On 2014-10-29 12:56, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 29 okt 2014, at 09:50, Alex Schenkman > wrote: Please review this exluded test: http://cr.openjdk.java.net/~miauno/8062135/webrev.00/

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

Thanks Ivan - good to go. David On 29/10/2014 8:56 PM, Ivan Gerasimov wrote: On 29.10.2014 13:15, David Holmes wrote: Great improvement thanks! One further suggestion - after line 3731 add a short overview eg: // Basic approach: // - Each exiting thread registers its intent to exit and the

Re: RFR: JDK-8062135; serviceability/threads/TestFalseDeadLock.java should be quarantined

Looks good! Thanks, /Staffan On 29 okt 2014, at 09:50, Alex Schenkman wrote: > Please review this exluded test: > > http://cr.openjdk.java.net/~miauno/8062135/webrev.00/ > > Thank you! > -- > Alex Schenkman > Java VM SQE Stockholm

Re: RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

This looks good - and thanks for the detailed description! My only comment is that you chose to ignore the error in only some of the methods - I assume these were the methods where you have encountered a problem in. Should we write a comment about that, or should we ignore the error in all meth

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

On 29.10.2014 13:15, David Holmes wrote: Great improvement thanks! One further suggestion - after line 3731 add a short overview eg: // Basic approach: // - Each exiting thread registers its intent to exit and then does so. // - A thread trying to terminate the process must wait for all //

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

HI Ivan, On 29/10/2014 7:24 PM, Ivan Gerasimov wrote: Thanks David for the comments! On 28.10.2014 6:06, David Holmes wrote: Thanks for the explanation Ivan, but I don't see any comments added to the code. I've updated the webrev to include the comment that explain the logic of the workaroun

Re: RFR(S): 8060707: jdwp accept invalid address ':'

Looks good for me. -Dmitry On 2014-10-29 11:45, Sergei Kovalev wrote: > Hi Team, > > Could you please review following patch that fix the tests. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8060707 > Webrev: http://cr.openjdk.java.net/~iignatyev/skovalev/8060707/webrev.00/ > > Problem: >

Re: RFR 8059533: (process) Make exiting process wait for exiting threads [win]

Thanks David for the comments! On 28.10.2014 6:06, David Holmes wrote: Thanks for the explanation Ivan, but I don't see any comments added to the code. I've updated the webrev to include the comment that explain the logic of the workaround http://cr.openjdk.java.net/~igerasim/8059533/1/webre

Re: RFR(S): 8060707: jdwp accept invalid address ':'

Looks good! -JB- On 10/29/2014 09:45 AM, Sergei Kovalev wrote: Hi Team, Could you please review following patch that fix the tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8060707 Webrev: http://cr.openjdk.java.net/~iignatyev/skovalev/8060707/webrev.00/ Problem: A test failed because o

RFR: JDK-8062135; serviceability/threads/TestFalseDeadLock.java should be quarantined

Please review this exluded test: http://cr.openjdk.java.net/~miauno/8062135/webrev.00/ Thank you! -- Alex Schenkman Java VM SQE Stockholm

RFR(S): 8060707: jdwp accept invalid address ':'

Hi Team, Could you please review following patch that fix the tests. Bug: https://bugs.openjdk.java.net/browse/JDK-8060707 Webrev: http://cr.openjdk.java.net/~iignatyev/skovalev/8060707/webrev.00/ Problem: A test failed because of wrong assumption that stderr always starts with "ERROR" string