3-nd round RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

2014-10-31 Thread serguei.spit...@oracle.com
It is 3-rd round of review for: https://bugs.openjdk.java.net/browse/JDK-6988950 New webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/jdk/6988950-JDWP-wrong-phase.3/ Summary For failing scenario, please, refer to the 1-st round RFR below. I've found what is missed in the jdwp

Re: RFR 8060169: Update the Crash Reporting URL in the Java crash log

2014-10-31 Thread Poonam Bajaj
Hi David, On 10/31/2014 8:58 AM, david buck wrote: Hi! Please approve this very simple update to the URL written in the crash log (hs_err_pid.log) file. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8060169 WEBREV: http://cr.openjdk.java.net/~dbuck/8060169/webrev.000/ The changes look g

Code review: 8046192 Eliminate SNMP dependencies to the internal APIs from open jdk modules

2014-10-31 Thread shanliang
Hi, The fix is to remove unnecessary exports for jdk.snmp module. bug: https://bugs.openjdk.java.net/browse/JDK-8046192 webrev: http://cr.openjdk.java.net/~sjiang/JDK-8046192/00/ Thanks, Shanliang

RE: RFR 8060169: Update the Crash Reporting URL in the Java crash log

2014-10-31 Thread Ron Durbin
I agree with the change and give it my thumbs up. > -Original Message- > From: Daniel D. Daugherty > Sent: Friday, October 31, 2014 10:04 AM > To: david buck > Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR 8060169: Update the Crash Reporti

Re: RFR 8060169: Update the Crash Reporting URL in the Java crash log

2014-10-31 Thread Daniel D. Daugherty
On 10/31/14 9:58 AM, david buck wrote: Hi! Please approve this very simple update to the URL written in the crash log (hs_err_pid.log) file. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8060169 WEBREV: http://cr.openjdk.java.net/~dbuck/8060169/webrev.000/ src/share/vm/runtime/arguments.

RFR 8060169: Update the Crash Reporting URL in the Java crash log

2014-10-31 Thread david buck
Hi! Please approve this very simple update to the URL written in the crash log (hs_err_pid.log) file. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8060169 WEBREV: http://cr.openjdk.java.net/~dbuck/8060169/webrev.000/ Cheers, -Buck

RFR 8062647: Wrong indentation of arguments of annotated methods

2014-10-31 Thread Ivan Gerasimov
Hello everybody! I noticed that the javadoc tool may produce the doc with misaligned arguments of annotated methods in the 'method details' section. For example: http://jre.us.oracle.com/java/re/jdk/9/nightly/latest/docs/api/java/util/EnumSet.html#of-E-E...- Would you please help review the fi