Re: [ping] Re: RFR 8058506: ThreadMXBeanStateTest throws exception

2014-11-03 Thread David Holmes
On 3/11/2014 10:37 PM, Jaroslav Bachorik wrote: May I have a (R)eviewer to take a look at this, please? http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01 I don't understand the need for the semaphore given you do: 116 thread.join(); 117 System.out.println(threa

Re: RFR 8062116: JVMTI GetClassMethods is Slow

2014-11-03 Thread Coleen Phillimore
Hi Jeremy, I reviewed your new code and it looks fine. I had one comment in http://cr.openjdk.java.net/~jmanson/8062116/webrev.00/src/share/vm/prims/jvmtiEnv.cpp.udiff.html The name "need_to_resolve" doesn't make sense when reading this code. Isn't it more like "need_to_ensure_space" ? I t

Re: 3-nd round RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

2014-11-03 Thread serguei.spit...@oracle.com
On 11/3/14 10:41 AM, Daniel D. Daugherty wrote: On 10/31/14 3:07 PM, serguei.spit...@oracle.com wrote: It is 3-rd round of review for: https://bugs.openjdk.java.net/browse/JDK-6988950 New webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/jdk/6988950-JDWP-wrong-phase.3/ Thumbs up on t

Re: 3-nd round RFR (XS) 6988950: JDWP exit error JVMTI_ERROR_WRONG_PHASE(112)

2014-11-03 Thread Daniel D. Daugherty
On 10/31/14 3:07 PM, serguei.spit...@oracle.com wrote: It is 3-rd round of review for: https://bugs.openjdk.java.net/browse/JDK-6988950 New webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/jdk/6988950-JDWP-wrong-phase.3/ Thumbs up on the code. I have comment suggestions below... src

Re: Code review: 8046192 Eliminate SNMP dependencies to the internal APIs from open jdk modules

2014-11-03 Thread Mandy Chung
On 11/3/14 5:33 AM, shanliang wrote: Hi, Here is version 2: http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/ Looks okay to me. Thanks Mandy

Re: Code review: 8046192 Eliminate SNMP dependencies to the internal APIs from open jdk modules

2014-11-03 Thread Alan Bateman
On 03/11/2014 13:33, shanliang wrote: Hi, Here is version 2: http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/ The modification in ./jdk/src was missed in the first version. This looks okay to me now. -Alan

Re: Code review: 8046192 Eliminate SNMP dependencies to the internal APIs from open jdk modules

2014-11-03 Thread shanliang
Hi, Here is version 2: http://cr.openjdk.java.net/~sjiang/JDK-8046192/01/ The modification in ./jdk/src was missed in the first version. The webreviews show only modification in the public part. Thanks, Shanliang shanliang wrote: Hi, The fix is to remove unnecessary exports for jdk.snmp m

[ping] Re: RFR 8058506: ThreadMXBeanStateTest throws exception

2014-11-03 Thread Jaroslav Bachorik
May I have a (R)eviewer to take a look at this, please? http://cr.openjdk.java.net/~jbachorik/8058506/webrev.01 -JB- On 10/23/2014 03:31 PM, Erik Gahlin wrote: Looks good! Erik Jaroslav Bachorik skrev 2014-10-23 11:45: On 10/21/2014 07:47 PM, Jaroslav Bachorik wrote: On 10/21/2014 03:27 PM

Re: RFR 8061616: HotspotDiagnosticMXBean.getVMOption() throws IllegalArgumentException for flags of type double

2014-11-03 Thread Staffan Larsen
With Mandy’s suggestions this looks good to me too. /Staffan > On 29 okt 2014, at 20:34, Mandy Chung wrote: > > > On 10/29/2014 6:50 AM, Jaroslav Bachorik wrote: >> Please review the following change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-8061616 >> Webrev : >> (jdk): http:/