Re: RFR(XS): JDK-8059131 sawindbg.dll is not compiled with /SAFESEH

2014-11-10 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 9 nov 2014, at 08:28, Dmitry Samersoff wrote: > > Hi Everybody, > > Please review an one-line fix. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8059131/webrev.01/ > > Make variable $(SAFESEH_FLAG) is never set and is not used outside of > this line, so rep

Re: RFR (XXS): 8064348: Add TraceEvent::is_enabled() for embedded/minimal builds

2014-11-10 Thread Marcus Larsson
Hi, I somehow managed to add the const qualifier to this method although it shouldn't be there. Updated webrev (without the const): http://cr.openjdk.java.net/~mlarsson/8064348/webrev.01/ Thanks, Marcus On 07/11/14 20:49, Staffan Larsen wrote: On 7 nov 2014, at 16:40, Erik Helin wrote: Hi

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-10 Thread Bengt Rutisson
On 2014-11-08 09:11, Dmitry Fazunenko wrote: Hi Mandy, On 08.11.2014 02:41, Mandy Chung wrote: On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ What are the valid values ofvm.gc? It's a bit awk for null as a valid value and I would ima

Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-10 Thread Kim Barrett
On Nov 7, 2014, at 6:41 PM, Mandy Chung wrote: > > On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: >> >> http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ > > What are the valid values of vm.gc? It's a bit awk for null as a valid value > and I would imagine "*" wildcard may be a better va

RFR (8u40) 8064288 : sun.management.Flag should loadLibrary()

2014-11-10 Thread Brent Christian
Please review my change for: 8064288 - sun.management.Flag should loadLibrary() JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8064288 Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ Thanks, -Brent

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-10 Thread Dmitry Fazunenko
On 10.11.2014 20:28, Bengt Rutisson wrote: On 2014-11-08 09:11, Dmitry Fazunenko wrote: Hi Mandy, On 08.11.2014 02:41, Mandy Chung wrote: On 11/7/14 3:34 AM, Evgeniya Stepanova wrote: http://cr.openjdk.java.net/~eistepan/8062536/webrev.02/ What are the valid values ofvm.gc? It's a bit aw

Re: RFR (8u40) 8064288 : sun.management.Flag should loadLibrary()

2014-11-10 Thread Mandy Chung
On 11/10/2014 1:16 PM, Brent Christian wrote: Please review my change for: 8064288 - sun.management.Flag should loadLibrary() JBS Issue: https://bugs.openjdk.java.net/browse/JDK-8064288 Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ Looks fine to me. Mandy

RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-10 Thread Daniel D. Daugherty
Greetings, I have a Solaris Full Debug Symbols (FDS) fix ready for review. Yes, it is a small fix, but it is in Makefiles so feel free to run screaming from the room... :-) On the plus side the fix does delete two work around source files (Coleen would say that's a Good Thing (TM)!) The fix is