Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread Ivan Gerasimov
Hi Markus! The priority of the exiting thread will be raised for quite a short period of time -- right before the thread finishes exiting. There are two places where the priority is adjusted. Under normal conditions we should never see the first place hit. However, if we do, this means we ha

Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread Daniel D. Daugherty
Ivan, I spoke too soon. There's a review comment from Markus G that hasn't been addressed. We need to see if you've convinced Markus in addition to David H. Dan P.S. Look for Markus' reply to David H's e-mail; it not in this fork of the review thread... On 11/17/14 7:01 PM, Daniel D. Daugher

Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread Daniel D. Daugherty
Ivan, Please coordinate with Staffan Larsen about when he is planning to take this week's snapshot of JDK9-hs-rt (RT_Baseline). Please push your fix after Staffan's snapshot so we can have a week of soak time for this version of the fix... Dan On 11/17/14 6:50 PM, David Holmes wrote: Hi Ivan,

Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread David Holmes
Hi Ivan, On 17/11/2014 7:00 PM, Ivan Gerasimov wrote: Thanks David! On 17.11.2014 9:40, David Holmes wrote: On 17/11/2014 7:23 AM, Ivan Gerasimov wrote: Thank you Daniel! Please find the updated webrev with your suggestions incorporated here: http://cr.openjdk.java.net/~igerasim/8064694/1/we

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-11-17 Thread Maynard Johnson
On 11/17/2014 01:21 PM, Volker Simonis wrote: > On Mon, Nov 17, 2014 at 6:59 PM, Maynard Johnson wrote: >> On 11/17/2014 10:20 AM, Volker Simonis wrote: >>> Hi Maynard, >>> >>> I'm currently looking at your changes. At first glance they look good. >>> >>> I could open a simple core file which cont

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-11-17 Thread Volker Simonis
On Mon, Nov 17, 2014 at 6:59 PM, Maynard Johnson wrote: > On 11/17/2014 10:20 AM, Volker Simonis wrote: >> Hi Maynard, >> >> I'm currently looking at your changes. At first glance they look good. >> >> I could open a simple core file which contained both, interpreted and >> compiled frames: >> >>

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-11-17 Thread Maynard Johnson
On 11/17/2014 10:20 AM, Volker Simonis wrote: > Hi Maynard, > > I'm currently looking at your changes. At first glance they look good. > > I could open a simple core file which contained both, interpreted and > compiled frames: > > $ jstack ./images/j2sdk-image/bin/java core.7034 > ... > Thread

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-11-17 Thread Volker Simonis
Hi Maynard, I'm currently looking at your changes. At first glance they look good. I could open a simple core file which contained both, interpreted and compiled frames: $ jstack ./images/j2sdk-image/bin/java core.7034 ... Thread 7035: (state = IN_VM) - sun.misc.Unsafe.putAddress(long, long) @b

Re: [PATCH RFC 0/2] Add linux/ppc64 support for Hotspot serviceability agent to read core files

2014-11-17 Thread Maynard Johnson
On 11/14/2014 05:09 PM, Volker Simonis wrote: > > > On Friday, November 14, 2014, Vladimir Kozlov > wrote: > > Volker or Goetz, can you help Maynard to create bugs and prepare webrevs > on cr.openjdk for these 3 changes? > > > I will create the bugs and

Re: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread Ivan Gerasimov
Thanks David! On 17.11.2014 9:40, David Holmes wrote: On 17/11/2014 7:23 AM, Ivan Gerasimov wrote: Thank you Daniel! Please find the updated webrev with your suggestions incorporated here: http://cr.openjdk.java.net/~igerasim/8064694/1/webrev/ Concerning the thread priority: If the applicatio

RE: RFR 8064694: Kitchensink: WaitForMultipleObjects failed in hotspot\src\os\windows\vm\os_windows.cpp: 3844

2014-11-17 Thread Markus Grönlund
I agree with David. The side effects will be unknown and very hard to debug. Is there another way to accomplish the results without manipulating base services? Thanks Markus -Original Message- From: David Holmes Sent: den 17 november 2014 07:40 To: Ivan Gerasimov; Daniel Daugherty Cc: