Re: A hotspot patch for stack profiling (frame pointer)

2014-12-05 Thread Brendan Gregg
G'Day Volker, On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis wrote: > Hi Brendan, > > I'm still not understanding who is taking the actual stack traces (let > alone the symbols) in your examples. Is this done by 'perf' itself > based only on the frame pointer? perf is walking the frame pointers

Re: A hotspot patch for stack profiling (frame pointer)

2014-12-05 Thread Volker Simonis
Yes, that's clear. I didn't wanted to propose using "jstack -F" directly. I just wanted to say that it's possible for an external tool to get a "reasonable good" stack trace out of a JVM process at any time and "jstack -F" can be taken as a boilerplate of how to do that. That said, I still don't k

Re: A hotspot patch for stack profiling (frame pointer)

2014-12-05 Thread Brendan Gregg
On Thu, Dec 4, 2014 at 2:55 PM, Brendan Gregg wrote: > G'Day, > > I've hacked hotspot to return the frame pointer, in part to see what this > involves, and also to have a working prototype for analysis. Along with an > agent to resolve symbols, this has allowed full stack profiling using Linux >

Re: A hotspot patch for stack profiling (frame pointer)

2014-12-05 Thread Staffan Larsen
Just to note that the implementation of “jstack -F” is not at all suitable for profiling since has a very high overhead (it attaches a debugger to the process). /Staffan > On 5 dec 2014, at 20:22, Volker Simonis wrote: > > Hi Brendan, > > I'm still not understanding who is taking the actual

Re: A hotspot patch for stack profiling (frame pointer)

2014-12-05 Thread Volker Simonis
Hi Brendan, I'm still not understanding who is taking the actual stack traces (let alone the symbols) in your examples. Is this done by 'perf' itself based only on the frame pointer? As I wrote before, this is pretty hard to get right for a JVM, but there are good approximations. Have you looked

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

2014-12-05 Thread Volker Simonis
Hi Sasha, thanks for looking at this change. I'll incorporate your suggestions into the final version. I'm just waiting for one more review before preparing a new webrev. Regards, Volker On Fri, Dec 5, 2014 at 3:10 PM, Maynard Johnson wrote: > On 12/04/2014 07:50 PM, Alexander Smundak wrote: >

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

2014-12-05 Thread Maynard Johnson
On 12/04/2014 07:50 PM, Alexander Smundak wrote: > You are correct, but there no need to have this code for LE at all. Agreed. I'm fine with adding the "&& !defined(ABI_ELFv2)" throughout that file along with the "#if defined(ppc64)". > > BTW, a bit on nitpicking in the same file: > +String en

Re: RFR 8064441: java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

2014-12-05 Thread Jaroslav Bachorik
On 12/05/2014 02:19 AM, David Holmes wrote: On 3/12/2014 1:51 AM, Jaroslav Bachorik wrote: On 12/02/2014 10:37 AM, David Holmes wrote: On 1/12/2014 7:16 PM, Jaroslav Bachorik wrote: On 11/27/2014 09:33 AM, Jaroslav Bachorik wrote: On 11/27/2014 01:43 AM, David Holmes wrote: On 26/11/2014 10: