I assume you meant to cc jmx-dev for this one. In any case it looks okay
to me.
-Alan
On 08/12/2014 07:04, joe darcy wrote:
Hello,
Please review the patch below which addresses
JDK-8066634: Suppress deprecation warnings in java.management module
Thanks,
-Joe
diff -r 913808eaf19a
Hi Joe,
Looks good!
best regards,
-- daniel
On 12/8/14 8:04 AM, joe darcy wrote:
Hello,
Please review the patch below which addresses
JDK-8066634: Suppress deprecation warnings in java.management module
Thanks,
-Joe
diff -r 913808eaf19a
Looks good.
Some minor comments.
Better to reformat with one variable at a line:
113 const char *error_message = NULL, *jrepath = NULL, *libname = NULL;
283 jbyte *start, *end;
Uninitialized locals:
115 #ifdef _WINDOWS
116 HINSTANCE hsdis_handle;
117 #else
118 void*
On 12/05/2014 05:09 PM, Brendan Gregg wrote:
G'Day Volker,
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Brendan,
I'm still not understanding who is taking the actual stack traces (let
alone the symbols) in your examples. Is this done by 'perf' itself
On Mon, Dec 8, 2014 at 4:05 PM, Maynard Johnson mayna...@us.ibm.com wrote:
On 12/05/2014 05:09 PM, Brendan Gregg wrote:
G'Day Volker,
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Brendan,
I'm still not understanding who is taking the actual stack
Maynard,
On 2014-12-08 16:05, Maynard Johnson wrote:
On 12/05/2014 05:09 PM, Brendan Gregg wrote:
G'Day Volker,
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Brendan,
I'm still not understanding who is taking the actual stack traces (let
alone the
Please, review this small test adjustment
Issue : https://bugs.openjdk.java.net/browse/JDK-8059949
Webrev: http://cr.openjdk.java.net/~jbachorik/8059949/webrev.01
The test is failing very intermittently when run on fastdebug builds. In
the diagnostic output there is no indication of any
Looks good!
Thanks,
/Staffan
On 8 dec 2014, at 19:09, Jaroslav Bachorik jaroslav.bacho...@oracle.com
wrote:
Please, review this small test adjustment
Issue : https://bugs.openjdk.java.net/browse/JDK-8059949
Webrev: http://cr.openjdk.java.net/~jbachorik/8059949/webrev.01
The test is
On 8 dec 2014, at 16:05, Maynard Johnson mayna...@us.ibm.com wrote:
On 12/05/2014 05:09 PM, Brendan Gregg wrote:
G'Day Volker,
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis
volker.simo...@gmail.com wrote:
Hi Brendan,
I'm still not understanding who is taking the actual stack traces
G'Day Staffan,
On Mon, Dec 8, 2014 at 11:17 AM, Staffan Larsen
staffan.lar...@oracle.com wrote:
On 8 dec 2014, at 16:05, Maynard Johnson mayna...@us.ibm.com wrote:
[...]
And if the VM creates a /tmp/perf-PID.map file to save information about
JITed methods, the perf's post-profiling tool
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8066708
Webrev: http://cr.openjdk.java.net/~jbachorik/8066708/webrev.00
The test fails very intermittently when RMI registry is trying to bind
to a port previously used in the test (via ServerSocket).
G'Day Mikael,
On Mon, Dec 8, 2014 at 9:15 AM, Mikael Gerdin mikael.ger...@oracle.com wrote:
Maynard,
On 2014-12-08 16:05, Maynard Johnson wrote:
[...]
And if the VM creates a /tmp/perf-PID.map file to save information about
JITed methods, the perf's post-profiling tool will find it and
On 12/8/14 12:35 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8066708
Webrev: http://cr.openjdk.java.net/~jbachorik/8066708/webrev.00
The test fails very intermittently when RMI registry is trying to bind to a port
13 matches
Mail list logo
