Stuart,
1. Ever if you set SO_LINGER to zero, socket will not be closed
immediately. see TCP shutdown sequence.
2. In a native world it's quite easy to find the port your rmi server
uses - it could be achieved by parsing /proc//net/tcp on Linux or
using special API on windows and solaris.
3. For
Volker,
The changes looks good for me and I'll sponsor the push.
But please check, whether you need one more reviewer or not.
-Dmitry
On 2014-12-17 20:37, Volker Simonis wrote:
> Hi Dmitry,
>
> once again, thanks for your detailed review. You can find the new
> version of the webrev under:
>
Hi Dmitry,
once again, thanks for your detailed review. You can find the new
version of the webrev under:
http://cr.openjdk.java.net/~simonis/webrevs/8049716.v2/
I've rebased it to the latest jdk9/hs-rt repository today.
I hope I adressed all your concerns. Please find my additional
comments in
Please, review the second round fix for:
https://bugs.openjdk.java.net/browse/JDK-8008678
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/8008678-JVMTI-pseudo.2/
Summary:
This fix implements a footprint saving approach suggested by Coleen.
To be able to reconstitut
Hi,
I'd like a review of a backport of these test changes, into 8u.
webrev:
http://cr.openjdk.java.net/~kevinw/8039995_8061785/webrev.00/
Changes simply hg imported from:
8039995
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/raw-rev/da92e4c42b24
8061785
http://hg.openjdk.java.net/jdk9/hs-rt/h
Looks good
Erik
Markus Grönlund skrev 2014-12-17 15:45:
Greetings,
Kindly asking for reviews for the following changeset:
Bug: https://bugs.openjdk.java.net/browse/JDK-8066814
Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/
Description:
TraceEvent currently ex
Greetings,
Kindly asking for reviews for the following changeset:
Bug: https://bugs.openjdk.java.net/browse/JDK-8066814
Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/
Description:
TraceEvent currently exposes internals unnecessarily.
Therefore:
Remove unneces
Hi Katja,
On 17/12/14 14:11, Yekaterina Kantserova wrote:
Hopefully the last version :)
Erik has recommended to skip the whole timeout concept. Instead the test
will loop until a decreasing count is found. Otherwise the test will
timeout. The default JTreg time out is 5 minutes so it would be
On 12/17/2014 02:11 PM, Yekaterina Kantserova wrote:
Hopefully the last version :)
Erik has recommended to skip the whole timeout concept. Instead the test
will loop until a decreasing count is found. Otherwise the test will
timeout. The default JTreg time out is 5 minutes so it would be enough
Hopefully the last version :)
Erik has recommended to skip the whole timeout concept. Instead the test
will loop until a decreasing count is found. Otherwise the test will
timeout. The default JTreg time out is 5 minutes so it would be enough
even for slower configurations.
The new webrev c
On 17/12/14 12:05, Yekaterina Kantserova wrote:
Daniel,
It's really funny to get such a feedback!
(1) The output from test right now looks like:
--System.out:(7/183)--
call count = 1000
instance count: 1001
call count = 2000
instance count: 1001
Finishing early due to non-incre
Daniel,
It's really funny to get such a feedback!
(1) The output from test right now looks like:
--System.out:(7/183)--
call count = 1000
instance count: 1001
call count = 2000
instance count: 1001
Finishing early due to non-increasing instance count
increasing count: 1
decreasi
Please, review the following change.
Issue : https://bugs.openjdk.java.net/browse/JDK-8067447
Webrev: http://cr.openjdk.java.net/~jbachorik/8067447/webrev.00
This patch is a precursor for implementing
https://bugs.openjdk.java.net/browse/JDK-8054890 which itself is a part
of JEP-228 (https://b
Hi Katja,
Sorry for not thinking of that when I replied earlier.
Your new test is so much more readable than the old shell
script :-)
These are minor suggestions but they might help analysis
if the test fails:
On 17/12/14 10:10, Yekaterina Kantserova wrote:
Hi,
Thanks for all reviews!
The n
Adding Erik.
On 12/17/2014 10:10 AM, Yekaterina Kantserova wrote:
Hi,
Thanks for all reviews!
The new webrev can be found here:
http://cr.openjdk.java.net/~ykantser/6977426/webrev.01/
// Katja
On 12/16/2014 05:41 PM, Jaroslav Bachorik wrote:
Hi Katja,
This request should probably go to
Hi,
Thanks for all reviews!
The new webrev can be found here:
http://cr.openjdk.java.net/~ykantser/6977426/webrev.01/
// Katja
On 12/16/2014 05:41 PM, Jaroslav Bachorik wrote:
Hi Katja,
This request should probably go to core-libs as well.
Other than that I have just a few nits:
test/j
16 matches
Mail list logo
