Re: Change "8057744: (process) Synchronize exiting of threads and process [win]" breaks HotSpot on Win Server 2003

2014-12-23 Thread Ivan Gerasimov
Hi Volker! Yes, I do hope to port this fix to jdk8u, once it is proved to fix the bug. However, as you correctly noticed, it will require some reorganization of the code: the initialization of the critical section will be done with initialization of other global variables. I preferred to do it

Change "8057744: (process) Synchronize exiting of threads and process [win]" breaks HotSpot on Win Server 2003

2014-12-23 Thread Volker Simonis
Hi Ivan, I have just realized that the change 8057744 breaks HotSpot on Windows Server 2003 because the InitOnceExecuteOnce function isn't supported there. I suppose you're aware of this as the change contains the following comment in os_windows.cpp: // Must be at least Windows Vista or Server 20

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread Dmitrij Pochepko
Hi, There is one more issues related to these tests(not directly). Currently, dtrace tests can't be run in jprt, because dtrace require additional previleges for launching user. Perhaps it's just user to be granted previleges in jprt solaris hosts... Not sure about some guard in tests... the on

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread serguei.spit...@oracle.com
Hi Dmitrij, There is still a typo in spelling (DESCTRUCTIVE => DESTRUCTIVE): test/testlibrary/com/oracle/java/testlibrary/dtrace/DtraceRunner.java 42 public static final String PERMIT_DESCTRUCTIVE_ACTIONS_DTRACE_OPTION = "w"; test/compiler/codecache/dtrace/SegmentedCodeCacheDtraceTest

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread Dmitrij Pochepko
Hi, please review updated webrev http://cr.openjdk.java.net/~iignatyev/dpochepk/8059625/webrev.01/ Thanks, Dmitrij On 12/23/14 12:37 AM, Dmitrij Pochepko wrote: Hi, Thank you for catching these issues. I have a question regarding last comment: does it make any difference to change "reading o

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread serguei.spit...@oracle.com
On 12/23/14 12:37 AM, Dmitrij Pochepko wrote: Hi, Thank you for catching these issues. I have a question regarding last comment: does it make any difference to change "reading of static member 3 times" to "copying into static member of another class and then read it 3 times"? Yes, it does (i

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread Dmitrij Pochepko
Hi, Thank you for catching these issues. I have a question regarding last comment: does it make any difference to change "reading of static member 3 times" to "copying into static member of another class and then read it 3 times"? Thanks, Dmitrij Hi Dmitry, It looks good in general. Some m

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-23 Thread Dmitrij Pochepko
Looks like that. Will fix. Thank you. Dmitrij 40 public static int[] getAvailableCompilationLevels() { 41 if (System.getProperty("java.vm.info").startsWith("interpreted ")) { 42 return new int[0]; 43 } Wouldn’t it be better to check the UseCompiler f