Re: 4-th round RFR (XS) 8068162: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

2015-01-23 Thread Coleen Phillimore
This still looks good to me. Coleen On 1/23/15, 9:06 AM, Daniel D. Daugherty wrote: Serguei, Sorry I forgot to close the loop on this review. I'm OK with the answers below. Thumbs up. Dan On 1/19/15 10:22 AM, serguei.spit...@oracle.com wrote: Coleen, Thank you for answering questions

Re: 4-th round RFR (XS) 8068162: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

2015-01-23 Thread serguei.spit...@oracle.com
Coleen and Dan, Thanks! Serguei On 1/23/15 8:51 AM, Coleen Phillimore wrote: This still looks good to me. Coleen On 1/23/15, 9:06 AM, Daniel D. Daugherty wrote: Serguei, Sorry I forgot to close the loop on this review. I'm OK with the answers below. Thumbs up. Dan On 1/19/15 10:22 AM,

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

2015-01-23 Thread Yekaterina Kantserova
Hi, New webrev can be found here http://cr.openjdk.java.net/~ykantser/8044419/webrev.03/ The fix has been tested on all platforms except embedded. Thanks, Katja On 01/21/2015 12:56 PM, Dmitry Samersoff wrote: Mattias, 1. mkFiles at ll. 215 above is reluctant 2. if you wish to store id

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

2015-01-23 Thread Dmitry Samersoff
Looks good for me. -Dmitry On 2015-01-23 11:51, Yekaterina Kantserova wrote: Hi, New webrev can be found here http://cr.openjdk.java.net/~ykantser/8044419/webrev.03/ The fix has been tested on all platforms except embedded. Thanks, Katja On 01/21/2015 12:56 PM, Dmitry Samersoff

Re: 4-th round RFR (XS) 8068162: jvmtiRedefineClasses.cpp: guarantee(false) failed: OLD and/or OBSOLETE method(s) found

2015-01-23 Thread Daniel D. Daugherty
Serguei, Sorry I forgot to close the loop on this review. I'm OK with the answers below. Thumbs up. Dan On 1/19/15 10:22 AM, serguei.spit...@oracle.com wrote: Coleen, Thank you for answering questions below! Thanks, Serguei On 1/19/15 7:55 AM, Coleen Phillimore wrote: On 1/16/15, 9:24

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

2015-01-23 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 23 jan 2015, at 09:51, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, New webrev can be found here http://cr.openjdk.java.net/~ykantser/8044419/webrev.03/ The fix has been tested on all platforms except embedded. Thanks, Katja

Re: RFR(S): 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root

2015-01-23 Thread Yekaterina Kantserova
Dmitry, Staffan, thanks for your reviews! // Katja On 01/23/2015 04:43 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 23 jan 2015, at 09:51, Yekaterina Kantserova yekaterina.kantser...@oracle.com wrote: Hi, New webrev can be found here