Re: gdb and OpenJDK

2015-02-19 Thread Jeremy Manson
Hey folks, I just want to make sure we are on the same page here: 1) Andrew is talking about using the gdbjit interface and generated DWARF information. I believe this wouldn't work for interpreted code, because there is no JIT information emitted for it. It would also require extra work to mak

Re: RFR(XS) for PeriodicTask_lock cleanup (8072439)

2015-02-19 Thread David Holmes
On 20/02/2015 9:03 AM, Daniel D. Daugherty wrote: On 2/18/15 7:02 PM, David Holmes wrote: Hi Dan, On 19/02/2015 2:28 AM, Daniel D. Daugherty wrote: David, Thanks for the fast review! Replies embedded below... On 2/17/15 5:53 PM, David Holmes wrote: Hi Dan, A few comments, mainly on the co

Re: RFR(XS) for PeriodicTask_lock cleanup (8072439)

2015-02-19 Thread Daniel D. Daugherty
On 2/18/15 7:02 PM, David Holmes wrote: Hi Dan, On 19/02/2015 2:28 AM, Daniel D. Daugherty wrote: David, Thanks for the fast review! Replies embedded below... On 2/17/15 5:53 PM, David Holmes wrote: Hi Dan, A few comments, mainly on the comments :) Apropos since the changeset is mostly c

Re: gdb and OpenJDK

2015-02-19 Thread Alexander Smundak
On Mon, Feb 16, 2015 at 2:52 AM, Andrew Haley wrote: > It would be, long term. I've been discussing this with Red Hat's GDB > group and I'm hoping to come up with a proposal and hopefully some > working code. I have the enabling patch to GDB being reviewed at a glacial pace (see https://sourcewar

Re: Review Request: 8062750 Separate SNMP messages from sun.management.resources.agent

2015-02-19 Thread Alan Bateman
On 19/02/2015 19:01, Mandy Chung wrote: This removes the SNMP messages from the sun.management.resources.agent resource bundle: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8062750/webrev.00/ This looks good. -Alan

Re: Review Request: 8062750 Separate SNMP messages from sun.management.resources.agent

2015-02-19 Thread Daniel Fuchs
Looks good Mandy! -- daniel On 19/02/15 20:01, Mandy Chung wrote: This removes the SNMP messages from the sun.management.resources.agent resource bundle: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8062750/webrev.00/ thanks Mandy

Review Request: 8062750 Separate SNMP messages from sun.management.resources.agent

2015-02-19 Thread Mandy Chung
This removes the SNMP messages from the sun.management.resources.agent resource bundle: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8062750/webrev.00/ thanks Mandy

Re: gdb and OpenJDK

2015-02-19 Thread Kelly O'Hair
I spent a great deal of time with native object file debugging formats. But the size of the Dwarf .debuginfo section of a .so file should not be used as a measure of the debug info size for a single object file. Back when I worked with the older Stabs debug format (a less structured format), the