Thanks a lot, Coleen!
Serguei
On 2/20/15 6:08 PM, Coleen Phillimore wrote:
Serguei, Looks great.
Thanks,
Coleen
On 2/20/15, 4:32 PM, serguei.spit...@oracle.com wrote:
The hotspot webrev below addresses the Coleen's comments from the
1-st review round.
Open hotspot webrev:
http://cr.openjd
Serguei, Looks great.
Thanks,
Coleen
On 2/20/15, 4:32 PM, serguei.spit...@oracle.com wrote:
The hotspot webrev below addresses the Coleen's comments from the 1-st
review round.
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8046246-JVMTI-redefscale.2/
Ope
The hotspot webrev below addresses the Coleen's comments from the 1-st
review round.
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8046246-JVMTI-redefscale.2/
Open jdk (new unit test) webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/jdk/8046246-JVMTI-ma
In jsr166 we rarely use @see, regarding it as a vestige of a time when
@link and @linkplain were not available. Just work a @linkplain into the
javadoc. E.g.
+/**
+ * Returns the {@linkplain Thread#priority() thread priority} of
the thread associated with this
+ * {@code ThreadInfo}.
Hi Coleen,
On 2/20/15 9:56 AM, Coleen Phillimore wrote:
Hi Serguei, This looks good but I have some comments:
Thanks a lot for good suggestions and help in the internal review!
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8046246-JVMTI-redefscale.1/src/share/vm/oops/klassVtab
Hi Serguei, This looks good but I have some comments:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8046246-JVMTI-redefscale.1/src/share/vm/oops/klassVtable.cpp.udiff.html
How can (old_method == new_method) in adjust_method_entries? If
old_method->is_old() then you're not updati
>> On Mon, Feb 16, 2015 at 2:52 AM, Andrew Haley wrote:
>> It would be, long term. I've been discussing this with Red Hat's GDB
>> group and I'm hoping to come up with a proposal and hopefully some
>> working code.
> I have the enabling patch to GDB being reviewed at a glacial pace (see
> https:/
On 02/16/2015 04:23 PM, Mario Torre wrote:
> Thermostat does support that natively with the CLI interface. Also I
> believe Visual VM can deal with saved and exported hprof dumps,
> likewise MAT (and Thermostat), which is probably the most advanced at
> this stage - so no need to install software r
The CCC request was approved for this change, but there were a couple of
comments:
1) "First, syntactically for the javadoc please use "{@code foo}" rather than
"foo”.”
I think you have covered this.
2) "You may want to say a bit more about the possible return values of
ThreadInfo.getPriority
