On 5/03/2015 11:12 AM, David Holmes wrote:
On 5/03/2015 10:07 AM, Jeremy Manson wrote:
I'm happy to s/os::getenv/getenv/g if we know it works on Windows. I
assumed that there was some safety / security reason for requiring the
copying - otherwise, why does this interface exist at all?
I don't
On 6/03/2015 4:10 AM, Jeremy Manson wrote:
Martin points out that getenv on Windows isn't portable (which is to
say, it doesn't work on WindowsRT). Do we care? If so, then I'll have
os::getenv do an allocation on Windows, and have it return a unique
pointer like thing. (Of course, I have no wa
Looks good to me too Shanliang.
-- daniel
On 04/03/15 19:41, Jaroslav Bachorik wrote:
Hi Shanliang,
This looks fine.
I have few minor nits:
* ClientNotifForwarder.java#544 - Should read "Received" instead of
"Receives"
* copyright year updates to both of files
No need to re-review.
-JB-
O
Your expression looks good to me (and I verified that it solved the jconsole
bug). I will push that.
Thanks,
/Staffan
> On 5 mar 2015, at 10:05, Erik Joelsson wrote:
>
> Hello,
>
> The specification for the properties file format says that a comment is a
> line that has either a ! or # as th
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8074041
Webrev: http://cr.openjdk.java.net/~jbachorik/8074041/webrev.00
This test fails very intermittently still and the failure is very hard
to reproduce. Based on the symptoms the probable cause seems to be
Hello,
The specification for the properties file format says that a comment is
a line that has either a ! or # as the first non whitespace character.
Greping around in the source shows we have several instances if comments
tarting a few spaces in. I don't think we are using ! for comments
any
